From patchwork Thu Jan 4 13:35:55 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin King X-Patchwork-Id: 10144743 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 98BB36034B for ; Thu, 4 Jan 2018 13:36:11 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 908E323B34 for ; Thu, 4 Jan 2018 13:36:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 84BCA2860B; Thu, 4 Jan 2018 13:36:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2299423B34 for ; Thu, 4 Jan 2018 13:36:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753141AbeADNf6 (ORCPT ); Thu, 4 Jan 2018 08:35:58 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:54028 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753001AbeADNf4 (ORCPT ); Thu, 4 Jan 2018 08:35:56 -0500 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1eX5gZ-0000jL-Eb; Thu, 04 Jan 2018 13:35:55 +0000 From: Colin King To: Steve French , linux-cifs@vger.kernel.org, samba-technical@lists.samba.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH][cifs-next] CIFS: SMBD: make functions smbd_recv_buf and smbd_recv_page static Date: Thu, 4 Jan 2018 13:35:55 +0000 Message-Id: <20180104133555.8449-1-colin.king@canonical.com> X-Mailer: git-send-email 2.14.1 MIME-Version: 1.0 Sender: linux-cifs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Colin Ian King The functions smbd_recv_buf and smbd_recv_page are local to the source and do not need to be in global scope, so make them static. Cleans up sparse warnings: symbol 'smbd_recv_buf' was not declared. Should it be static? symbol 'smbd_recv_page' was not declared. Should it be static? Signed-off-by: Colin Ian King --- fs/cifs/smbdirect.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/fs/cifs/smbdirect.c b/fs/cifs/smbdirect.c index 731577d4317f..0d0545ef735f 100644 --- a/fs/cifs/smbdirect.c +++ b/fs/cifs/smbdirect.c @@ -1855,7 +1855,8 @@ struct smbd_connection *smbd_get_connection( * consumed. But this will require more changes to upper layer code, and also * need to consider packet boundaries while they still being reassembled. */ -int smbd_recv_buf(struct smbd_connection *info, char *buf, unsigned int size) +static int smbd_recv_buf(struct smbd_connection *info, char *buf, + unsigned int size) { struct smbd_response *response; struct smbd_data_transfer *data_transfer; @@ -1995,8 +1996,8 @@ int smbd_recv_buf(struct smbd_connection *info, char *buf, unsigned int size) * to_read: the length of data to read * return value: actual data read */ -int smbd_recv_page(struct smbd_connection *info, - struct page *page, unsigned int to_read) +static int smbd_recv_page(struct smbd_connection *info, + struct page *page, unsigned int to_read) { int ret; char *to_address;