| Message ID | 20180619122530.a7b5ic6jdsl65ez5@kili.mountain (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Dan Carpenter <dan.carpenter@oracle.com> writes: > This is not really a runtime issue but Smatch complains that: > > fs/cifs/smb2ops.c:1740 smb2_query_symlink() > error: uninitialized symbol 'resp_buftype'. > > The warning is right that it can be uninitialized... Also "err_buf" > would be NULL at this point and we're not supposed to pass NULLs to > free_rsp_buf() or it might trigger some extra output if we turn on > debugging. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by: Paulo Alcantara <palcantara@suse.de> Thanks Paulo -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
merged into cifs-2.6.git for-next On Tue, Jun 19, 2018 at 8:12 AM, Paulo Alcantara <paulo@paulo.ac> wrote: > Dan Carpenter <dan.carpenter@oracle.com> writes: > >> This is not really a runtime issue but Smatch complains that: >> >> fs/cifs/smb2ops.c:1740 smb2_query_symlink() >> error: uninitialized symbol 'resp_buftype'. >> >> The warning is right that it can be uninitialized... Also "err_buf" >> would be NULL at this point and we're not supposed to pass NULLs to >> free_rsp_buf() or it might trigger some extra output if we turn on >> debugging. >> >> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > Reviewed-by: Paulo Alcantara <palcantara@suse.de> > > Thanks > Paulo > -- > To unsubscribe from this list: send the line "unsubscribe linux-cifs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c index 0356b5559c71..5649cd3f377d 100644 --- a/fs/cifs/smb2ops.c +++ b/fs/cifs/smb2ops.c @@ -1697,7 +1697,7 @@ smb2_query_symlink(const unsigned int xid, struct cifs_tcon *tcon, &resp_buftype); if (!rc || !err_iov.iov_base) { rc = -ENOENT; - goto querty_exit; + goto free_path; } err_buf = err_iov.iov_base; @@ -1738,6 +1738,7 @@ smb2_query_symlink(const unsigned int xid, struct cifs_tcon *tcon, querty_exit: free_rsp_buf(resp_buftype, err_buf); + free_path: kfree(utf16_path); return rc; }
This is not really a runtime issue but Smatch complains that: fs/cifs/smb2ops.c:1740 smb2_query_symlink() error: uninitialized symbol 'resp_buftype'. The warning is right that it can be uninitialized... Also "err_buf" would be NULL at this point and we're not supposed to pass NULLs to free_rsp_buf() or it might trigger some extra output if we turn on debugging. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html