diff mbox

cifs-utils: support rst2man-3

Message ID 20180717052550.GA11106@onega.vda.li (mailing list archive)
State New, archived
Headers show

Commit Message

Alexander Bokovoy July 17, 2018, 5:25 a.m. UTC
Hi,

Python 3 version of rst2man utility is called rst2man-3. On systems
without python 2 bits rst2man is not found. This patch adds support for
rst2man-3 so that man pages can still be created.

Comments

Aurélien Aptel July 17, 2018, 8:06 a.m. UTC | #1
Alexander Bokovoy <ab@samba.org> writes:

> Hi,
>
> Python 3 version of rst2man utility is called rst2man-3. On systems
> without python 2 bits rst2man is not found. This patch adds support for
> rst2man-3 so that man pages can still be created.

It's called rst2man-3.4 here, you probably want to check for that too.

>  # if docs are not disabled, check if rst2man is available
>  if test $enable_man != "no"; then
> -	AC_CHECK_PROG(have_rst2man, rst2man, yes, no)
> +	AC_CHECK_PROGS(have_rst2man, rst2man-3 rst2man, no)
>  	if test $have_rst2man = "no"; then
>  		if test $enable_man = "yes"; then
>  			AC_MSG_ERROR([rst2man not found: cannot generate man pages, consider installing perl.])
                                                                                     ^^^^^^^^^^^^^^^^^^^^^^^

Should be "python" and/or even python(3)-docutils, which doesn't look
like a base package.

Cheers,
diff mbox

Patch

diff --git a/configure.ac b/configure.ac
index b0bc2b9..26d60ea 100644
--- a/configure.ac
+++ b/configure.ac
@@ -252,7 +252,7 @@  fi
 
 # if docs are not disabled, check if rst2man is available
 if test $enable_man != "no"; then
-	AC_CHECK_PROG(have_rst2man, rst2man, yes, no)
+	AC_CHECK_PROGS(have_rst2man, rst2man-3 rst2man, no)
 	if test $have_rst2man = "no"; then
 		if test $enable_man = "yes"; then
 			AC_MSG_ERROR([rst2man not found: cannot generate man pages, consider installing perl.])