| Message ID | 20200228092043.xoqau6ez7qxnpwc4@kili.mountain (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | cifs: potential unintitliazed error code in cifs_getattr() | expand |
diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c index 6543465595f6..e6d66977a81d 100644 --- a/fs/cifs/inode.c +++ b/fs/cifs/inode.c @@ -2203,7 +2203,7 @@ int cifs_getattr(const struct path *path, struct kstat *stat, if (!(cifs_sb->mnt_cifs_flags & CIFS_MOUNT_OVERR_GID)) stat->gid = current_fsgid(); } - return rc; + return 0; } int cifs_fiemap(struct inode *inode, struct fiemap_extent_info *fei, u64 start,
Smatch complains that "rc" could be uninitialized. fs/cifs/inode.c:2206 cifs_getattr() error: uninitialized symbol 'rc'. Changing it to "return 0;" improves readability as well. Fixes: cc1baf98c8f6 ("cifs: do not ignore the SYNC flags in getattr") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- fs/cifs/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)