From patchwork Mon Aug 8 02:43:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Atte_Heikkil=C3=A4?= X-Patchwork-Id: 12938441 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7AA0C25B0C for ; Mon, 8 Aug 2022 02:47:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242910AbiHHCrJ (ORCPT ); Sun, 7 Aug 2022 22:47:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244154AbiHHCqu (ORCPT ); Sun, 7 Aug 2022 22:46:50 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 188BF13D72 for ; Sun, 7 Aug 2022 19:44:05 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id v2so2138776lfi.6 for ; Sun, 07 Aug 2022 19:44:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=bgE+UMo9Vo+rfBsSHMr4wD8GPdfh6ZtGp/tMNdv+oq4=; b=PF+shWvvtMASNZj9keR8EMhxOqJgtkBwEvZ8Sn9ZQ8PUtiNzDB9Sl9APK5NRKAHg1h L9aN/k2RDSRTnpl6kTJ52xcuDuuF0dPg14QgIZa7BTxbSNv+8otvewA0wY41R8YLdYvV OPcmE3WJ84vlJZYvy+rYf8jOEuSLEiHoCAFb/jeOSs8epMp5WDeFG2tDfMrJYzSXmZ6T tOEmZ6ylJh/nYPOfZpIwtFAMpJZKAoVbqZeDoORAkMPd8EmxxSSUwhE3psTtpm7M5cpa ty/JwoQ9C56IQkrE+RlRauR/Jh9+2FTuI1N2UTXhutP91PntYzfN5u0QVZqaq8iyPo9L Zfiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=bgE+UMo9Vo+rfBsSHMr4wD8GPdfh6ZtGp/tMNdv+oq4=; b=MkQinU9c0bUxLqeJ/XGW2rpJIZYS2A/uU/pxTvuOIAFXCephHAPqzKhwi8TWk9m2B1 g1Tx+LZZZMghdYmnuQ+NToGS3nv4PCW6TnS8qBzVYyjM4SbOrlpSzmnjRY2m8IzIRTUs /Jq9pS31UAjqJqHZ61vrrZI5XR6HimdrKIfi3fk+c8UhEAcKozo1aPME/azBfeajnXUq YGIqa1QNUv3fJOBoxmt6Pm/hw8hYPvH7+oyzIcAjDxQEmeAxqoGLzukCJ5HoK44w8eG2 B7Krw9wfgc7xxun3yATUXbM/0CJY3uMD8RcroCmuiUSY3lVIf2KpxT+y2G1pyrkAci/9 1vsw== X-Gm-Message-State: ACgBeo0u7Ljp2Jsx/p3IiQmlRI9kJxs79IpvnzuVeIN5SCCz7ZSTDyrV WePrbXnvFCedNy6DozUaSnUrj6u21gc= X-Google-Smtp-Source: AA6agR6PwsrsR8/9ZXCiy1s0ACurUfUtPE2cp6mij5ZFKV2aMeQplKACEXg302ALCYaT3TABVRt4fA== X-Received: by 2002:a05:6512:230d:b0:48a:f158:623e with SMTP id o13-20020a056512230d00b0048af158623emr5974156lfu.437.1659926641069; Sun, 07 Aug 2022 19:44:01 -0700 (PDT) Received: from pohjola.lan (mobile-user-c1d2e4-79.dhcp.inet.fi. [193.210.228.79]) by smtp.gmail.com with ESMTPSA id v22-20020ac25596000000b0048a77a2c4b2sm1255125lfg.158.2022.08.07.19.44.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Aug 2022 19:44:00 -0700 (PDT) From: atheik To: linux-cifs@vger.kernel.org Cc: atheik Subject: [PATCH 2/3] ksmbd-tools: cleanup config group handling Date: Mon, 8 Aug 2022 05:43:40 +0300 Message-Id: <20220808024341.63913-2-atteh.mailbox@gmail.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220808024341.63913-1-atteh.mailbox@gmail.com> References: <20220808024341.63913-1-atteh.mailbox@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org Rename cp_add_ipc_share() to cp_add_ipc_group() in order to better describe its purpose. Use the ipc_group global variable so as to get rid of the group name comparison in groups_callback(). Keep track of used groups callback mode by saving it per-group. Move global group checks to global_conf_* functions. Signed-off-by: Atte Heikkilä Reviewed-by: Hyunchul Lee --- include/config_parser.h | 5 +++ lib/config_parser.c | 95 +++++++++++++++++++++++------------------ 2 files changed, 59 insertions(+), 41 deletions(-) diff --git a/include/config_parser.h b/include/config_parser.h index b6c49b9..43212c8 100644 --- a/include/config_parser.h +++ b/include/config_parser.h @@ -10,7 +10,12 @@ #include +#define GROUPS_CALLBACK_NONE (0) +#define GROUPS_CALLBACK_INIT (1 << 0) +#define GROUPS_CALLBACK_REINIT (1 << 1) + struct smbconf_group { + unsigned short cb_mode; char *name; GHashTable *kv; }; diff --git a/lib/config_parser.c b/lib/config_parser.c index 5e7a438..d311386 100644 --- a/lib/config_parser.c +++ b/lib/config_parser.c @@ -21,7 +21,7 @@ struct smbconf_global global_conf; struct smbconf_parser parser; -struct smbconf_group *global_group; +struct smbconf_group *global_group, *ipc_group; unsigned long long memparse(const char *v) { @@ -107,6 +107,7 @@ static int add_new_group(char *line) } group = g_malloc(sizeof(struct smbconf_group)); + group->cb_mode = GROUPS_CALLBACK_NONE; group->name = name; group->kv = g_hash_table_new_full(g_str_hash, g_str_equal, @@ -561,6 +562,9 @@ static void global_conf_default(void) static void global_conf_create(void) { + if (!global_group || global_group->cb_mode != GROUPS_CALLBACK_INIT) + return; + /* * This will transfer server options to global_conf, and leave behind * in the global parser group, the options that must be applied to every @@ -569,6 +573,23 @@ static void global_conf_create(void) g_hash_table_foreach_remove(global_group->kv, global_group_kv, NULL); } +static void append_key_value(gpointer _k, gpointer _v, gpointer user_data) +{ + GHashTable *receiver = (GHashTable *) user_data; + + /* Don't override local share options */ + if (!g_hash_table_lookup(receiver, _k)) + g_hash_table_insert(receiver, g_strdup(_k), g_strdup(_v)); +} + +static void global_conf_update(struct smbconf_group *group) +{ + if (!global_group) + return; + + g_hash_table_foreach(global_group->kv, append_key_value, group->kv); +} + static void global_conf_fixup_missing(void) { int ret; @@ -607,39 +628,29 @@ static void global_conf_fixup_missing(void) ret); } -static void append_key_value(gpointer _k, gpointer _v, gpointer user_data) -{ - GHashTable *receiver = (GHashTable *) user_data; - - /* Don't override local share options */ - if (!g_hash_table_lookup(receiver, _k)) - g_hash_table_insert(receiver, g_strdup(_k), g_strdup(_v)); -} - -#define GROUPS_CALLBACK_STARTUP_INIT 0x1 -#define GROUPS_CALLBACK_REINIT 0x2 - static void groups_callback(gpointer _k, gpointer _v, gpointer user_data) { - struct smbconf_group *group = (struct smbconf_group *)_v; + struct smbconf_group *group = (struct smbconf_group *) _v; + unsigned short cb_mode = *(unsigned short *) user_data; - if (group != global_group) { - if (global_group && g_ascii_strcasecmp(_k, "ipc$")) - g_hash_table_foreach(global_group->kv, - append_key_value, - group->kv); + if (group == global_group) + return; - shm_add_new_share(group); - } + group->cb_mode = cb_mode; + + if (group != ipc_group) + global_conf_update(group); + + shm_add_new_share(group); } -static int cp_add_ipc_share(void) +static int cp_add_ipc_group(void) { char *comment = NULL, *guest = NULL; int ret = 0; - if (g_hash_table_lookup(parser.groups, "ipc$")) - return 0; + if (ipc_group) + return ret; comment = g_strdup("comment = IPC share"); guest = g_strdup("guest ok = yes"); @@ -649,13 +660,18 @@ static int cp_add_ipc_share(void) if (ret) { pr_err("Unable to add IPC$ share\n"); ret = -EINVAL; + goto out; } + + ipc_group = g_hash_table_lookup(parser.groups, "ipc$"); +out: g_free(comment); g_free(guest); return ret; } -static int __cp_parse_smbconfig(const char *smbconf, GHFunc cb, long flags) +static int __cp_parse_smbconfig(const char *smbconf, GHFunc cb, + unsigned short cb_mode) { int ret; @@ -665,35 +681,32 @@ static int __cp_parse_smbconfig(const char *smbconf, GHFunc cb, long flags) if (ret) return ret; - ret = cp_add_ipc_share(); - if (!ret) { - global_group = g_hash_table_lookup(parser.groups, "global"); + ret = cp_add_ipc_group(); + if (ret) + goto out; - if (global_group && (flags == GROUPS_CALLBACK_STARTUP_INIT)) - global_conf_create(); + global_group = g_hash_table_lookup(parser.groups, "global"); + if (global_group) + global_group->cb_mode = cb_mode; - g_hash_table_foreach(parser.groups, - groups_callback, - NULL); - - global_conf_fixup_missing(); - } + global_conf_create(); + g_hash_table_foreach(parser.groups, groups_callback, &cb_mode); + global_conf_fixup_missing(); +out: cp_smbconfig_destroy(); return ret; } int cp_parse_reload_smbconf(const char *smbconf) { - return __cp_parse_smbconfig(smbconf, - groups_callback, + return __cp_parse_smbconfig(smbconf, groups_callback, GROUPS_CALLBACK_REINIT); } int cp_parse_smbconf(const char *smbconf) { - return __cp_parse_smbconfig(smbconf, - groups_callback, - GROUPS_CALLBACK_STARTUP_INIT); + return __cp_parse_smbconfig(smbconf, groups_callback, + GROUPS_CALLBACK_INIT); } int cp_parse_pwddb(const char *pwddb)