| Message ID | 20220928024955.3001504-1-luomeng12@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [4.19] Revert "cifs: fix double free race when mount fails in cifs_get_root()" | expand |
diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c index 52b1524b40cd..7dce6d1fa50b 100644 --- a/fs/cifs/cifsfs.c +++ b/fs/cifs/cifsfs.c @@ -779,7 +779,6 @@ cifs_smb3_do_mount(struct file_system_type *fs_type, out_super: deactivate_locked_super(sb); - return root; out: cifs_cleanup_volume_info(volume_info); return root;
This reverts commit 2fe0e281f7ad0a62259649764228227dd6b2561d. Commit 2fe0e281f7ad (cifs: fix double free race when mount fails in cifs_get_root()) fixes a double. However there is no such issue on 4.19 because it will return after cifs_cleanup_volume_info(). Since merge this patch, cifs_cleanup_volume_info() is skipped, leading to a memory leak. Signed-off-by: Luo Meng <luomeng12@huawei.com> --- fs/cifs/cifsfs.c | 1 - 1 file changed, 1 deletion(-)