diff mbox series

[2/5] cifs: get rid of unnecessary ifdef

Message ID 20230329201423.32134-2-pc@manguebit.com (mailing list archive)
State New, archived
Headers show
Series [1/5] cifs: get rid of cifs_mount_ctx::{origin,leaf}_fullpath | expand

Commit Message

Paulo Alcantara March 29, 2023, 8:14 p.m. UTC 
No need to ifdef around TCP_Server_Info::{origin,leaf}_fullpath as
they're declared regardless CONFIG_CIFS_DFS_UPCALL.

Signed-off-by: Paulo Alcantara (SUSE) <pc@manguebit.com>
---
 fs/cifs/connect.c | 2 --
 1 file changed, 2 deletions(-)

Comments

ronnie sahlberg March 29, 2023, 8:25 p.m. UTC | #1 
reviewed-by me

On Thu, 30 Mar 2023 at 06:20, Paulo Alcantara <pc@manguebit.com> wrote:
>
> No need to ifdef around TCP_Server_Info::{origin,leaf}_fullpath as
> they're declared regardless CONFIG_CIFS_DFS_UPCALL.
>
> Signed-off-by: Paulo Alcantara (SUSE) <pc@manguebit.com>
> ---
>  fs/cifs/connect.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
> index ef50f603e640..7c3e090a0f13 100644
> --- a/fs/cifs/connect.c
> +++ b/fs/cifs/connect.c
> @@ -993,10 +993,8 @@ static void clean_demultiplex_info(struct TCP_Server_Info *server)
>                  */
>         }
>
> -#ifdef CONFIG_CIFS_DFS_UPCALL
>         kfree(server->origin_fullpath);
>         kfree(server->leaf_fullpath);
> -#endif
>         kfree(server);
>
>         length = atomic_dec_return(&tcpSesAllocCount);
> --
> 2.40.0
>
diff mbox series

Patch

diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index ef50f603e640..7c3e090a0f13 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -993,10 +993,8 @@  static void clean_demultiplex_info(struct TCP_Server_Info *server)
 		 */
 	}
 
-#ifdef CONFIG_CIFS_DFS_UPCALL
 	kfree(server->origin_fullpath);
 	kfree(server->leaf_fullpath);
-#endif
 	kfree(server);
 
 	length = atomic_dec_return(&tcpSesAllocCount);