diff mbox series

ksmbd: Use struct_size() to improve get_file_alternate_info()

Message ID 20240927143642.2086-2-thorsten.blum@linux.dev (mailing list archive)
State New, archived
Headers show
Series ksmbd: Use struct_size() to improve get_file_alternate_info() | expand

Commit Message

Thorsten Blum Sept. 27, 2024, 2:36 p.m. UTC 
Use struct_size() to calculate the output buffer length.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 fs/smb/server/smb2pdu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Namjae Jeon Sept. 28, 2024, 12:43 a.m. UTC | #1 
On Fri, Sep 27, 2024 at 11:37 PM Thorsten Blum <thorsten.blum@linux.dev> wrote:
>
> Use struct_size() to calculate the output buffer length.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Applied it to #ksmbd-for-next-next.
Thanks.
diff mbox series

Patch

diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c
index 7121266daa02..b45e5b9ad967 100644
--- a/fs/smb/server/smb2pdu.c
+++ b/fs/smb/server/smb2pdu.c
@@ -4887,7 +4887,7 @@  static void get_file_alternate_info(struct ksmbd_work *work,
 	spin_unlock(&dentry->d_lock);
 	file_info->FileNameLength = cpu_to_le32(conv_len);
 	rsp->OutputBufferLength =
-		cpu_to_le32(sizeof(struct smb2_file_alt_name_info) + conv_len);
+		cpu_to_le32(struct_size(file_info, FileName, conv_len));
 }
 
 static int get_file_stream_info(struct ksmbd_work *work,