From patchwork Wed Aug 25 11:58:45 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suresh Jayaraman X-Patchwork-Id: 131551 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.4/8.14.3) with ESMTP id o7PBwqNI031804 for ; Wed, 25 Aug 2010 11:58:52 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753420Ab0HYL6w (ORCPT ); Wed, 25 Aug 2010 07:58:52 -0400 Received: from cantor.suse.de ([195.135.220.2]:32808 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751435Ab0HYL6v (ORCPT ); Wed, 25 Aug 2010 07:58:51 -0400 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.221.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.suse.de (Postfix) with ESMTP id D6DFC94393; Wed, 25 Aug 2010 13:58:50 +0200 (CEST) Message-ID: <4C750575.80109@suse.de> Date: Wed, 25 Aug 2010 17:28:45 +0530 From: Suresh Jayaraman User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.11) Gecko/20100714 SUSE/3.0.6 Thunderbird/3.0.6 MIME-Version: 1.0 To: "Christopher K." Cc: linux-kernel@vger.kernel.org, linux-cifs@vger.kernel.org Subject: Re: Automount causes zero-pointer dereference in 2.6.36-rc2 References: In-Reply-To: Sender: linux-cifs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Wed, 25 Aug 2010 11:58:53 +0000 (UTC) diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index 18af707..ec0ea4a 100644 --- a/fs/cifs/connect.c +++ b/fs/cifs/connect.c @@ -1673,6 +1673,7 @@ cifs_find_smb_ses(struct TCP_Server_Info *server, struct smb_vol *vol) MAX_USERNAME_SIZE)) continue; if (strlen(vol->username) != 0 && + ses->password != NULL && strncmp(ses->password, vol->password ? vol->password : "", MAX_PASSWORD_SIZE))