From patchwork Mon Jan 27 06:07:12 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shirish Pargaonkar X-Patchwork-Id: 3540981 Return-Path: X-Original-To: patchwork-cifs-client@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id D69F79F2E9 for ; Mon, 27 Jan 2014 06:07:31 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 24237200F3 for ; Mon, 27 Jan 2014 06:07:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8A2BD200F2 for ; Mon, 27 Jan 2014 06:07:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750882AbaA0GHO (ORCPT ); Mon, 27 Jan 2014 01:07:14 -0500 Received: from mail-la0-f49.google.com ([209.85.215.49]:62696 "EHLO mail-la0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750846AbaA0GHO (ORCPT ); Mon, 27 Jan 2014 01:07:14 -0500 Received: by mail-la0-f49.google.com with SMTP id y1so4122850lam.36 for ; Sun, 26 Jan 2014 22:07:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=f/Ktfqd3naPwF8vRTs+ABfnBKpjHmW8/pxLo5nvNmD8=; b=RqCIDACseXkmJjgKsjNeZ9gZcwPdxiHOv4JVeFQPOyvFWbX1lMCf3aD+jw0IKOqSP+ kgyNTkDXzyrITV/Qg4VQKbHNioM+eD20ZDX7mxTlXaH9IxNoGEcSHuJQYugn7vJuK9ym PQfuMtQEliZzAp0D6wv8MrGYW6CGTcHxLZv1R4mkk7UQh0+tr0Z51cXePuVMGHu4djpN CyAT2CuJbIFYPCGpVdE8LEbm2CL2rcYjPX3p6ZqhfnkYXMjsm0K+EqXnrOafJqrZVQNO +2I7OAE1bgSI2knGTp7Fr84quWRbuePRsueinmA3VR3uHR/I2Xib6fAj7WiaJ4EG5W/h 9iFQ== MIME-Version: 1.0 X-Received: by 10.152.19.170 with SMTP id g10mr16721716lae.9.1390802832436; Sun, 26 Jan 2014 22:07:12 -0800 (PST) Received: by 10.114.193.163 with HTTP; Sun, 26 Jan 2014 22:07:12 -0800 (PST) In-Reply-To: <52DAB72C.9030305@candelatech.com> References: <52DAB72C.9030305@candelatech.com> Date: Mon, 27 Jan 2014 00:07:12 -0600 Message-ID: Subject: Re: Problem with connecting to SMB server in 3.9.11 kernel. From: Shirish Pargaonkar To: Ben Greear Cc: linux-cifs , "Amit Haval (India Bangalore)" Sender: linux-cifs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Can you try this patch and see if it works? On Sat, Jan 18, 2014 at 11:17 AM, Ben Greear wrote: > Hello! > > A customer reported problems connecting our CIFS traffic generation test > gear to their SMB server. > We are using the 3.9.11+ kernel, and though it is patched, we do not have > any > patches to cifs. > > The OS is Fedora 14, 64-bit. > > A similar system on Fedora 14, with a 3.7.10+ kernel was working, but when > we tried the 3.7.10+ kernel on the broken machine, it also failed to work. > So, it could be the SMB server itself is having issues. (In the 3.7.10+ > failure, > the server just failed to respond after "Setup andX Request AUTH message", > though we > did get the TCP ack so it looks like the message was received by the > server.) > > I'm attaching a capture taken on the SMB server. > > From looking at this page: > > http://msdn.microsoft.com/en-us/library/ff469913.aspx > > It appears the problem (STATUS_UNSUCCESSFUL) is: > > "The size of the extended attribute list is not correct. Check the > EaErrorOffset field for the > address of the SMB_GEA structure at which the error was detected." > > I did not see anything about extended attribute list in the capture, but if > someone else > with more knowledge could take a look and see if they notice any problems I > would be grateful. > > Thanks! > Ben > > -- > Ben Greear > Candela Technologies Inc http://www.candelatech.com > --- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/fs/cifs/sess.c b/fs/cifs/sess.c index e87387d..ac14d71 100644 --- a/fs/cifs/sess.c +++ b/fs/cifs/sess.c @@ -450,9 +450,8 @@ int build_ntlmssp_auth_blob(unsigned char *pbuffer, sec_blob->WorkstationName.MaximumLength = 0; tmp += 2; - if (((ses->ntlmssp->server_flags & NTLMSSP_NEGOTIATE_KEY_XCH) || - (ses->ntlmssp->server_flags & NTLMSSP_NEGOTIATE_EXTENDED_SEC)) - && !calc_seckey(ses)) { + if ((ses->ntlmssp->server_flags & NTLMSSP_NEGOTIATE_KEY_XCH) && + !calc_seckey(ses)) { memcpy(tmp, ses->ntlmssp->ciphertext, CIFS_CPHTXT_SIZE); sec_blob->SessionKey.BufferOffset = cpu_to_le32(tmp - pbuffer); sec_blob->SessionKey.Length = cpu_to_le16(CIFS_CPHTXT_SIZE);