From patchwork Fri Jun 29 03:57:18 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve French X-Patchwork-Id: 10495583 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2B1896016C for ; Fri, 29 Jun 2018 03:57:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 14D0E29BE4 for ; Fri, 29 Jun 2018 03:57:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 08D7129BE8; Fri, 29 Jun 2018 03:57:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_TVD_MIME_EPI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B10AB29BE4 for ; Fri, 29 Jun 2018 03:57:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965491AbeF2D5a (ORCPT ); Thu, 28 Jun 2018 23:57:30 -0400 Received: from mail-pf0-f181.google.com ([209.85.192.181]:40436 "EHLO mail-pf0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964826AbeF2D5a (ORCPT ); Thu, 28 Jun 2018 23:57:30 -0400 Received: by mail-pf0-f181.google.com with SMTP id z24-v6so3573854pfe.7 for ; Thu, 28 Jun 2018 20:57:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=Mt/4za/9LJ//PtHrsDPCqx2DbE6bhcO6QHfw5K6rvd0=; b=d3DDK3nclwd0QBYHKyjP6J/QgaWEgU6DBYibdx+Pacd91+x2T7pS7hHkiU8pOxqVp+ RBW27tRZibjdRaPFAQovaGYhqA6HTqebmjcEhFS8lxfvvnGBacu+Fi1ZP2ViRZkPf4aY 4I3d2kzJMOFNwPaJW8v2FKShkGIpEr6TrxQAl2njupVpbV8Fy+/7juF8S6FPoro8Z42N +SFxSzQYQUq9BrEyvjIga5/2JidGJVu2Gvgxc6tZdDpEsr82/LB5o4t6cOWoarjpxoWz gKZEoapylsVaU9/vrOqsoZClZJOF5NwDXppC5QLCTXzawTL2ROLtV6QjBXGhKc2+715s QRnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=Mt/4za/9LJ//PtHrsDPCqx2DbE6bhcO6QHfw5K6rvd0=; b=ukuSDHoEJQ/9nNuBhQkk3wrypNUoiBmOEWHE+fg0VS6/9IuWkJR0anyfOoVMjsoz3Y 9CeGUAsPXXss9iPQskcYvxTsYpFIpkYYPkEV0FcwPsd+hl6UzuF3od4/JL/6l2iAfzkT P9x7O4Fa31Ib/u5F5nBIC1yFYHZFfpcpB7eJNPludBtuZS9gGb0p9HyLujnAj/zjUgtH Rb0df/VF+ZRo+I0NYnKkrQwwhyQDgpL5ncwQIz8jB63b4LHHnvSeCBKgXGlE4zQc4Itt TU7vlf6Ab3r2bWe5QkqYNFtgzpt6T4EpGRTSPk1FXV3n+gmoCXpbKd2EXKypTuMIPsU1 SQbg== X-Gm-Message-State: APt69E0G+e/vbEFU4SlRABwMKbPUh12S36lO5qrhOncC5kE6txE8Fjr/ /uogQm0FuP18/HL2pE6WsLz1bLoEgfta3ToYdrXoAA== X-Google-Smtp-Source: ADUXVKKmDQb0HIubm6i7M5Ygl8sNv3DVShT5PcbYLWttrIkiBvIP5YYjilhriBpIsTOTecaqv7xE1M3vvrbWJv2/LSk= X-Received: by 2002:a63:b812:: with SMTP id p18-v6mr11412318pge.11.1530244649635; Thu, 28 Jun 2018 20:57:29 -0700 (PDT) MIME-Version: 1.0 From: Steve French Date: Thu, 28 Jun 2018 22:57:18 -0500 Message-ID: Subject: [PATCH][SMB3] remove noisy warning message on mount To: CIFS , =?UTF-8?Q?Aur=C3=A9lien_Aptel?= Sender: linux-cifs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If query interface info returns error not supported (as it does to Samba eg.) don't log a noisy warning on every mount - change to an FYI level so doesn't clutter the logs. Reviewed-by: Aurelien Aptel Acked-by: Sachin Prabhu From 32cb62e7b6a83a4d95d512e25ac870dd84e410bc Mon Sep 17 00:00:00 2001 From: Steve French Date: Thu, 28 Jun 2018 22:53:39 -0500 Subject: [PATCH] smb3: remove noisy warning message on mount Some servers, like Samba, don't support the fsctl for query_network_interface_info so don't log a noisy warning message on mount for this by default unless the error is more serious. Lower the error to an FYI level so it does not get logged by default. Signed-off-by: Steve French --- fs/cifs/smb2ops.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c index f80cc376b18e..66d7de1370ce 100644 --- a/fs/cifs/smb2ops.c +++ b/fs/cifs/smb2ops.c @@ -444,7 +444,11 @@ SMB3_request_interfaces(const unsigned int xid, struct cifs_tcon *tcon) FSCTL_QUERY_NETWORK_INTERFACE_INFO, true /* is_fsctl */, NULL /* no data input */, 0 /* no data input */, (char **)&out_buf, &ret_data_len); - if (rc != 0) { + if (rc == -EOPNOTSUPP) { + cifs_dbg(FYI, + "server does not support query network interfaces\n"); + goto out; + } else if (rc != 0) { cifs_dbg(VFS, "error %d on ioctl to get interface list\n", rc); goto out; } -- 2.17.1