From patchwork Mon Feb 25 21:09:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve French X-Patchwork-Id: 10829163 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 55DFD922 for ; Mon, 25 Feb 2019 21:09:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 41E5B2AD97 for ; Mon, 25 Feb 2019 21:09:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3554E2AE52; Mon, 25 Feb 2019 21:09:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 270742AD97 for ; Mon, 25 Feb 2019 21:09:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727113AbfBYVJg (ORCPT ); Mon, 25 Feb 2019 16:09:36 -0500 Received: from mail-pf1-f180.google.com ([209.85.210.180]:41160 "EHLO mail-pf1-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726602AbfBYVJg (ORCPT ); Mon, 25 Feb 2019 16:09:36 -0500 Received: by mail-pf1-f180.google.com with SMTP id d25so5064859pfn.8 for ; Mon, 25 Feb 2019 13:09:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=hlIY92BUHVul7uCzgI0/Fxjoy+j12yglFMemkjgc5E8=; b=UfV6AiYLSDkPhg1NNfiDY9BmRais3pjC2qViGEbFz+8KT367BdeCi40zqHAE/YNKCG 0H4q4ZNHmiA57/Z+HpTeLXh4TX9qpn9NR16bLi9zBnOcfIqBvrejNAf2YUEVvLWsGCXP 4RkBoO8YriKg16IPzaPItWsfb/Q/A2AYmGJjKRj3+4vf6WbAD6yYO/HwupnHAtXN5n+w qKIkmlBCx49pimsCBAQ3HJgwUHDcylzRSLY7kW38wCciXtCle8S8nBi7kNwehOe3mP5e 7XQY3CSY3pjkn0IiAvVifLy7DlMcPbzuynxNG3Doa6iSiPPBi0nE0bKbNwylxV+Yrrpv XjVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=hlIY92BUHVul7uCzgI0/Fxjoy+j12yglFMemkjgc5E8=; b=IbF1oYIY3IFMgxtteBZl+2WaLKMKB1ZSBKZIZxSi0pQAZNDdy7KjXuros2QXgaNvie zeKKHZHAg6VF80HDrENmv53B3jqGWqoYNQ335H0Ziet4jd8OTJSQXkqc/DYzhQQXMHT3 WOwj8gl+7xTJgBQ+1mIxiUatuYvGetSn82xEXgyod9iGb5q2vXAycJiTgrWCWq2gvexj CNOa0eHTuvay4Grc2KCXfTs/calyQ9+afhis/tlOWlEl1IP+3IPz3xcbnda72+Qnszuw aDasOV/xplrjVwKt1oKIKfWRpaKxzZfQFYBiwWzVvmz/9s+1OvdlS1kBtrA640Ir2Ier THLA== X-Gm-Message-State: AHQUAuaIZLW8jqLHBKQOeqQKpr0Lrcf2bRBH3YnLUG4FS0Im3LYWXQjZ 2ewCiSEW27jtaB3q8H0tT3ptc5N8gefKXeHcX7RP4A== X-Google-Smtp-Source: AHgI3IZ5IvD0lMICjmriGTSsTurWFqi4acmVRwWpu0gt/2XTVdiTYqH2xiskVGPNB1F3DwjbpFwuGVkgIfw6HtZXW2g= X-Received: by 2002:a65:508b:: with SMTP id r11mr1036417pgp.242.1551128975377; Mon, 25 Feb 2019 13:09:35 -0800 (PST) MIME-Version: 1.0 From: Steve French Date: Mon, 25 Feb 2019 15:09:23 -0600 Message-ID: Subject: [PATCH] Missing read completion trace point To: CIFS Sender: linux-cifs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP We were missing one path in dynamic traces of smb3 reads (when ENODATA returned) From 9747f639bd4446f98d1dd05de53ac76e5569d707 Mon Sep 17 00:00:00 2001 From: Steve French Date: Mon, 25 Feb 2019 15:02:58 -0600 Subject: [PATCH] smb3: add missing read completion trace point When ENODATA returned we weren't logging the read completion (not an error, but can be indicated by logging length 0) which makes looking at read traces confusing for smb3. Signed-off-by: Steve French --- fs/cifs/smb2pdu.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c index ec9abe293279..c68207b46d98 100644 --- a/fs/cifs/smb2pdu.c +++ b/fs/cifs/smb2pdu.c @@ -3404,7 +3404,10 @@ SMB2_read(const unsigned int xid, struct cifs_io_parms *io_parms, io_parms->tcon->tid, ses->Suid, io_parms->offset, io_parms->length, rc); - } + } else + trace_smb3_read_done(xid, req->PersistentFileId, + io_parms->tcon->tid, ses->Suid, + io_parms->offset, 0); free_rsp_buf(resp_buftype, rsp_iov.iov_base); return rc == -ENODATA ? 0 : rc; } else -- 2.17.1