diff mbox series

Two more CIFS patches pointed out by Dan Carpenter using smatch

Message ID CAH2r5mt6whs+-2LKYCZ_jHpFY27mK84gAJZqqOLCx4ReB62fEw@mail.gmail.com (mailing list archive)
State New, archived
Headers show
Series Two more CIFS patches pointed out by Dan Carpenter using smatch | expand

Commit Message

Steve French Sept. 24, 2021, 1:29 a.m. UTC 
Marked one of them for stable.  Both small and seem like low risk fixes.

See attached.

Comments

Ronnie Sahlberg Sept. 24, 2021, 1:34 a.m. UTC | #1 
They both look good to me.
Acked by me.

On Fri, Sep 24, 2021 at 11:30 AM Steve French <smfrench@gmail.com> wrote:
>
> Marked one of them for stable.  Both small and seem like low risk fixes.
>
> See attached.
>
> --
> Thanks,
>
> Steve
diff mbox series

Patch

From 56134a0432710af1ec48e4bd1ced5ecd11260cb4 Mon Sep 17 00:00:00 2001
From: Steve French <stfrench@microsoft.com>
Date: Thu, 23 Sep 2021 19:18:37 -0500
Subject: [PATCH 2/2] cifs: fix incorrect check for null pointer in
 header_assemble

Although very unlikely that the tlink pointer would be null in this case,
get_next_mid function can in theory return null (but not an error)
so need to check for null (not for IS_ERR, which can not be returned
here).

Address warning:

        fs/smbfs_client/connect.c:2392 cifs_match_super()
        warn: 'tlink' isn't an ERR_PTR

Pointed out by Dan Carpenter via smatch code analysis tool

CC: stable@vger.kernel.org
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
---
 fs/cifs/connect.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index 7881115cfbee..c3b94c1e4591 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -2389,9 +2389,10 @@  cifs_match_super(struct super_block *sb, void *data)
 	spin_lock(&cifs_tcp_ses_lock);
 	cifs_sb = CIFS_SB(sb);
 	tlink = cifs_get_tlink(cifs_sb_master_tlink(cifs_sb));
-	if (IS_ERR(tlink)) {
+	if (tlink == NULL) {
+		/* can not match superblock if tlink were ever null */
 		spin_unlock(&cifs_tcp_ses_lock);
-		return rc;
+		return 0;
 	}
 	tcon = tlink_tcon(tlink);
 	ses = tcon->ses;
-- 
2.30.2