diff mbox series

[SMB3,PATCHES] two patches for minor coverity warnings

Message ID CAH2r5mtJhnTEjv4dHN6Nf+oa1+k+W4hCMk_how3LdH+6BhMmcA@mail.gmail.com (mailing list archive)
State New, archived
Headers show
Series [SMB3,PATCHES] two patches for minor coverity warnings | expand

Commit Message

Steve French May 24, 2022, 2 a.m. UTC 
Fixes for two minor Coverity warnings

Comments

ronnie sahlberg May 24, 2022, 2:01 a.m. UTC | #1 
Acked-by me for both

On Tue, 24 May 2022 at 12:00, Steve French <smfrench@gmail.com> wrote:
>
> Fixes for two minor Coverity warnings
>
> --
> Thanks,
>
> Steve
diff mbox series

Patch

From bbdf6cf56c88845fb0b713cbf5c6623c53fe40d8 Mon Sep 17 00:00:00 2001
From: Steve French <stfrench@microsoft.com>
Date: Mon, 23 May 2022 20:42:03 -0500
Subject: [PATCH 1/2] smb3: check for null tcon

Although unlikely to be null, it is confusing to use a pointer
before checking for it to be null so move the use down after
null check.

Addresses-Coverity: 1517586 ("Null pointer dereferences  (REVERSE_INULL)")
Reviewed-by: Ronnie Sahlberg <lsahlber@redhat.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
---
 fs/cifs/smb2ops.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c
index cbe56ed35694..0d7feb9e609e 100644
--- a/fs/cifs/smb2ops.c
+++ b/fs/cifs/smb2ops.c
@@ -760,8 +760,8 @@  int open_cached_dir(unsigned int xid, struct cifs_tcon *tcon,
 		struct cifs_sb_info *cifs_sb,
 		struct cached_fid **cfid)
 {
-	struct cifs_ses *ses = tcon->ses;
-	struct TCP_Server_Info *server = ses->server;
+	struct cifs_ses *ses;
+	struct TCP_Server_Info *server;
 	struct cifs_open_parms oparms;
 	struct smb2_create_rsp *o_rsp = NULL;
 	struct smb2_query_info_rsp *qi_rsp = NULL;
@@ -780,6 +780,9 @@  int open_cached_dir(unsigned int xid, struct cifs_tcon *tcon,
 	    is_smb1_server(tcon->ses->server))
 		return -ENOTSUPP;
 
+	ses = tcon->ses;
+	server = ses->server;
+
 	if (cifs_sb->root == NULL)
 		return -ENOENT;
 
-- 
2.34.1