From patchwork Tue Mar 31 03:10:02 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve French X-Patchwork-Id: 6127251 Return-Path: X-Original-To: patchwork-cifs-client@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 7834ABF4A6 for ; Tue, 31 Mar 2015 03:10:30 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9BADC20222 for ; Tue, 31 Mar 2015 03:10:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DF69220456 for ; Tue, 31 Mar 2015 03:10:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753994AbbCaDKY (ORCPT ); Mon, 30 Mar 2015 23:10:24 -0400 Received: from mail-qc0-f179.google.com ([209.85.216.179]:33433 "EHLO mail-qc0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754204AbbCaDKX (ORCPT ); Mon, 30 Mar 2015 23:10:23 -0400 Received: by qcbjx9 with SMTP id jx9so3958091qcb.0 for ; Mon, 30 Mar 2015 20:10:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to:cc:content-type; bh=tZI9Fb9mthMzdJFA0XOwu82rIZpYs5M+kr3h6qpyTL8=; b=vrBmOSs3KBPtzkLFMq1rcka9SiiuGbN7cZiz44F5XyTkzD3t6H0wgW53sg41/paQOU UV1IB1oCHd5IucRotkvp2pn16zP2c1I64uz8l/IkI3MOVOo/vHfpULTmOkY4+MwgefRg Gya7mULZNIYdbUXgabA31mV8YLGfi2HRBIfpTjFw66Y30YjQ0dv0MkJsZxEINI1bt/nM caygvNTIKssgApSgCt6wBMnmkl9DBmT/AqemtrhuJ641RMs9up85iCaev1IoRakN+icu Klf97KmjcmA2NeylrvFOjFtQvTFjH38sVzN8qDCmQa0ueloBDtLTXTXxVJxrbyhHFYqJ OlNg== X-Received: by 10.140.202.144 with SMTP id x138mr46928207qha.14.1427771422256; Mon, 30 Mar 2015 20:10:22 -0700 (PDT) MIME-Version: 1.0 Received: by 10.140.84.81 with HTTP; Mon, 30 Mar 2015 20:10:02 -0700 (PDT) From: Steve French Date: Mon, 30 Mar 2015 22:10:02 -0500 Message-ID: Subject: [PATCH] [CIFS] Fix warning To: "linux-cifs@vger.kernel.org" Cc: Jeff Layton Sender: linux-cifs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Coverity reports a warning due to uninitialized attr structure in one code path. Reported by Coverity (CID 728535) Signed-off-by: Steve French Reviewed-by: Jeff Layton --- fs/cifs/inode.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c index 2d4f372..3e126d7 100644 --- a/fs/cifs/inode.c +++ b/fs/cifs/inode.c @@ -771,6 +771,8 @@ cifs_get_inode_info(struct inode **inode, const char *full_path, cifs_buf_release(srchinf->ntwrk_buf_start); } kfree(srchinf); + if (rc) + goto cgii_exit; } else goto cgii_exit;