[5.10.y-cip,0/4] Renesas SDHI/DMA/thermal driver fixes and improvements

Message

Lad Prabhakar Aug. 15, 2022, 4:37 p.m. UTC

Hi All,

This patch series backports SDHI/DMA/thermal driver fixes and
improvements.

Note: All the patches have been cherry picked from 6.0-rc1 kernel.

Cheers,
Prabhakar

Biju Das (2):
  thermal/drivers/rzg2l: Fix comments
  dmaengine: sh: rz-dmac: Add device_synchronize callback

Lad Prabhakar (2):
  mmc: renesas_sdhi: Get the reset handle early in the probe
  mmc: renesas_sdhi: Fix typo's

 drivers/dma/sh/rz-dmac.c                      | 17 +++++++++++++++++
 drivers/mmc/host/renesas_sdhi_core.c          |  8 ++++----
 drivers/mmc/host/renesas_sdhi_internal_dmac.c |  4 ++--
 drivers/thermal/rzg2l_thermal.c               | 18 +++++++++++-------
 4 files changed, 34 insertions(+), 13 deletions(-)

Comments

Pavel Machek Aug. 16, 2022, 11:44 a.m. UTC | #1

Hi!

> This patch series backports SDHI/DMA/thermal driver fixes and
> improvements.
> 
> Note: All the patches have been cherry picked from 6.0-rc1 kernel.

Series looks okay to me. I wonder if we have code using
rz_dmac_device_synchronize from 4/4 in the tree?

I can apply the patches if they pass testing and if there are no other
comments.

Best regards,
								Pavel

Lad Prabhakar Aug. 16, 2022, 11:51 a.m. UTC | #2

Hi Pavel,

Thank you for the review.

> -----Original Message-----
> From: Pavel Machek <[e-mail]>
> Sent: 16 August 2022 12:44
> To: Prabhakar Mahadev Lad <[e-mail]>
> Cc: [e-mail]; Nobuhiro Iwamatsu <[e-mail]>; Pavel Machek
> <[e-mail]>; Biju Das <[e-mail]>
> Subject: Re: [PATCH 5.10.y-cip 0/4] Renesas SDHI/DMA/thermal driver fixes and improvements
> 
> Hi!
> 
> > This patch series backports SDHI/DMA/thermal driver fixes and
> > improvements.
> >
> > Note: All the patches have been cherry picked from 6.0-rc1 kernel.
> 
> Series looks okay to me. I wonder if we have code using rz_dmac_device_synchronize from 4/4 in the
> tree?
> 
RSPI uses rz_dmac_device_synchronize from 4/4, I am waiting on the patch to be available in -rc release. I have tested it locally hence posted it  earlier.

> I can apply the patches if they pass testing and if there are no other comments.
> 
Thanks.

Cheers,
Prabhakar

> Best regards,
> 								Pavel
> --
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Nobuhiro Iwamatsu Aug. 17, 2022, 7:27 a.m. UTC | #3

Hi all,

> -----Original Message-----
> From: Prabhakar Mahadev Lad <[e-mail]>
> Sent: Tuesday, August 16, 2022 8:51 PM
> To: Pavel Machek <[e-mail]>
> Cc: [e-mail]; iwamatsu nobuhiro(岩松 信洋 □ＳＷＣ◯Ａ
> ＣＴ) <[e-mail]>; Biju Das
> <[e-mail]>
> Subject: RE: [PATCH 5.10.y-cip 0/4] Renesas SDHI/DMA/thermal driver fixes
> and improvements
> 
> Hi Pavel,
> 
> Thank you for the review.
> 
> > -----Original Message-----
> > From: Pavel Machek <[e-mail]>
> > Sent: 16 August 2022 12:44
> > To: Prabhakar Mahadev Lad <[e-mail]>
> > Cc: [e-mail]; Nobuhiro Iwamatsu
> > <[e-mail]>; Pavel Machek <[e-mail]>;
> Biju
> > Das <[e-mail]>
> > Subject: Re: [PATCH 5.10.y-cip 0/4] Renesas SDHI/DMA/thermal driver
> > fixes and improvements
> >
> > Hi!
> >
> > > This patch series backports SDHI/DMA/thermal driver fixes and
> > > improvements.
> > >
> > > Note: All the patches have been cherry picked from 6.0-rc1 kernel.
> >
> > Series looks okay to me. I wonder if we have code using
> > rz_dmac_device_synchronize from 4/4 in the tree?
> >
> RSPI uses rz_dmac_device_synchronize from 4/4, I am waiting on the patch to
> be available in -rc release. I have tested it locally hence posted it  earlier.
> 
> > I can apply the patches if they pass testing and if there are no other
> comments.
> >
> Thanks.

I also reviewed this patch series, looks good to me.
I applied to linux-5.10.y-cip tree.

Best regards,
  Nobuhiro