mbox series

[5.10.y-cip,0/3] RZ/V2M I2C driver improvements

Message ID 20230630155118.584293-1-biju.das.jz@bp.renesas.com (mailing list archive)
Headers show
Series RZ/V2M I2C driver improvements | expand

Message

Biju Das June 30, 2023, 3:51 p.m. UTC 
This patch series aims to improve RZ/V2M I2C driver, based on the feedback
from Pavel.

All these patches are cherry-picked from the mainline.

Biju Das (3):
  i2c: rzv2m: Drop extra space
  i2c: rzv2m: Replace lowercase macros with static inline functions
  i2c: rzv2m: Disable the operation of unit in case of error

 drivers/i2c/busses/Kconfig     |  2 +-
 drivers/i2c/busses/i2c-rzv2m.c | 43 +++++++++++++++++++++++-----------
 2 files changed, 30 insertions(+), 15 deletions(-)

Comments

Nobuhiro Iwamatsu July 4, 2023, 4:32 a.m. UTC | #1 
Hi Diju,

> -----Original Message-----
> From: Biju Das <biju.das.jz@bp.renesas.com>
> Sent: Saturday, July 1, 2023 12:51 AM
> To: cip-dev@lists.cip-project.org; iwamatsu nobuhiro(岩松 信洋 ○ＤＩＴＣ□
> ＤＩＴ○ＯＳＴ) <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek
> <pavel@denx.de>
> Cc: Biju Das <biju.das.jz@bp.renesas.com>; Fabrizio Castro
> <fabrizio.castro.jz@renesas.com>
> Subject: [PATCH 5.10.y-cip 0/3] RZ/V2M I2C driver improvements
> 
> This patch series aims to improve RZ/V2M I2C driver, based on the feedback
> from Pavel.
> 
> All these patches are cherry-picked from the mainline.
> 
> Biju Das (3):
>   i2c: rzv2m: Drop extra space
>   i2c: rzv2m: Replace lowercase macros with static inline functions
>   i2c: rzv2m: Disable the operation of unit in case of error
> 
>  drivers/i2c/busses/Kconfig     |  2 +-
>  drivers/i2c/busses/i2c-rzv2m.c | 43
> +++++++++++++++++++++++-----------
>  2 files changed, 30 insertions(+), 15 deletions(-)
> 
> --
> 2.25.1

I reviewed this series. Looks fine to me.
I can apply, if there are no other comments and issues.

Test: https://gitlab.com/cip-project/cip-kernel/linux-cip/-/pipelines/919943145
Reviewed-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>

Best regards,
  Nobuhiro
Pavel Machek July 4, 2023, 8:07 p.m. UTC | #2 
Hi!

> > This patch series aims to improve RZ/V2M I2C driver, based on the feedback
> > from Pavel.

> I reviewed this series. Looks fine to me.
> I can apply, if there are no other comments and issues.
> 
> Test: https://gitlab.com/cip-project/cip-kernel/linux-cip/-/pipelines/919943145
> Reviewed-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>

Looks good to me, too.

Reviewed-by: Pavel Machek <pavel@denx.de>

Thank you,
								Pavel
Nobuhiro Iwamatsu July 6, 2023, 12:07 a.m. UTC | #3 
H all,

> -----Original Message-----
> From: Pavel Machek <pavel@denx.de>
> Sent: Wednesday, July 5, 2023 5:07 AM
> To: iwamatsu nobuhiro(岩松 信洋 ○ＤＩＴＣ□ＤＩＴ○ＯＳＴ)
> <nobuhiro1.iwamatsu@toshiba.co.jp>
> Cc: biju.das.jz@bp.renesas.com; cip-dev@lists.cip-project.org;
> pavel@denx.de; fabrizio.castro.jz@renesas.com
> Subject: Re: [PATCH 5.10.y-cip 0/3] RZ/V2M I2C driver improvements
> 
> Hi!
> 
> > > This patch series aims to improve RZ/V2M I2C driver, based on the
> > > feedback from Pavel.
> 
> > I reviewed this series. Looks fine to me.
> > I can apply, if there are no other comments and issues.
> >
> > Test:
> > https://gitlab.com/cip-project/cip-kernel/linux-cip/-/pipelines/919943
> > 145
> > Reviewed-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
> 
> Looks good to me, too.
> 
> Reviewed-by: Pavel Machek <pavel@denx.de>

Thanks, applied.

Best regards,
  Nobuhiro