[6.1.y-cip,0/3] RZ/V2M I2C driver improvements

Message

Biju Das June 30, 2023, 3:53 p.m. UTC

This patch series aims to improve RZ/V2M I2C driver, based on the feedback
from Pavel.

All these patches are cherry-picked from the mainline.

Biju Das (3):
  i2c: rzv2m: Drop extra space
  i2c: rzv2m: Replace lowercase macros with static inline functions
  i2c: rzv2m: Disable the operation of unit in case of error

 drivers/i2c/busses/Kconfig     |  2 +-
 drivers/i2c/busses/i2c-rzv2m.c | 43 +++++++++++++++++++++++-----------
 2 files changed, 30 insertions(+), 15 deletions(-)

Comments

Nobuhiro Iwamatsu July 4, 2023, 5:30 a.m. UTC | #1

Hi Biju,

> -----Original Message-----
> From: Biju Das <[e-mail]>
> Sent: Saturday, July 1, 2023 12:54 AM
> To: [e-mail]; iwamatsu nobuhiro(岩松 信洋 ○ＤＩＴＣ□
> ＤＩＴ○ＯＳＴ) <[e-mail]>; Pavel Machek
> <[e-mail]>
> Cc: Biju Das <[e-mail]>; Fabrizio Castro
> <[e-mail]>
> Subject: [PATCH 6.1.y-cip 0/3] RZ/V2M I2C driver improvements
> 
> This patch series aims to improve RZ/V2M I2C driver, based on the feedback
> from Pavel.
> 
> All these patches are cherry-picked from the mainline.
> 
> Biju Das (3):
>   i2c: rzv2m: Drop extra space
>   i2c: rzv2m: Replace lowercase macros with static inline functions
>   i2c: rzv2m: Disable the operation of unit in case of error
> 

I reviewed this series. Looks fine to me.
I can apply, if there are no comments and issues.

Test: https://gitlab.com/cip-project/cip-kernel/linux-cip/-/pipelines/919964303
Reviewed-by: Nobuhiro Iwamatsu <[e-mail]>

Best regards,
  Nobuhiro

Pavel Machek July 4, 2023, 8:09 p.m. UTC | #2

Hi!

> > This patch series aims to improve RZ/V2M I2C driver, based on the feedback
> > from Pavel.
> > 
> > All these patches are cherry-picked from the mainline.
> > 
> > Biju Das (3):
> >   i2c: rzv2m: Drop extra space
> >   i2c: rzv2m: Replace lowercase macros with static inline functions
> >   i2c: rzv2m: Disable the operation of unit in case of error
> > 
> 
> I reviewed this series. Looks fine to me.
> I can apply, if there are no comments and issues.
> 
> Test: https://gitlab.com/cip-project/cip-kernel/linux-cip/-/pipelines/919964303
> Reviewed-by: Nobuhiro Iwamatsu <[e-mail]>

Looks good to me.

Reviewed-by: Pavel Machek <[e-mail]>

It also looks identical (or very very similar) to 5.10 series. In such
case, I believe you can just do [PATCH 5.10, 6.1] and we'll apply it
to both branches. (It will likely be a bit easier for us, too).

Best regards,
								Pavel

Nobuhiro Iwamatsu July 6, 2023, 12:18 a.m. UTC | #3

Hi all,

> -----Original Message-----
> From: [e-mail] <[e-mail]> On
> Behalf Of Pavel Machek
> Sent: Wednesday, July 5, 2023 5:09 AM
> To: iwamatsu nobuhiro(岩松 信洋 ○ＤＩＴＣ□ＤＩＴ○ＯＳＴ)
> <[e-mail]>
> Cc: [e-mail]; [e-mail];
> [e-mail]; [e-mail]
> Subject: Re: [cip-dev] [PATCH 6.1.y-cip 0/3] RZ/V2M I2C driver improvements
> 
> Hi!
> 
> > > This patch series aims to improve RZ/V2M I2C driver, based on the
> > > feedback from Pavel.
> > >
> > > All these patches are cherry-picked from the mainline.
> > >
> > > Biju Das (3):
> > >   i2c: rzv2m: Drop extra space
> > >   i2c: rzv2m: Replace lowercase macros with static inline functions
> > >   i2c: rzv2m: Disable the operation of unit in case of error
> > >
> >
> > I reviewed this series. Looks fine to me.
> > I can apply, if there are no comments and issues.
> >
> > Test:
> > https://gitlab.com/cip-project/cip-kernel/linux-cip/-/pipelines/919964
> > 303
> > Reviewed-by: Nobuhiro Iwamatsu <[e-mail]>
> 
> Looks good to me.
> 
> Reviewed-by: Pavel Machek <[e-mail]>
> 

Thanks, applied.

> It also looks identical (or very very similar) to 5.10 series. In such case, I believe
> you can just do [PATCH 5.10, 6.1] and we'll apply it to both branches. (It will
> likely be a bit easier for us, too).
> 

I think so too. The same method is used when I submit patches in LTS.

Best regards,
  Nobuhiro