[0/1] clk: Fix for restructuring for no reparent case

Message

Kazuhiro Hayashi Jan. 31, 2024, 1:56 p.m. UTC

With v6.1.72-cip13 + Zynq UltraScale+ MPSoC ZCU102, we observed that
Ethernet does not work when it's speed is 100Mbps.
This issue happens after d94c14f6fa34f2b8b33e5957f5b8dfb5aaf56b1e is
backported to the clk framework, which is not a part of linux-6.1.y
and probably is one of the dependencies of versa3 clk generator support
for Renesas SoCs. See the patch series "Add versa3 clk generator support".

In mainline, a fix for the backport commit above is provided:
be8fa5fd0a48fd2decc4de81ffe72bb3ceacecd9.
This should be applied to linux-6.1.y-cip as well.
With v6.1.72-cip13 + this patch, we confirmed the ZCU102 Ethernet
works at 100Mbps.

Marek Szyprowski (1):
  clk: Fix best_parent_rate after moving code into a separate function

 drivers/clk/clk.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Pavel Machek Jan. 31, 2024, 11:12 a.m. UTC | #1

Hi!

> With v6.1.72-cip13 + Zynq UltraScale+ MPSoC ZCU102, we observed that
> Ethernet does not work when it's speed is 100Mbps.
> This issue happens after d94c14f6fa34f2b8b33e5957f5b8dfb5aaf56b1e is
> backported to the clk framework, which is not a part of linux-6.1.y
> and probably is one of the dependencies of versa3 clk generator support
> for Renesas SoCs. See the patch series "Add versa3 clk generator support".
> 
> In mainline, a fix for the backport commit above is provided:
> be8fa5fd0a48fd2decc4de81ffe72bb3ceacecd9.
> This should be applied to linux-6.1.y-cip as well.
> With v6.1.72-cip13 + this patch, we confirmed the ZCU102 Ethernet
> works at 100Mbps.

Thanks a lot for investigation and sorry for the trouble.

The fix is simple enough, I am currently running tests, and can take
it if they pass and there are no other comments.

Best regards,
								Pavel

Nobuhiro Iwamatsu Feb. 1, 2024, 4:12 a.m. UTC | #2

Hi,

> -----Original Message-----
> From: Pavel Machek <[e-mail]>
> Sent: Wednesday, January 31, 2024 8:13 PM
> To: hayashi kazuhiro(林 和宏 ＤＭＥ ○ＤＩＧ□ＭＰＳ○ＭＰ４)
> <[e-mail]>
> Cc: [e-mail]; iwamatsu nobuhiro(岩松 信洋 ○ＤＩＴＣ□
> ＤＩＴ○ＯＳＴ) <[e-mail]>; [e-mail];
> [e-mail]; saito yuki(齊藤 優貴 ＤＭＥ ○ＤＩＧ□ＥＡＳ○
> ＥＡ３) <[e-mail]>
> Subject: Re: [PATCH 0/1] clk: Fix for restructuring for no reparent case
> 
> Hi!
> 
> > With v6.1.72-cip13 + Zynq UltraScale+ MPSoC ZCU102, we observed that
> > Ethernet does not work when it's speed is 100Mbps.
> > This issue happens after d94c14f6fa34f2b8b33e5957f5b8dfb5aaf56b1e is
> > backported to the clk framework, which is not a part of linux-6.1.y
> > and probably is one of the dependencies of versa3 clk generator
> > support for Renesas SoCs. See the patch series "Add versa3 clk generator
> support".
> >
> > In mainline, a fix for the backport commit above is provided:
> > be8fa5fd0a48fd2decc4de81ffe72bb3ceacecd9.
> > This should be applied to linux-6.1.y-cip as well.
> > With v6.1.72-cip13 + this patch, we confirmed the ZCU102 Ethernet
> > works at 100Mbps.
> 
> Thanks a lot for investigation and sorry for the trouble.
> 
> The fix is simple enough, I am currently running tests, and can take it if they
> pass and there are no other comments.
> 

I do not have an objection.
Reviewed-by: Nobuhiro Iwamatsu <[e-mail]>

Best regards,
  Nobuhiro

Pavel Machek Feb. 1, 2024, 9:50 a.m. UTC | #3

Hi!

> > > In mainline, a fix for the backport commit above is provided:
> > > be8fa5fd0a48fd2decc4de81ffe72bb3ceacecd9.
> > > This should be applied to linux-6.1.y-cip as well.
> > > With v6.1.72-cip13 + this patch, we confirmed the ZCU102 Ethernet
> > > works at 100Mbps.
> > 
> > Thanks a lot for investigation and sorry for the trouble.
> > 
> > The fix is simple enough, I am currently running tests, and can take it if they
> > pass and there are no other comments.
> 
> I do not have an objection.
> Reviewed-by: Nobuhiro Iwamatsu <[e-mail]>

Thanks for the review, I applied the patch.

Best regards,
								Pavel