| Message ID | 1570689915-14149-3-git-send-email-biju.das@bp.renesas.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Chris Paterson |
| Headers | show |
| Series | Add WLAN/BT support | expand |
Hi! > commit d112c20925443b4a8876b101e5b7b13ef105057e upstream. > > This patch enables BT support for the HiHope RZ/G2[MN] boards. > +++ b/arch/arm64/boot/dts/renesas/hihope-common.dtsi > @@ -31,6 +32,13 @@ > leds { > compatible = "gpio-leds"; > > + bt_active_led { > + label = "blue:bt"; It would be good to change this to "blue:bluetooth", for consistency with include/dt-bindings/leds/common.h . It will change names in the sysfs. Best regards, Pavel
Hi Pavel, Thanks for the feedback. > -----Original Message----- > From: Pavel Machek <pavel@denx.de> > Sent: Thursday, October 10, 2019 8:38 AM > To: Biju Das <biju.das@bp.renesas.com> > Cc: cip-dev@lists.cip-project.org; Nobuhiro Iwamatsu > <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek <pavel@denx.de>; > Chris Paterson <Chris.Paterson2@renesas.com>; Fabrizio Castro > <fabrizio.castro@bp.renesas.com> > Subject: Re: [PATCH 4.19.y-cip 2/3] arm64: dts: renesas: hihope-common: > Add BT support > > Hi! > > > commit d112c20925443b4a8876b101e5b7b13ef105057e upstream. > > > > This patch enables BT support for the HiHope RZ/G2[MN] boards. > > > +++ b/arch/arm64/boot/dts/renesas/hihope-common.dtsi > > @@ -31,6 +32,13 @@ > > leds { > > compatible = "gpio-leds"; > > > > + bt_active_led { > > + label = "blue:bt"; As you mentioned, I agree we should fix this in mainline first and then backported to cip. Cherrs, Biju > It would be good to change this to "blue:bluetooth", for consistency with > include/dt-bindings/leds/common.h . It will change names in the sysfs. > > Best regards, > Pavel > -- > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Hi Pavel, Thanks for feedback. > Subject: Re: [PATCH 4.19.y-cip 2/3] arm64: dts: renesas: hihope-common: > Add BT support > > Hi! > > > commit d112c20925443b4a8876b101e5b7b13ef105057e upstream. > > > > This patch enables BT support for the HiHope RZ/G2[MN] boards. > > > +++ b/arch/arm64/boot/dts/renesas/hihope-common.dtsi > > @@ -31,6 +32,13 @@ > > leds { > > compatible = "gpio-leds"; > > > > + bt_active_led { > > + label = "blue:bt"; > > It would be good to change this to "blue:bluetooth", for consistency with > include/dt-bindings/leds/common.h . It will change names in the sysfs. Can you please me point to the right file? There is nothing related to "blue:bluetooth", Mentioned in include/dt-bindings/leds/common.h Cheers, Biju
diff --git a/arch/arm64/boot/dts/renesas/hihope-common.dtsi b/arch/arm64/boot/dts/renesas/hihope-common.dtsi index a13cb88..76f7a9a 100644 --- a/arch/arm64/boot/dts/renesas/hihope-common.dtsi +++ b/arch/arm64/boot/dts/renesas/hihope-common.dtsi @@ -10,6 +10,7 @@ / { aliases { serial0 = &scif2; + serial1 = &hscif0; }; chosen { @@ -31,6 +32,13 @@ leds { compatible = "gpio-leds"; + bt_active_led { + label = "blue:bt"; + gpios = <&gpio7 0 GPIO_ACTIVE_HIGH>; + linux,default-trigger = "hci0-power"; + default-state = "off"; + }; + led0 { gpios = <&gpio6 11 GPIO_ACTIVE_HIGH>; }; @@ -153,6 +161,19 @@ }; }; +&hscif0 { + pinctrl-0 = <&hscif0_pins>; + pinctrl-names = "default"; + + uart-has-rtscts; + status = "okay"; + + bluetooth { + compatible = "ti,wl1837-st"; + enable-gpios = <&gpio_expander 2 GPIO_ACTIVE_HIGH>; + }; +}; + &hsusb { dr_mode = "otg"; status = "okay"; @@ -194,6 +215,11 @@ pinctrl-0 = <&scif_clk_pins>; pinctrl-names = "default"; + hscif0_pins: hscif0 { + groups = "hscif0_data", "hscif0_ctrl"; + function = "hscif0"; + }; + scif2_pins: scif2 { groups = "scif2_data_a"; function = "scif2";