[4.19.y-cip,3/6] dt-bindings: can: rcar_canfd: document r8a774a1 support

Commit Message

Biju Das Oct. 17, 2019, 6:57 a.m. UTC

commit a7aa356e2c9ad1e874460ac5ee499ed1690e80cb upstream.

Document the support for rcar_canfd on R8A774A1 SoC devices.

Signed-off-by: Fabrizio Castro <[e-mail]>
Reviewed-by: Chris Paterson <[e-mail]>
Signed-off-by: Geert Uytterhoeven <[e-mail]>
Signed-off-by: Biju Das <[e-mail]>
---
 Documentation/devicetree/bindings/net/can/rcar_canfd.txt | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

Comments

Pavel Machek Oct. 18, 2019, 4:49 p.m. UTC | #1

Hi!

> @@ -29,10 +30,10 @@ enable/disable the respective channel.
>  
>  Required properties for "renesas,r8a774c0-canfd", "renesas,r8a7795-canfd" and
>  "renesas,r8a7796-canfd" compatible:
> -In R8A774C0, R8A7795 and R8A7796 SoCs, canfd clock is a div6 clock and can be
> -used by both CAN and CAN FD controller at the same time. It needs to be scaled
> -to maximum frequency if any of these controllers use it. This is done using the
> -below properties:
> +In R8A774A1, R8A774C0, R8A7795 and R8A7796 SoCs, canfd clock is a div6 clock
> +and can beused by both CAN and CAN FD controller at the same time. It needs

This should be "be used", but I'd propose fixing it in the mainline
and applying this series anyway.

Best regards,
								Pavel

Biju Das Oct. 21, 2019, 6:48 a.m. UTC | #2

Hi Pavel,

Thanks for the feedback.

> Subject: Re: [PATCH 4.19.y-cip 3/6] dt-bindings: can: rcar_canfd: document
> r8a774a1 support
> 
> Hi!
> 
> > @@ -29,10 +30,10 @@ enable/disable the respective channel.
> >
> >  Required properties for "renesas,r8a774c0-canfd",
> > "renesas,r8a7795-canfd" and  "renesas,r8a7796-canfd" compatible:
> > -In R8A774C0, R8A7795 and R8A7796 SoCs, canfd clock is a div6 clock
> > and can be -used by both CAN and CAN FD controller at the same time.
> > It needs to be scaled -to maximum frequency if any of these
> > controllers use it. This is done using the -below properties:
> > +In R8A774A1, R8A774C0, R8A7795 and R8A7796 SoCs, canfd clock is a
> > +div6 clock and can beused by both CAN and CAN FD controller at the
> > +same time. It needs
> 
> This should be "be used", but I'd propose fixing it in the mainline and
> applying this series anyway.

Good Catch. Yes this to be fixed it in the Upstream first.

Cheers,
Biju

Patch

diff --git a/Documentation/devicetree/bindings/net/can/rcar_canfd.txt b/Documentation/devicetree/bindings/net/can/rcar_canfd.txt
index 804c68f..fecd6db 100644
--- a/Documentation/devicetree/bindings/net/can/rcar_canfd.txt
+++ b/Documentation/devicetree/bindings/net/can/rcar_canfd.txt
@@ -4,6 +4,7 @@  Renesas R-Car CAN FD controller Device Tree Bindings
 Required properties:
 - compatible: Must contain one or more of the following:
   - "renesas,rcar-gen3-canfd" for R-Car Gen3 and RZ/G2 compatible controllers.
+  - "renesas,r8a774a1-canfd" for R8A774A1 (RZ/G2M) compatible controller.
   - "renesas,r8a774c0-canfd" for R8A774C0 (RZ/G2E) compatible controller.
   - "renesas,r8a7795-canfd" for R8A7795 (R-Car H3) compatible controller.
   - "renesas,r8a7796-canfd" for R8A7796 (R-Car M3-W) compatible controller.
@@ -29,10 +30,10 @@  enable/disable the respective channel.
 
 Required properties for "renesas,r8a774c0-canfd", "renesas,r8a7795-canfd" and
 "renesas,r8a7796-canfd" compatible:
-In R8A774C0, R8A7795 and R8A7796 SoCs, canfd clock is a div6 clock and can be
-used by both CAN and CAN FD controller at the same time. It needs to be scaled
-to maximum frequency if any of these controllers use it. This is done using the
-below properties:
+In R8A774A1, R8A774C0, R8A7795 and R8A7796 SoCs, canfd clock is a div6 clock
+and can beused by both CAN and CAN FD controller at the same time. It needs
+to be scaled to maximum frequency if any of these controllers use it. This
+is done using the below properties:
 
 - assigned-clocks: phandle of canfd clock.
 - assigned-clock-rates: maximum frequency of this clock.