[cip-kernel-config] qemu_cip_defconfig: Add EFI_STUB to config

Commit Message

Quirin Gylstorff Aug. 3, 2020, 10:12 a.m. UTC

From: Quirin Gylstorff <[e-mail]>

If EFI_STUB is not active booting QEMU with OVMF efi will fail
with the following error message `KVM internal error. Suberror: 3`.

OVMF efi is used in isar-cip-core to demonstrate secure-boot with
a unified kernel image.

Signed-off-by: Quirin Gylstorff <[e-mail]>
---
 4.19.y-cip/x86/cip_qemu_defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Nobuhiro Iwamatsu Aug. 6, 2020, 6:46 a.m. UTC | #1

Hi,

Thanks for your patch.

> -----Original Message-----
> From: [e-mail] [mailto:[e-mail]] On Behalf Of Quirin Gylstorff
> Sent: Monday, August 3, 2020 7:12 PM
> To: [e-mail]; sangorrin daniel(サンゴリン ダニエル □ＳＷＣ◯ＡＣＴ)
> <[e-mail]>; [e-mail]
> Cc: Quirin Gylstorff <[e-mail]>
> Subject: [cip-dev] [cip-kernel-config PATCH] qemu_cip_defconfig: Add EFI_STUB to config
> 
> From: Quirin Gylstorff <[e-mail]>
> 
> If EFI_STUB is not active booting QEMU with OVMF efi will fail
> with the following error message `KVM internal error. Suberror: 3`.
> 
> OVMF efi is used in isar-cip-core to demonstrate secure-boot with
> a unified kernel image.
> 
> Signed-off-by: Quirin Gylstorff <[e-mail]>
> ---
>  4.19.y-cip/x86/cip_qemu_defconfig | 1 +
>  1 file changed, 1 insertion(+)

Please update cip_qemu.sources too.

Best regards,
  Nobuhiro
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#5104): https://lists.cip-project.org/g/cip-dev/message/5104
Mute This Topic: https://lists.cip-project.org/mt/75962579/4520428
Group Owner: [e-mail]
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129116/1171672734/xyzzy  [[e-mail]]
-=-=-=-=-=-=-=-=-=-=-=-

Quirin Gylstorff Aug. 6, 2020, 2:26 p.m. UTC | #2

On 8/6/20 8:46 AM, Nobuhiro Iwamatsu wrote:
> Hi,
> 
> Thanks for your patch.
> 
>> -----Original Message-----
>> From: [e-mail] [mailto:[e-mail]] On Behalf Of Quirin Gylstorff
>> Sent: Monday, August 3, 2020 7:12 PM
>> To: [e-mail]; sangorrin daniel(サンゴリン ダニエル □ＳＷＣ◯ＡＣＴ)
>> <[e-mail]>; [e-mail]
>> Cc: Quirin Gylstorff <[e-mail]>
>> Subject: [cip-dev] [cip-kernel-config PATCH] qemu_cip_defconfig: Add EFI_STUB to config
>>
>> From: Quirin Gylstorff <[e-mail]>
>>
>> If EFI_STUB is not active booting QEMU with OVMF efi will fail
>> with the following error message `KVM internal error. Suberror: 3`.
>>
>> OVMF efi is used in isar-cip-core to demonstrate secure-boot with
>> a unified kernel image.
>>
>> Signed-off-by: Quirin Gylstorff <[e-mail]>
>> ---
>>   4.19.y-cip/x86/cip_qemu_defconfig | 1 +
>>   1 file changed, 1 insertion(+)
> 
> Please update cip_qemu.sources too.

When i try to generate the sources - all .c and asm files are no longer 
part of the cip-qemu.sources. Did I miss something? Or should I try 
again like the last time this happened?

> 
> Best regards,
>    Nobuhiro
> 
Thanks,
Quirin
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#5105): https://lists.cip-project.org/g/cip-dev/message/5105
Mute This Topic: https://lists.cip-project.org/mt/75962579/4520428
Group Owner: [e-mail]
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129116/1171672734/xyzzy  [[e-mail]]
-=-=-=-=-=-=-=-=-=-=-=-

Nobuhiro Iwamatsu Aug. 7, 2020, 9:31 p.m. UTC | #3

Hi,

> -----Original Message-----
> From: [e-mail] [mailto:[e-mail]] On Behalf Of Quirin Gylstorff
> Sent: Thursday, August 6, 2020 11:27 PM
> To: [e-mail]; sangorrin daniel(サンゴリン ダニエル □ＳＷＣ◯ＡＣＴ)
> <[e-mail]>; [e-mail]
> Subject: Re: [cip-dev] [cip-kernel-config PATCH] qemu_cip_defconfig: Add EFI_STUB to config
> 
> 
> 
> On 8/6/20 8:46 AM, Nobuhiro Iwamatsu wrote:
> > Hi,
> >
> > Thanks for your patch.
> >
> >> -----Original Message-----
> >> From: [e-mail] [mailto:[e-mail]] On Behalf Of Quirin Gylstorff
> >> Sent: Monday, August 3, 2020 7:12 PM
> >> To: [e-mail]; sangorrin daniel(サンゴリン ダニエル □ＳＷＣ◯ＡＣＴ)
> >> <[e-mail]>; [e-mail]
> >> Cc: Quirin Gylstorff <[e-mail]>
> >> Subject: [cip-dev] [cip-kernel-config PATCH] qemu_cip_defconfig: Add EFI_STUB to config
> >>
> >> From: Quirin Gylstorff <[e-mail]>
> >>
> >> If EFI_STUB is not active booting QEMU with OVMF efi will fail
> >> with the following error message `KVM internal error. Suberror: 3`.
> >>
> >> OVMF efi is used in isar-cip-core to demonstrate secure-boot with
> >> a unified kernel image.
> >>
> >> Signed-off-by: Quirin Gylstorff <[e-mail]>
> >> ---
> >>   4.19.y-cip/x86/cip_qemu_defconfig | 1 +
> >>   1 file changed, 1 insertion(+)
> >
> > Please update cip_qemu.sources too.
> 
> When i try to generate the sources - all .c and asm files are no longer
> part of the cip-qemu.sources. Did I miss something? Or should I try
> again like the last time this happened?

Thanks for your check.
Sorry, I wanted to check if there was a fix in cip_qemu.sources.
I applied this patch.

> >
> Thanks,
> Quirin

Best regards,
  Nobuhiro
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#5106): https://lists.cip-project.org/g/cip-dev/message/5106
Mute This Topic: https://lists.cip-project.org/mt/75962579/4520428
Group Owner: [e-mail]
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129116/1171672734/xyzzy  [[e-mail]]
-=-=-=-=-=-=-=-=-=-=-=-

Quirin Gylstorff Aug. 20, 2020, 8:50 a.m. UTC | #4

On 8/7/20 11:31 PM, Nobuhiro Iwamatsu wrote:
> Hi,
> 
>> -----Original Message-----
>> From: [e-mail] [mailto:[e-mail]] On Behalf Of Quirin Gylstorff
>> Sent: Thursday, August 6, 2020 11:27 PM
>> To: [e-mail]; sangorrin daniel(サンゴリン ダニエル □ＳＷＣ◯ＡＣＴ)
>> <[e-mail]>; [e-mail]
>> Subject: Re: [cip-dev] [cip-kernel-config PATCH] qemu_cip_defconfig: Add EFI_STUB to config
>>
>>
>>
>> On 8/6/20 8:46 AM, Nobuhiro Iwamatsu wrote:
>>> Hi,
>>>
>>> Thanks for your patch.
>>>
>>>> -----Original Message-----
>>>> From: [e-mail] [mailto:[e-mail]] On Behalf Of Quirin Gylstorff
>>>> Sent: Monday, August 3, 2020 7:12 PM
>>>> To: [e-mail]; sangorrin daniel(サンゴリン ダニエル □ＳＷＣ◯ＡＣＴ)
>>>> <[e-mail]>; [e-mail]
>>>> Cc: Quirin Gylstorff <[e-mail]>
>>>> Subject: [cip-dev] [cip-kernel-config PATCH] qemu_cip_defconfig: Add EFI_STUB to config
>>>>
>>>> From: Quirin Gylstorff <[e-mail]>
>>>>
>>>> If EFI_STUB is not active booting QEMU with OVMF efi will fail
>>>> with the following error message `KVM internal error. Suberror: 3`.
>>>>
>>>> OVMF efi is used in isar-cip-core to demonstrate secure-boot with
>>>> a unified kernel image.
>>>>
>>>> Signed-off-by: Quirin Gylstorff <[e-mail]>
>>>> ---
>>>>    4.19.y-cip/x86/cip_qemu_defconfig | 1 +
>>>>    1 file changed, 1 insertion(+)
>>>
>>> Please update cip_qemu.sources too.
>>
>> When i try to generate the sources - all .c and asm files are no longer
>> part of the cip-qemu.sources. Did I miss something? Or should I try
>> again like the last time this happened?
> 
> Thanks for your check.
> Sorry, I wanted to check if there was a fix in cip_qemu.sources.
> I applied this patch.
>

Hi,

I didn't find the patch applied to cip-kernel-config. Is something missing?

Kind regards,
quirin

>>>
>> Thanks,
>> Quirin
> 
> Best regards,
>    Nobuhiro
> 
> 
> 
>

Nobuhiro Iwamatsu Aug. 20, 2020, 11:08 p.m. UTC | #5

Hi,

> -----Original Message-----
> From: [e-mail] [mailto:[e-mail]] On Behalf Of Quirin Gylstorff
> Sent: Thursday, August 20, 2020 5:50 PM
> To: [e-mail]; iwamatsu nobuhiro(岩松 信洋 □ＳＷＣ◯ＡＣＴ) <[e-mail]>
> Subject: Re: [cip-dev] [cip-kernel-config PATCH] qemu_cip_defconfig: Add EFI_STUB to config
> 

<snip>

> >>>>
> >>>> Signed-off-by: Quirin Gylstorff <[e-mail]>
> >>>> ---
> >>>>    4.19.y-cip/x86/cip_qemu_defconfig | 1 +
> >>>>    1 file changed, 1 insertion(+)
> >>>
> >>> Please update cip_qemu.sources too.
> >>
> >> When i try to generate the sources - all .c and asm files are no longer
> >> part of the cip-qemu.sources. Did I miss something? Or should I try
> >> again like the last time this happened?
> >
> > Thanks for your check.
> > Sorry, I wanted to check if there was a fix in cip_qemu.sources.
> > I applied this patch.
> >
> 
> Hi,
> 
> I didn't find the patch applied to cip-kernel-config. Is something missing?
> 

Sorry, I just pushed.

> Kind regards,
> quirin

Best regards,
  Nobuhiro
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#5165): https://lists.cip-project.org/g/cip-dev/message/5165
Mute This Topic: https://lists.cip-project.org/mt/75962579/4520428
Group Owner: [e-mail]
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129116/1171672734/xyzzy  [[e-mail]]
-=-=-=-=-=-=-=-=-=-=-=-

Patch

diff --git a/4.19.y-cip/x86/cip_qemu_defconfig b/4.19.y-cip/x86/cip_qemu_defconfig
index 02732ae..8c05b4f 100644
--- a/4.19.y-cip/x86/cip_qemu_defconfig
+++ b/4.19.y-cip/x86/cip_qemu_defconfig
@@ -30,6 +30,7 @@  CONFIG_X86_CHECK_BIOS_CORRUPTION=y
 # CONFIG_MTRR_SANITIZER is not set
 CONFIG_EFI=y
 CONFIG_HZ_1000=y
+CONFIG_EFI_STUB=y
 CONFIG_KEXEC=y
 CONFIG_CRASH_DUMP=y
 CONFIG_HIBERNATION=y