[5.10.y-cip,29/61] ravb: Factorise ravb_dmac_init function

Message ID	20220110122331.24114-30-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive)
State	Accepted
Delegated to:	Pavel Machek
Headers	show Return-Path: <prabhakar.mahadev-lad.rj@bp.renesas.com> ip: 210.160.252.171, mailfrom: prabhakar.mahadev-lad.rj@bp.renesas.com) From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> To: cip-dev@lists.cip-project.org, Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>, Pavel Machek <pavel@denx.de> Cc: Biju Das <biju.das.jz@bp.renesas.com> Subject: [PATCH 5.10.y-cip 29/61] ravb: Factorise ravb_dmac_init function Date: Mon, 10 Jan 2022 12:22:59 +0000 Message-Id: <20220110122331.24114-30-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: <20220110122331.24114-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20220110122331.24114-1-prabhakar.mahadev-lad.rj@bp.renesas.com>
Series	Add Ethernet support to RZ/G2L \| expand [5.10.y-cip,00/61] Add Ethernet support to RZ/G2L [5.10.y-cip,01/61] dt-bindings: net: renesas,etheravb: Add additional clocks [5.10.y-cip,02/61] dt-bindings: net: renesas,etheravb: Fix optional second clock name [5.10.y-cip,03/61] dt-bindings: net: renesas,etheravb: Document Gigabit Ethernet IP [5.10.y-cip,04/61] dt-bindings: net: renesas,etheravb: Drop "int_" prefix and "_n" suffix from inte… [5.10.y-cip,05/61] net: ethernet: ravb: Enable optional refclk [5.10.y-cip,06/61] net: ethernet: ravb: Fix release of refclk [5.10.y-cip,07/61] net: ethernet: ravb: Use devm_platform_get_and_ioremap_resource() [5.10.y-cip,08/61] ravb: Fix a typo in comment [5.10.y-cip,09/61] ravb: Remove checks for unsupported internal delay modes [5.10.y-cip,10/61] ravb: Use unsigned int for num_tx_desc variable in struct ravb_private [5.10.y-cip,11/61] ravb: Add struct ravb_hw_info to driver data [5.10.y-cip,12/61] ravb: Add aligned_tx to struct ravb_hw_info [5.10.y-cip,13/61] ravb: Add max_rx_len to struct ravb_hw_info [5.10.y-cip,14/61] ravb: Add stats_len to struct ravb_hw_info [5.10.y-cip,15/61] ravb: Add gstrings_stats and gstrings_size to struct ravb_hw_info [5.10.y-cip,16/61] ravb: Add net_features and net_hw_features to struct ravb_hw_info [5.10.y-cip,17/61] ravb: Add internal delay hw feature to struct ravb_hw_info [5.10.y-cip,18/61] ravb: Add tx_counters to struct ravb_hw_info [5.10.y-cip,19/61] ravb: Remove the macros NUM_TX_DESC_GEN[23] [5.10.y-cip,20/61] ravb: Add multi_irq to struct ravb_hw_info [5.10.y-cip,21/61] ravb: Add no_ptp_cfg_active to struct ravb_hw_info [5.10.y-cip,22/61] ravb: Add ptp_cfg_active to struct ravb_hw_info [5.10.y-cip,23/61] ravb: Factorise ravb_ring_free function [5.10.y-cip,24/61] ravb: Factorise ravb_ring_format function [5.10.y-cip,25/61] ravb: Factorise ravb_ring_init function [5.10.y-cip,26/61] ravb: Factorise ravb_rx function [5.10.y-cip,27/61] ravb: Factorise ravb_adjust_link function [5.10.y-cip,28/61] ravb: Factorise ravb_set_features [5.10.y-cip,29/61] ravb: Factorise ravb_dmac_init function [5.10.y-cip,30/61] ravb: Factorise ravb_emac_init function [5.10.y-cip,31/61] ravb: Add reset support [5.10.y-cip,32/61] ravb: Rename "ravb_set_features_rx_csum" function to "ravb_set_features_rcar" [5.10.y-cip,33/61] ravb: Rename "no_ptp_cfg_active" and "ptp_cfg_active" variables [5.10.y-cip,34/61] ravb: Add nc_queue to struct ravb_hw_info [5.10.y-cip,35/61] ravb: Add support for RZ/G2L SoC [5.10.y-cip,36/61] ravb: Initialize GbEthernet DMAC [5.10.y-cip,37/61] ravb: remove APSR_DM [5.10.y-cip,38/61] ravb: Exclude gPTP feature support for RZ/G2L [5.10.y-cip,39/61] ravb: Add tsrq to struct ravb_hw_info [5.10.y-cip,40/61] ravb: Add magic_pkt to struct ravb_hw_info [5.10.y-cip,41/61] ravb: Add half_duplex to struct ravb_hw_info [5.10.y-cip,42/61] ravb: update "undocumented" annotations [5.10.y-cip,43/61] ravb: Remove extra TAB [5.10.y-cip,44/61] ravb: Initialize GbEthernet E-MAC [5.10.y-cip,45/61] ravb: Add rx_max_buf_size to struct ravb_hw_info [5.10.y-cip,46/61] ravb: Use ALIGN macro for max_rx_len [5.10.y-cip,47/61] ravb: Fillup ravb_alloc_rx_desc_gbeth() stub [5.10.y-cip,48/61] ravb: Fillup ravb_rx_ring_free_gbeth() stub [5.10.y-cip,49/61] ravb: Fillup ravb_rx_ring_format_gbeth() stub [5.10.y-cip,50/61] ravb: Fillup ravb_rx_gbeth() stub [5.10.y-cip,51/61] ravb: Add carrier_counters to struct ravb_hw_info [5.10.y-cip,52/61] ravb: Add support to retrieve stats for GbEthernet [5.10.y-cip,53/61] ravb: Rename "tsrq" variable [5.10.y-cip,54/61] ravb: Optimize ravb_emac_init_gbeth function [5.10.y-cip,55/61] ravb: Rename "nc_queue" feature bit [5.10.y-cip,56/61] ravb: Update ravb_emac_init_gbeth() [5.10.y-cip,57/61] ravb: Fix typo AVB->DMAC [5.10.y-cip,58/61] clk: renesas: r9a07g044: Add ethernet clock sources [5.10.y-cip,59/61] clk: renesas: r9a07g044: Add GbEthernet clock/reset [5.10.y-cip,60/61] arm64: dts: renesas: r9a07g044: Add GbEthernet nodes [5.10.y-cip,61/61] arm64: dts: renesas: rzg2l-smarc-som: Enable Ethernet

Message ID

20220110122331.24114-30-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive)

State

Accepted

Delegated to:

Pavel Machek

Headers

From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
To: cip-dev@lists.cip-project.org,
	Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>,
	Pavel Machek <pavel@denx.de>
Cc: Biju Das <biju.das.jz@bp.renesas.com>
Subject: [PATCH 5.10.y-cip 29/61] ravb: Factorise ravb_dmac_init function
Date: Mon, 10 Jan 2022 12:22:59 +0000
Message-Id: <20220110122331.24114-30-prabhakar.mahadev-lad.rj@bp.renesas.com>
In-Reply-To: <20220110122331.24114-1-prabhakar.mahadev-lad.rj@bp.renesas.com>
References: <20220110122331.24114-1-prabhakar.mahadev-lad.rj@bp.renesas.com>

Series

Add Ethernet support to RZ/G2L | expand

Commit Message

Lad Prabhakar Jan. 10, 2022, 12:22 p.m. UTC

From: Biju Das <biju.das.jz@bp.renesas.com>

commit eb4fd127448b173df15b4e92ace016467b2fc441 upstream.

The DMAC IP on the R-Car AVB module has different initialization
parameters for RCR, TGC, TCCR, RIC0, RIC2, and TIC compared to
DMAC IP on the RZ/G2L Gigabit Ethernet module. Factorise the
ravb_dmac_init function to support the later SoC.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
 drivers/net/ethernet/renesas/ravb.h      |  1 +
 drivers/net/ethernet/renesas/ravb_main.c | 52 ++++++++++++++----------
 2 files changed, 32 insertions(+), 21 deletions(-)

diff --git a/drivers/net/ethernet/renesas/ravb.h b/drivers/net/ethernet/renesas/ravb.h
index 262c6b9d470c..536f99b3eb08 100644
--- a/drivers/net/ethernet/renesas/ravb.h
+++ b/drivers/net/ethernet/renesas/ravb.h
@@ -987,6 +987,7 @@  struct ravb_hw_info {
 	bool (*receive)(struct net_device *ndev, int *quota, int q);
 	void (*set_rate)(struct net_device *ndev);
 	int (*set_rx_csum_feature)(struct net_device *ndev, netdev_features_t features);
+	void (*dmac_init)(struct net_device *ndev);
 	const char (*gstrings_stats)[ETH_GSTRING_LEN];
 	size_t gstrings_size;
 	netdev_features_t net_hw_features;
diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
index 862bf2715fe1..0fcedcff6444 100644
--- a/drivers/net/ethernet/renesas/ravb_main.c
+++ b/drivers/net/ethernet/renesas/ravb_main.c
@@ -450,30 +450,10 @@  static void ravb_emac_init(struct net_device *ndev)
 	ravb_write(ndev, ECSIPR_ICDIP | ECSIPR_MPDIP | ECSIPR_LCHNGIP, ECSIPR);
 }
 
-/* Device init function for Ethernet AVB */
-static int ravb_dmac_init(struct net_device *ndev)
+static void ravb_rcar_dmac_init(struct net_device *ndev)
 {
 	struct ravb_private *priv = netdev_priv(ndev);
 	const struct ravb_hw_info *info = priv->info;
-	int error;
-
-	/* Set CONFIG mode */
-	error = ravb_config(ndev);
-	if (error)
-		return error;
-
-	error = ravb_ring_init(ndev, RAVB_BE);
-	if (error)
-		return error;
-	error = ravb_ring_init(ndev, RAVB_NC);
-	if (error) {
-		ravb_ring_free(ndev, RAVB_BE);
-		return error;
-	}
-
-	/* Descriptor format */
-	ravb_ring_format(ndev, RAVB_BE);
-	ravb_ring_format(ndev, RAVB_NC);
 
 	/* Set AVB RX */
 	ravb_write(ndev,
@@ -500,6 +480,34 @@  static int ravb_dmac_init(struct net_device *ndev)
 	ravb_write(ndev, RIC2_QFE0 | RIC2_QFE1 | RIC2_RFFE, RIC2);
 	/* Frame transmitted, timestamp FIFO updated */
 	ravb_write(ndev, TIC_FTE0 | TIC_FTE1 | TIC_TFUE, TIC);
+}
+
+/* Device init function for Ethernet AVB */
+static int ravb_dmac_init(struct net_device *ndev)
+{
+	struct ravb_private *priv = netdev_priv(ndev);
+	const struct ravb_hw_info *info = priv->info;
+	int error;
+
+	/* Set CONFIG mode */
+	error = ravb_config(ndev);
+	if (error)
+		return error;
+
+	error = ravb_ring_init(ndev, RAVB_BE);
+	if (error)
+		return error;
+	error = ravb_ring_init(ndev, RAVB_NC);
+	if (error) {
+		ravb_ring_free(ndev, RAVB_BE);
+		return error;
+	}
+
+	/* Descriptor format */
+	ravb_ring_format(ndev, RAVB_BE);
+	ravb_ring_format(ndev, RAVB_NC);
+
+	info->dmac_init(ndev);
 
 	/* Setting the control will start the AVB-DMAC process. */
 	ravb_modify(ndev, CCC, CCC_OPC, CCC_OPC_OPERATION);
@@ -1988,6 +1996,7 @@  static const struct ravb_hw_info ravb_gen3_hw_info = {
 	.receive = ravb_rcar_rx,
 	.set_rate = ravb_set_rate,
 	.set_rx_csum_feature = ravb_set_features_rx_csum,
+	.dmac_init = ravb_rcar_dmac_init,
 	.gstrings_stats = ravb_gstrings_stats,
 	.gstrings_size = sizeof(ravb_gstrings_stats),
 	.net_hw_features = NETIF_F_RXCSUM,
@@ -2007,6 +2016,7 @@  static const struct ravb_hw_info ravb_gen2_hw_info = {
 	.receive = ravb_rcar_rx,
 	.set_rate = ravb_set_rate,
 	.set_rx_csum_feature = ravb_set_features_rx_csum,
+	.dmac_init = ravb_rcar_dmac_init,
 	.gstrings_stats = ravb_gstrings_stats,
 	.gstrings_size = sizeof(ravb_gstrings_stats),
 	.net_hw_features = NETIF_F_RXCSUM,

[5.10.y-cip,29/61] ravb: Factorise ravb_dmac_init function

Commit Message

Patch