diff mbox series

[isar-cip-core,v3,2/2] conf/distro: Delete debian-sid.list

Message ID 20230203105142.367778-3-Quirin.Gylstorff@siemens.com (mailing list archive)
State Superseded
Headers show
Series Use cip prefix and snapshot prefix for sid lists | expand

Commit Message

Quirin Gylstorff Feb. 3, 2023, 10:51 a.m. UTC
From: Quirin Gylstorff <quirin.gylstorff@siemens.com>

As the file is not used delete.

This is done to avoid infecting other layers with the snapshot version.

Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
---
 conf/distro/debian-sid.list | 2 --
 1 file changed, 2 deletions(-)
 delete mode 100644 conf/distro/debian-sid.list

Comments

Jan Kiszka Feb. 3, 2023, 11:05 a.m. UTC | #1
On 03.02.23 11:51, Quirin Gylstorff wrote:
> From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
> 
> As the file is not used delete.
> 
> This is done to avoid infecting other layers with the snapshot version.
> 
> Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
> ---
>  conf/distro/debian-sid.list | 2 --
>  1 file changed, 2 deletions(-)
>  delete mode 100644 conf/distro/debian-sid.list
> 
> diff --git a/conf/distro/debian-sid.list b/conf/distro/debian-sid.list
> deleted file mode 100644
> index 46d34d7..0000000
> --- a/conf/distro/debian-sid.list
> +++ /dev/null
> @@ -1,2 +0,0 @@
> -deb	[check-valid-until=no] https://snapshot.debian.org/archive/debian/20220925T001806Z sid main
> -deb-src	[check-valid-until=no] https://snapshot.debian.org/archive/debian/20220925T001806Z sid main

This is wrong. v2 renamed it but forgot to adjust the user of it. That
was what my question should have suggested.

Jan
Quirin Gylstorff Feb. 3, 2023, 6:53 p.m. UTC | #2
On 2/3/23 12:05, Jan Kiszka wrote:
> On 03.02.23 11:51, Quirin Gylstorff wrote:
>> From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
>>
>> As the file is not used delete.
>>
>> This is done to avoid infecting other layers with the snapshot version.
>>
>> Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
>> ---
>>   conf/distro/debian-sid.list | 2 --
>>   1 file changed, 2 deletions(-)
>>   delete mode 100644 conf/distro/debian-sid.list
>>
>> diff --git a/conf/distro/debian-sid.list b/conf/distro/debian-sid.list
>> deleted file mode 100644
>> index 46d34d7..0000000
>> --- a/conf/distro/debian-sid.list
>> +++ /dev/null
>> @@ -1,2 +0,0 @@
>> -deb	[check-valid-until=no] https://snapshot.debian.org/archive/debian/20220925T001806Z sid main
>> -deb-src	[check-valid-until=no] https://snapshot.debian.org/archive/debian/20220925T001806Z sid main
> 
> This is wrong. v2 renamed it but forgot to adjust the user of it. That
> was what my question should have suggested.
> 

Was this every used and what is the usecase?

Even ISAR has no offical sid distro meta/conf/distro/debian-common.conf 
sets DISTRO_APT_SOURCE with default assignment:
```DISTRO_APT_SOURCES ?= 
"conf/distro/${BASE_DISTRO}-${BASE_DISTRO_CODENAME}.list"

``` [1]
Which is overriden by meta/conf/distro/debian-sid-ports.conf with
```
DISTRO_APT_SOURCES = "conf/distro/debian-${BASE_DISTRO_CODENAME}-ports.list"

```[2]

[1]: 
https://github.com/ilbers/isar/blob/73f0cc16ca50f1102084851b1bc0f2d59925c9ad/meta/conf/distro/debian-common.conf#L11

[2]:https://github.com/ilbers/isar/blob/73f0cc16ca50f1102084851b1bc0f2d59925c9ad/meta/conf/distro/debian-sid-ports.conf#L16

Quirin


> Jan
>
Jan Kiszka Feb. 4, 2023, 6:38 a.m. UTC | #3
On 03.02.23 19:53, Gylstorff Quirin wrote:
> 
> 
> On 2/3/23 12:05, Jan Kiszka wrote:
>> On 03.02.23 11:51, Quirin Gylstorff wrote:
>>> From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
>>>
>>> As the file is not used delete.
>>>
>>> This is done to avoid infecting other layers with the snapshot version.
>>>
>>> Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
>>> ---
>>>   conf/distro/debian-sid.list | 2 --
>>>   1 file changed, 2 deletions(-)
>>>   delete mode 100644 conf/distro/debian-sid.list
>>>
>>> diff --git a/conf/distro/debian-sid.list b/conf/distro/debian-sid.list
>>> deleted file mode 100644
>>> index 46d34d7..0000000
>>> --- a/conf/distro/debian-sid.list
>>> +++ /dev/null
>>> @@ -1,2 +0,0 @@
>>> -deb    [check-valid-until=no]
>>> https://snapshot.debian.org/archive/debian/20220925T001806Z sid main
>>> -deb-src    [check-valid-until=no]
>>> https://snapshot.debian.org/archive/debian/20220925T001806Z sid main
>>
>> This is wrong. v2 renamed it but forgot to adjust the user of it. That
>> was what my question should have suggested.
>>
> 
> Was this every used and what is the usecase?

HOST_DISTRO_APT_SOURCES

Jan

> 
> Even ISAR has no offical sid distro meta/conf/distro/debian-common.conf
> sets DISTRO_APT_SOURCE with default assignment:
> ```DISTRO_APT_SOURCES ?=
> "conf/distro/${BASE_DISTRO}-${BASE_DISTRO_CODENAME}.list"
> 
> ``` [1]
> Which is overriden by meta/conf/distro/debian-sid-ports.conf with
> ```
> DISTRO_APT_SOURCES =
> "conf/distro/debian-${BASE_DISTRO_CODENAME}-ports.list"
> 
> ```[2]
> 
> [1]:
> https://github.com/ilbers/isar/blob/73f0cc16ca50f1102084851b1bc0f2d59925c9ad/meta/conf/distro/debian-common.conf#L11
> 
> [2]:https://github.com/ilbers/isar/blob/73f0cc16ca50f1102084851b1bc0f2d59925c9ad/meta/conf/distro/debian-sid-ports.conf#L16
> 
> Quirin
> 
> 
>> Jan
>>
diff mbox series

Patch

diff --git a/conf/distro/debian-sid.list b/conf/distro/debian-sid.list
deleted file mode 100644
index 46d34d7..0000000
--- a/conf/distro/debian-sid.list
+++ /dev/null
@@ -1,2 +0,0 @@ 
-deb	[check-valid-until=no] https://snapshot.debian.org/archive/debian/20220925T001806Z sid main
-deb-src	[check-valid-until=no] https://snapshot.debian.org/archive/debian/20220925T001806Z sid main