diff mbox series

[isar-cip-core,1/2] kas/opt/reproducible.yml: Add kas file for reproducible builds target

Message ID 20230222091159.18216-2-venkata.pyla@toshiba-tsip.com (mailing list archive)
State Superseded
Headers show
Series ci for reproducible build check | expand

Commit Message

Venkata Pyla Feb. 22, 2023, 9:11 a.m. UTC
From: venkata pyla <venkata.pyla@toshiba-tsip.com>

This kas file set the 'SOURCE_DATE_EPOCH' variable to last commit
timestamp required for building reproducible image.

Signed-off-by: venkata pyla <venkata.pyla@toshiba-tsip.com>
---
 kas/opt/reproducible.yml | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 kas/opt/reproducible.yml

Comments

Felix Moessbauer Feb. 22, 2023, 9:18 a.m. UTC | #1
On Wed, 2023-02-22 at 14:41 +0530, Venkata Pyla via lists.cip-
project.org wrote:
> From: venkata pyla <venkata.pyla@toshiba-tsip.com>
> 
> This kas file set the 'SOURCE_DATE_EPOCH' variable to last commit
> timestamp required for building reproducible image.
> 
> Signed-off-by: venkata pyla <venkata.pyla@toshiba-tsip.com>
> ---
>  kas/opt/reproducible.yml | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>  create mode 100644 kas/opt/reproducible.yml
> 
> diff --git a/kas/opt/reproducible.yml b/kas/opt/reproducible.yml
> new file mode 100644
> index 0000000..173c018
> --- /dev/null
> +++ b/kas/opt/reproducible.yml
> @@ -0,0 +1,17 @@
> +#
> +# CIP Core, generic profile
> +#
> +# Copyright (c) Toshiba Corporation, 2023
> +#
> +# Authors:
> +#  Venkata Pyla <venkata.pyla@toshiba-tsip.com>
> +#
> +# SPDX-License-Identifier: MIT
> +#
> +header:
> +  version: 12
> +
> +local_conf_header:
> +  reproducible-builds: |
> +    SOURCE_DATE_EPOCH = "${@bb.process.run("git -C
                        ^^^
Please use immediate assignment here: ":=". By that, we can ensure that
this is immediately executed when bitbake reads this files, not once
the variable needs to be expanded.

Best regards,
Felix

> ${LAYERDIR_cip-core} log -1 --pretty=%ct | tr -d '\n'")[0]}"
> +
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#10775): 
> https://lists.cip-project.org/g/cip-dev/message/10775
> Mute This Topic: https://lists.cip-project.org/mt/97156286/6879696
> Group Owner: cip-dev+owner@lists.cip-project.org
> Unsubscribe: 
> https://lists.cip-project.org/g/cip-dev/leave/12054225/6879696/632350479/xyzzy
>  [felix.moessbauer@siemens.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Venkata Pyla Feb. 22, 2023, 10:56 a.m. UTC | #2
>-----Original Message-----
>From: cip-dev@lists.cip-project.org <cip-dev@lists.cip-project.org> On Behalf
>Of Felix Moessbauer
>Sent: 22 February 2023 14:48
>To: cip-dev@lists.cip-project.org; Kiszka, Jan <jan.kiszka@siemens.com>
>Cc: dinesh kumar(TSIP TMIEC ODG Porting) <dinesh.kumar@toshiba-
>tsip.com>; hayashi kazuhiro(林 和宏 □SWC◯ACT)
><kazuhiro3.hayashi@toshiba.co.jp>; pyla venkata(TSIP TMIEC ODG
>Porting) <Venkata.Pyla@toshiba-tsip.com>
>Subject: Re: [cip-dev] [isar-cip-core 1/2] kas/opt/reproducible.yml: Add kas file
>for reproducible builds target
>
>On Wed, 2023-02-22 at 14:41 +0530, Venkata Pyla via lists.cip- project.org
>wrote:
>> From: venkata pyla <venkata.pyla@toshiba-tsip.com>
>>
>> This kas file set the 'SOURCE_DATE_EPOCH' variable to last commit
>> timestamp required for building reproducible image.
>>
>> Signed-off-by: venkata pyla <venkata.pyla@toshiba-tsip.com>
>> ---
>>  kas/opt/reproducible.yml | 17 +++++++++++++++++
>>  1 file changed, 17 insertions(+)
>>  create mode 100644 kas/opt/reproducible.yml
>>
>> diff --git a/kas/opt/reproducible.yml b/kas/opt/reproducible.yml new
>> file mode 100644 index 0000000..173c018
>> --- /dev/null
>> +++ b/kas/opt/reproducible.yml
>> @@ -0,0 +1,17 @@
>> +#
>> +# CIP Core, generic profile
>> +#
>> +# Copyright (c) Toshiba Corporation, 2023 # # Authors:
>> +#  Venkata Pyla <venkata.pyla@toshiba-tsip.com> # #
>> +SPDX-License-Identifier: MIT #
>> +header:
>> +  version: 12
>> +
>> +local_conf_header:
>> +  reproducible-builds: |
>> +    SOURCE_DATE_EPOCH = "${@bb.process.run("git -C
>                        ^^^
>Please use immediate assignment here: ":=". By that, we can ensure that this is
>immediately executed when bitbake reads this files, not once the variable
>needs to be expanded.

haa correct, thanks for pointing out it should be immediate assignment, I will correct it.

>
>Best regards,
>Felix
>
>> ${LAYERDIR_cip-core} log -1 --pretty=%ct | tr -d '\n'")[0]}"
>> +
>>
>>
>>
diff mbox series

Patch

diff --git a/kas/opt/reproducible.yml b/kas/opt/reproducible.yml
new file mode 100644
index 0000000..173c018
--- /dev/null
+++ b/kas/opt/reproducible.yml
@@ -0,0 +1,17 @@ 
+#
+# CIP Core, generic profile
+#
+# Copyright (c) Toshiba Corporation, 2023
+#
+# Authors:
+#  Venkata Pyla <venkata.pyla@toshiba-tsip.com>
+#
+# SPDX-License-Identifier: MIT
+#
+header:
+  version: 12
+
+local_conf_header:
+  reproducible-builds: |
+    SOURCE_DATE_EPOCH = "${@bb.process.run("git -C ${LAYERDIR_cip-core} log -1 --pretty=%ct | tr -d '\n'")[0]}"
+