diff mbox series

[5.10.y-cip,11/31] rtc: fix RTC removal

Message ID	20230816142017.147173-12-biju.das.jz@bp.renesas.com (mailing list archive)
State	Accepted
Headers	show Return-Path: <biju.das.jz@bp.renesas.com> ip: 210.160.252.171, mailfrom: biju.das.jz@bp.renesas.com) From: Biju Das <biju.das.jz@bp.renesas.com> To: cip-dev@lists.cip-project.org, Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>, Pavel Machek <pavel@denx.de> Cc: Biju Das <biju.das.jz@bp.renesas.com>, Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> Subject: [PATCH 5.10.y-cip 11/31] rtc: fix RTC removal Date: Wed, 16 Aug 2023 15:19:57 +0100 Message-Id: <20230816142017.147173-12-biju.das.jz@bp.renesas.com> In-Reply-To: <20230816142017.147173-1-biju.das.jz@bp.renesas.com> References: <20230816142017.147173-1-biju.das.jz@bp.renesas.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
Series	Add Renesas PMIC RAA215300 driver and builtin RTC support \| expand [5.10.y-cip,00/31] Add Renesas PMIC RAA215300 driver and builtin RTC support [5.10.y-cip,01/31] regulator: dt-bindings: Add Renesas RAA215300 PMIC bindings [5.10.y-cip,02/31] regulator: Add Renesas PMIC RAA215300 driver [5.10.y-cip,03/31] regulator: raa215300: Add build dependency with COMMON_CLK [5.10.y-cip,04/31] Documentation: list RTC devres helpers in devres.rst [5.10.y-cip,05/31] rtc: nvmem: remove nvram ABI [5.10.y-cip,06/31] rtc: rv3032: fix nvram nvmem priv pointer [5.10.y-cip,07/31] rtc: add devm_ prefix to rtc_nvmem_register() [5.10.y-cip,08/31] rtc: rework rtc_register_device() resource management [5.10.y-cip,09/31] rtc: shrink devm_rtc_allocate_device() [5.10.y-cip,10/31] rtc: destroy mutex when releasing the device [5.10.y-cip,11/31] rtc: fix RTC removal [5.10.y-cip,12/31] rtc: introduce features bitfield [5.10.y-cip,13/31] rtc: class: don't call cdev_device_del() when cdev_device_add() failed [5.10.y-cip,14/31] rtc: class: check return value when calling dev_set_name() [5.10.y-cip,15/31] rtc: add alarm related features [5.10.y-cip,16/31] rtc: expose correction feature [5.10.y-cip,17/31] rtc: rtc_update_irq_enable: rework UIE emulation [5.10.y-cip,18/31] rtc: expose RTC_FEATURE_UPDATE_INTERRUPT [5.10.y-cip,19/31] rtc: class: Fix potential memleak in devm_rtc_allocate_device() [5.10.y-cip,20/31] rtc: isl1208: quiet maybe-unused variable warning [5.10.y-cip,21/31] rtc: isl1208: do not advertise update interrupt feature if no interrupt specified [5.10.y-cip,22/31] dt-bindings: rtc: isl1208: Convert to json-schema [5.10.y-cip,23/31] dt-bindings: rtc: isil,isl1208: Document clock and clock-names properties [5.10.y-cip,24/31] rtc: isl1208: Drop name variable [5.10.y-cip,25/31] rtc: isl1208: Make similar I2C and DT-based matching table [5.10.y-cip,26/31] rtc: isl1208: Drop enum isl1208_id and split isl1208_configs[] [5.10.y-cip,27/31] rtc: isl1208: Add isl1208_set_xtoscb() [5.10.y-cip,28/31] rtc: isl1208: Add support for the built-in RTC on the PMIC RAA215300 [5.10.y-cip,29/31] arm64: defconfig: Enable PMIC RAA215300 and RTC ISL 1208 configs [5.10.y-cip,30/31] arm64: dts: renesas: rzg2l-smarc-som: Enable PMIC and built-in RTC [5.10.y-cip,31/31] arm64: dts: renesas: rzg2lc-smarc-som: Enable PMIC and built-in RTC

Commit Message

Biju Das Aug. 16, 2023, 2:19 p.m. UTC

From: Alexandre Belloni <alexandre.belloni@bootlin.com>

commit f70cc33029fca3cf62bffb15102ea42eb4d097ac upstream.

Since the rtc_register_device, removing an RTC device will end with a
refcount_t: underflow; use-after-free warning since put_device is called
twice in the device tear down path.

Fixes: fdcfd854333b ("rtc: rework rtc_register_device() resource management")
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Link: https://lore.kernel.org/r/20201205231449.610980-1-alexandre.belloni@bootlin.com
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
 drivers/rtc/class.c | 1 -
 1 file changed, 1 deletion(-)

diff mbox series

Patch

diff --git a/drivers/rtc/class.c b/drivers/rtc/class.c
index 5a1de9078ae6..34ee17019895 100644
--- a/drivers/rtc/class.c
+++ b/drivers/rtc/class.c
@@ -344,7 +344,6 @@  static void devm_rtc_unregister_device(void *data)
 	cdev_device_del(&rtc->char_dev, &rtc->dev);
 	rtc->ops = NULL;
 	mutex_unlock(&rtc->ops_lock);
-	put_device(&rtc->dev);
 }
 
 static void devm_rtc_release_device(void *res)