diff mbox series

[5.10.y-cip,01/15] rtc: isl1208: Fix clock tick timed out message

Message ID 20230911144702.948246-2-biju.das.jz@bp.renesas.com (mailing list archive)
State Accepted
Headers show
Series Enable Renesas PMIC RAA215300 and RTC builtin support | expand

Commit Message

Biju Das Sept. 11, 2023, 2:46 p.m. UTC 
This patch is equivalent to the commit 2023c5c8fe2e85 "rtc: isl1208: do
not advertise update interrupt feature if no interrupt specified" on the
mainline.

Without this patch, an error message 'hwclock: select() to /dev/rtc0 to
wait for clock tick timed out' is seen on 5.10.y-cip kernel as built-in
RTC found on the PMIC does not populate interrupt by default on RZ/G2L
SMARC EVK platform.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
 drivers/rtc/rtc-isl1208.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
diff mbox series

Patch

diff --git a/drivers/rtc/rtc-isl1208.c b/drivers/rtc/rtc-isl1208.c
index f6101ee74cd6..a6f74cbc8c0a 100644
--- a/drivers/rtc/rtc-isl1208.c
+++ b/drivers/rtc/rtc-isl1208.c
@@ -946,10 +946,14 @@  isl1208_probe(struct i2c_client *client, const struct i2c_device_id *id)
 	if (rc)
 		return rc;
 
-	if (client->irq > 0)
+	if (client->irq > 0) {
 		rc = isl1208_setup_irq(client, client->irq);
-	if (rc)
-		return rc;
+		if (rc)
+			return rc;
+
+	} else {
+		isl1208->rtc->uie_unsupported = 1;
+	}
 
 	if (evdet_irq > 0 && evdet_irq != client->irq)
 		rc = isl1208_setup_irq(client, evdet_irq);