| Message ID | 20240122095210.54158-1-Quirin.Gylstorff@siemens.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [isar-cip-core,v2] efibootguard: Fix broken SRCREV to official tag version 0.16-1 | expand |
On Mon, 2024-01-22 at 10:51 +0100, Quirin Gylstorff wrote: > From: Quirin Gylstorff <quirin.gylstorff@siemens.com> > > This is now the tag version of 0.16-1. > > Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com> > --- > recipes-bsp/efibootguard/efibootguard_0.16-1+cip.bb | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/recipes-bsp/efibootguard/efibootguard_0.16-1+cip.bb > b/recipes-bsp/efibootguard/efibootguard_0.16-1+cip.bb > index 93114c3..e9a34d4 100644 > --- a/recipes-bsp/efibootguard/efibootguard_0.16-1+cip.bb > +++ b/recipes-bsp/efibootguard/efibootguard_0.16-1+cip.bb > @@ -22,9 +22,10 @@ SRC_URI = " \ > > https://github.com/siemens/efibootguard/archive/refs/tags/v${EBG_VERSION}.tar.gz;downloadfilename=efibootguard_${EBG_VERSION}.orig.tar.gz;unpack=0;name=tarball > \ > > git://salsa.debian.org/debian/efibootguard.git;protocol=https;branch= > master;name=debian \ > > file://debian-patches/0001-d-control-Make-compatible-with-debian-buster.patch > \ > + > file://debian-patches/0002-d-control-remove-native-from-python3-shtab.patch > \ As there was some back and forth on this, it might make sense to add a comment about why NOT having :native is correct. The corresponding discussion on the debian-cross ML is found in [1]. Citing the answer from Helmut: > For this reason, I recommend to use :native annotations sparingly and always check whether instead the target of the dependency can become M-A:foreign instead. Such checking has evidently not been done for efibootguard. Hence, it now FTBFS as a result of python3-shtab having rightly become Multi-Arch: foreign. efibootguard now needs to drop the :native annotation. [1] https://lists.debian.org/debian-cross/2024/01/msg00012.html Felix > " > SRC_URI[tarball.sha256sum] = > "d6d37c59aed17489d02b4f0b63db16994dfb8f9f70f54be4d65c366f58c6be9d" > -SRCREV_debian = "eacf94e767136a0257850ea0c888d234cb8cace4" > +SRCREV_debian = "ee551bc5239068ce5ab024089cf20385749ae77e" > > PROVIDES = "libebgenv-dev libebgenv0 efibootguard" >
On 22.01.24 10:51, Quirin Gylstorff wrote: > From: Quirin Gylstorff <quirin.gylstorff@siemens.com> > > This is now the tag version of 0.16-1. This looks completely broken - on Debian side. > > Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com> > --- > recipes-bsp/efibootguard/efibootguard_0.16-1+cip.bb | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/recipes-bsp/efibootguard/efibootguard_0.16-1+cip.bb b/recipes-bsp/efibootguard/efibootguard_0.16-1+cip.bb > index 93114c3..e9a34d4 100644 > --- a/recipes-bsp/efibootguard/efibootguard_0.16-1+cip.bb > +++ b/recipes-bsp/efibootguard/efibootguard_0.16-1+cip.bb We are coming from 0.16-1. > @@ -22,9 +22,10 @@ SRC_URI = " \ > https://github.com/siemens/efibootguard/archive/refs/tags/v${EBG_VERSION}.tar.gz;downloadfilename=efibootguard_${EBG_VERSION}.orig.tar.gz;unpack=0;name=tarball \ > git://salsa.debian.org/debian/efibootguard.git;protocol=https;branch=master;name=debian \ > file://debian-patches/0001-d-control-Make-compatible-with-debian-buster.patch \ > + file://debian-patches/0002-d-control-remove-native-from-python3-shtab.patch \ This is isar-cip-core now: We had that patch already in our tree? Looks like this was once added without ever being used. Also not nice. > " > SRC_URI[tarball.sha256sum] = "d6d37c59aed17489d02b4f0b63db16994dfb8f9f70f54be4d65c366f58c6be9d" > -SRCREV_debian = "eacf94e767136a0257850ea0c888d234cb8cace4" > +SRCREV_debian = "ee551bc5239068ce5ab024089cf20385749ae77e" > What's going on there on salsa? Can't you (plural) sort out this questions in an experimental branch first, even if the rest of Debian is similarly crazy? Even worse, that revision now contains a known-to-break change that we wanted to avoid in an uploaded release. And that release looks fishy as well: Date is "Mon, 13 Nov 2023 09:02:04 +0100", but it contains stuff that was only contributed this year?! IOW: I don't trust this to be stable yet. Jan
diff --git a/recipes-bsp/efibootguard/efibootguard_0.16-1+cip.bb b/recipes-bsp/efibootguard/efibootguard_0.16-1+cip.bb index 93114c3..e9a34d4 100644 --- a/recipes-bsp/efibootguard/efibootguard_0.16-1+cip.bb +++ b/recipes-bsp/efibootguard/efibootguard_0.16-1+cip.bb @@ -22,9 +22,10 @@ SRC_URI = " \ https://github.com/siemens/efibootguard/archive/refs/tags/v${EBG_VERSION}.tar.gz;downloadfilename=efibootguard_${EBG_VERSION}.orig.tar.gz;unpack=0;name=tarball \ git://salsa.debian.org/debian/efibootguard.git;protocol=https;branch=master;name=debian \ file://debian-patches/0001-d-control-Make-compatible-with-debian-buster.patch \ + file://debian-patches/0002-d-control-remove-native-from-python3-shtab.patch \ " SRC_URI[tarball.sha256sum] = "d6d37c59aed17489d02b4f0b63db16994dfb8f9f70f54be4d65c366f58c6be9d" -SRCREV_debian = "eacf94e767136a0257850ea0c888d234cb8cace4" +SRCREV_debian = "ee551bc5239068ce5ab024089cf20385749ae77e" PROVIDES = "libebgenv-dev libebgenv0 efibootguard"