diff mbox series

[isar-cip-core,v1] swupdate.bbclass: Fix setting reproducible timestamps for files in .swu file

Message ID 20240410072650.1701309-1-Adithya.Balakumar@toshiba-tsip.com (mailing list archive)
State Accepted
Headers show
Series [isar-cip-core,v1] swupdate.bbclass: Fix setting reproducible timestamps for files in .swu file | expand

Commit Message

Adithya Balakumar April 10, 2024, 7:26 a.m. UTC
Fix setting reproducible timestamps for the files that are included in the
.swu file.

This fixes issue #103

Signed-off-by: Adithya Balakumar <Adithya.Balakumar@toshiba-tsip.com>
---
 classes/swupdate.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jan Kiszka April 10, 2024, 8:16 a.m. UTC | #1
On 10.04.24 09:26, Adithya Balakumar wrote:
> Fix setting reproducible timestamps for the files that are included in the
> .swu file.
> 
> This fixes issue #103
> 
> Signed-off-by: Adithya Balakumar <Adithya.Balakumar@toshiba-tsip.com>
> ---
>  classes/swupdate.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/classes/swupdate.bbclass b/classes/swupdate.bbclass
> index 1c495da..25704aa 100644
> --- a/classes/swupdate.bbclass
> +++ b/classes/swupdate.bbclass
> @@ -252,7 +252,7 @@ IMAGE_CMD:swu() {
>                  if [ -f "$cpio_file" ]; then
>                      # Set file timestamps for reproducible builds
>                      if [ -n "${SOURCE_DATE_EPOCH}" ]; then
> -                        touch -d@"${SOURCE_DATE_EPOCH}" "$file"
> +                        touch -d@"${SOURCE_DATE_EPOCH}" "$cpio_file"
>                      fi
>                      case "$cpio_file" in
>                          sw-description*)

Looks like a regression of 7566320e3f5fa08d89628f4a790c85b737cc5da7.
Thanks, applied to next.

Jan
diff mbox series

Patch

diff --git a/classes/swupdate.bbclass b/classes/swupdate.bbclass
index 1c495da..25704aa 100644
--- a/classes/swupdate.bbclass
+++ b/classes/swupdate.bbclass
@@ -252,7 +252,7 @@  IMAGE_CMD:swu() {
                 if [ -f "$cpio_file" ]; then
                     # Set file timestamps for reproducible builds
                     if [ -n "${SOURCE_DATE_EPOCH}" ]; then
-                        touch -d@"${SOURCE_DATE_EPOCH}" "$file"
+                        touch -d@"${SOURCE_DATE_EPOCH}" "$cpio_file"
                     fi
                     case "$cpio_file" in
                         sw-description*)