diff mbox series

[isar-cip-core,v1,1/1] recipes-devtools/secure-boot-secrets: Resolve duplicate Provides in debian/control

Message ID 20240418101522.583817-2-kumar.rakesh@siemens.com (mailing list archive)
State Superseded
Headers show
Series recipes-devtools/secure-boot-secrets: Resolve duplicate Provides in debian/control | expand

Commit Message

Rakesh Kumar April 18, 2024, 10:15 a.m. UTC
Previously, the debian/control file contained a duplicate Provides line,
which caused a build failure ad below
| DEBUG: Executing shell function do_dpkg_source
| dpkg-source: error: syntax error in secure-boot-custmpk-0.1/debian/control at line 16:
| duplicate field Provides found

Use DEBIAN_PROVIDES to resolve the duplicate Provides problem to ensure
that the build process completes successfully.

Signed-off-by: Rakesh Kumar <kumar.rakesh@siemens.com>
---
 recipes-devtools/secure-boot-secrets/secure-boot-secrets.inc | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Arjunan, Srinu April 19, 2024, 5:32 a.m. UTC | #1
Please correct commit message , remove "ad", Moreover ISAR now supports the "DEBIAN_PROVIDES", why can't you directly use this variable to declare virtual packages to satisfy the dependencies.

Many thanks,
Srinu

-----Original Message-----
From: cip-dev@lists.cip-project.org <cip-dev@lists.cip-project.org> On Behalf Of Rakesh Kumar via lists.cip-project.org
Sent: 18 April 2024 15:45
To: cip-dev@lists.cip-project.org
Cc: Kumar, Rakesh (DI CTO FDS CES LX PBU RSOL 1) <kumar.rakesh@siemens.com>
Subject: [cip-dev] [isar-cip-core][PATCH v1 1/1] recipes-devtools/secure-boot-secrets: Resolve duplicate Provides in debian/control

Previously, the debian/control file contained a duplicate Provides line, which caused a build failure ad below
| DEBUG: Executing shell function do_dpkg_source
| dpkg-source: error: syntax error in secure-boot-custmpk-0.1/debian/control at line 16:
| duplicate field Provides found

Use DEBIAN_PROVIDES to resolve the duplicate Provides problem to ensure that the build process completes successfully.

Signed-off-by: Rakesh Kumar <kumar.rakesh@siemens.com>
---
 recipes-devtools/secure-boot-secrets/secure-boot-secrets.inc | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/recipes-devtools/secure-boot-secrets/secure-boot-secrets.inc b/recipes-devtools/secure-boot-secrets/secure-boot-secrets.inc
index 76233b3..559d295 100644
--- a/recipes-devtools/secure-boot-secrets/secure-boot-secrets.inc
+++ b/recipes-devtools/secure-boot-secrets/secure-boot-secrets.inc
@@ -12,6 +12,7 @@
 inherit dpkg-raw
 
 PROVIDES += "secure-boot-secrets"
+DEBIAN_PROVIDES = "${PROVIDES}"
 
 SB_KEY ??= ""
 SB_CERT ??= ""
@@ -29,6 +30,3 @@ do_install() {
     install -m 0700 ${WORKDIR}/${SB_CERT} ${TARGET}/secure-boot.pem  }
 
-do_prepare_build:append() {
-    echo "Provides: secure-boot-secrets" >> ${S}/debian/control
-}
--
2.39.2
diff mbox series

Patch

diff --git a/recipes-devtools/secure-boot-secrets/secure-boot-secrets.inc b/recipes-devtools/secure-boot-secrets/secure-boot-secrets.inc
index 76233b3..559d295 100644
--- a/recipes-devtools/secure-boot-secrets/secure-boot-secrets.inc
+++ b/recipes-devtools/secure-boot-secrets/secure-boot-secrets.inc
@@ -12,6 +12,7 @@ 
 inherit dpkg-raw
 
 PROVIDES += "secure-boot-secrets"
+DEBIAN_PROVIDES = "${PROVIDES}"
 
 SB_KEY ??= ""
 SB_CERT ??= ""
@@ -29,6 +30,3 @@  do_install() {
     install -m 0700 ${WORKDIR}/${SB_CERT} ${TARGET}/secure-boot.pem
 }
 
-do_prepare_build:append() {
-    echo "Provides: secure-boot-secrets" >> ${S}/debian/control
-}