[5.10.y-cip,21/31] Input: da9063 - use dev_err_probe()

Message ID	20240716082255.56551-22-biju.das.jz@bp.renesas.com (mailing list archive)
State	New
Headers	show Return-Path: <biju.das.jz@bp.renesas.com> ip: 210.160.252.172, mailfrom: biju.das.jz@bp.renesas.com) From: Biju Das <biju.das.jz@bp.renesas.com> To: cip-dev@lists.cip-project.org, Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>, Pavel Machek <pavel@denx.de> Cc: Biju Das <biju.das.jz@bp.renesas.com>, Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Subject: [PATCH 5.10.y-cip 21/31] Input: da9063 - use dev_err_probe() Date: Tue, 16 Jul 2024 09:22:32 +0100 Message-ID: <20240716082255.56551-22-biju.das.jz@bp.renesas.com> In-Reply-To: <20240716082255.56551-1-biju.das.jz@bp.renesas.com> References: <20240716082255.56551-1-biju.das.jz@bp.renesas.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
Series	Add PMIC DA9062 support \| expand [5.10.y-cip,00/31] Add PMIC DA9062 support [5.10.y-cip,01/31] mfd: core: Delete corresponding OF node entries from list on MFD removal [5.10.y-cip,02/31] mfd: da9xxx-core: Constify static struct resource [5.10.y-cip,03/31] mfd: da9062: Drop of_match_ptr from of_device_id table [5.10.y-cip,04/31] mfd: da9062: Simplify getting of_device_id match data [5.10.y-cip,05/31] mfd: da9062: Support SMBus and I2C mode [5.10.y-cip,06/31] mfd: da9061: Fix Failed to set Two-Wire Bus Mode. [5.10.y-cip,07/31] mfd: da9062: Use MFD_CELL_OF macro [5.10.y-cip,08/31] mfd: da9062: Remove IRQ requirement [5.10.y-cip,09/31] mfd: da9062: Simplify obtaining I2C match data [5.10.y-cip,10/31] rtc: da9063: Simplify bool comparison [5.10.y-cip,11/31] rtc: da9063: add as wakeup source [5.10.y-cip,12/31] rtc: da9063: Mark the alarm IRQ as a wake IRQ [5.10.y-cip,13/31] rtc: da9063: Make IRQ as optional [5.10.y-cip,14/31] rtc: da9063: Use device_get_match_data() [5.10.y-cip,15/31] rtc: da9063: Use dev_err_probe() [5.10.y-cip,16/31] pinctrl: Propagate firmware node from a parent device [5.10.y-cip,17/31] pinctrl: da9062: Add OF table [5.10.y-cip,18/31] Input: da9063 - add wakeup support [5.10.y-cip,19/31] Input: da9063 - simplify obtaining OF match data [5.10.y-cip,20/31] Input: da9063 - drop redundant prints in probe() [5.10.y-cip,21/31] Input: da9063 - use dev_err_probe() [5.10.y-cip,22/31] dt-bindings: mfd: Convert da9063 to yaml [5.10.y-cip,23/31] dt-bindings: watchdog: da9062-wdt: convert txt to yaml [5.10.y-cip,24/31] dt-bindings: mfd: da9062: Update watchdog description [5.10.y-cip,25/31] dt-bindings: mfd: dlg,da9063: Update watchdog child node [5.10.y-cip,26/31] dt-bindings: input: Convert da906{1,2,3} onkey to json-schema [5.10.y-cip,27/31] dt-bindings: thermal: Convert da906{1,2} thermal to json-schema [5.10.y-cip,28/31] dt-bindings: mfd: dlg,da9063: Sort child devices [5.10.y-cip,29/31] dt-bindings: mfd: dlg,da9063: Convert da9062 to json-schema [5.10.y-cip,30/31] arm64: dts: renesas: rzg2ul-smarc: Enable PMIC and built-in RTC, GPIO and ONKEY [5.10.y-cip,31/31] arm64: defconfig: Enable Renesas DA9062 PMIC

Message ID

20240716082255.56551-22-biju.das.jz@bp.renesas.com (mailing list archive)

State

New

Headers

From: Biju Das <biju.das.jz@bp.renesas.com>
To: cip-dev@lists.cip-project.org,
	Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>,
	Pavel Machek <pavel@denx.de>
Cc: Biju Das <biju.das.jz@bp.renesas.com>,
	Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: [PATCH 5.10.y-cip 21/31] Input: da9063 - use dev_err_probe()
Date: Tue, 16 Jul 2024 09:22:32 +0100
Message-ID: <20240716082255.56551-22-biju.das.jz@bp.renesas.com>
In-Reply-To: <20240716082255.56551-1-biju.das.jz@bp.renesas.com>
References: <20240716082255.56551-1-biju.das.jz@bp.renesas.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Series

Add PMIC DA9062 support | expand

Commit Message

Biju Das July 16, 2024, 8:22 a.m. UTC

commit c67f8a13be4e9ffc862c7f60ec97a799a1547486 upstream.

Replace dev_err()->dev_err_probe() to simplify probe().

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Link: https://lore.kernel.org/r/20231213214803.9931-4-biju.das.jz@bp.renesas.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
 drivers/input/misc/da9063_onkey.c | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/drivers/input/misc/da9063_onkey.c b/drivers/input/misc/da9063_onkey.c
index 5024703484e7..46539c53fb44 100644
--- a/drivers/input/misc/da9063_onkey.c
+++ b/drivers/input/misc/da9063_onkey.c
@@ -201,10 +201,9 @@  static int da9063_onkey_probe(struct platform_device *pdev)
 	onkey->dev = &pdev->dev;
 
 	onkey->regmap = dev_get_regmap(pdev->dev.parent, NULL);
-	if (!onkey->regmap) {
-		dev_err(&pdev->dev, "Parent regmap unavailable.\n");
-		return -ENXIO;
-	}
+	if (!onkey->regmap)
+		return dev_err_probe(&pdev->dev, -ENXIO,
+				     "Parent regmap unavailable.\n");
 
 	onkey->key_power = !of_property_read_bool(pdev->dev.of_node,
 						  "dlg,disable-key-power");
@@ -239,11 +238,9 @@  static int da9063_onkey_probe(struct platform_device *pdev)
 					  NULL, da9063_onkey_irq_handler,
 					  IRQF_TRIGGER_LOW | IRQF_ONESHOT,
 					  "ONKEY", onkey);
-	if (error) {
-		dev_err(&pdev->dev,
-			"Failed to request IRQ %d: %d\n", irq, error);
-		return error;
-	}
+	if (error)
+		return dev_err_probe(&pdev->dev, error,
+				     "Failed to allocate onkey IRQ\n");
 
 	error = dev_pm_set_wake_irq(&pdev->dev, irq);
 	if (error)

[5.10.y-cip,21/31] Input: da9063 - use dev_err_probe()

Commit Message

Patch