[6.1.y-cip,13/30] media: rzg2l-cru: Remove unnecessary shadowing of ret in rzg2l_csi2_s_stream()

From: Nathan Chancellor <nathan@kernel.org>

From: Nathan Chancellor <nathan@kernel.org>

commit 1aba7930c63ea57b4918dc61dcc315f451cec21e upstream.

Clang warns:

  drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c:445:7: error: variable 'ret' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
                  if (ret)
                      ^~~
  drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c:475:9: note: uninitialized use occurs here
          return ret;
                ^~~
  drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c:445:3: note: remove the 'if' if its condition is always false
                  if (ret)
                  ^~~~~~~~
  drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c:441:7: error: variable 'ret' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
                  if (ret)
                      ^~~
  drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c:475:9: note: uninitialized use occurs here
          return ret;
                ^~~
  drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c:441:3: note: remove the 'if' if its condition is always false
                  if (ret)
                  ^~~~~~~~
  drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c:431:9: note: initialize the variable 'ret' to silence this warning
          int ret;
                ^
                  = 0
  2 errors generated.

ret is unnecessarily shadowed, meaning the assignments to ret within the
first 'if (enable)' block are only applied to the inner scope, not the
outer one as intended. Remove the shadowing to fix the warnings and make
everything work correctly.

Link: https://github.com/ClangBuiltLinux/linux/issues/1764

Fixes: 51e8415e39a9 ("media: platform: Add Renesas RZ/G2L MIPI CSI-2 receiver driver")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
 drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c | 2 --
 1 file changed, 2 deletions(-)

Message ID	20240805164342.211857-14-biju.das.jz@bp.renesas.com (mailing list archive)
State	New
Headers	show Return-Path: <biju.das.jz@bp.renesas.com> ip: 210.160.252.171, mailfrom: biju.das.jz@bp.renesas.com) From: Biju Das <biju.das.jz@bp.renesas.com> To: cip-dev@lists.cip-project.org, Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>, Pavel Machek <pavel@denx.de> Cc: Biju Das <biju.das.jz@bp.renesas.com>, Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Subject: [PATCH 6.1.y-cip 13/30] media: rzg2l-cru: Remove unnecessary shadowing of ret in rzg2l_csi2_s_stream() Date: Mon, 5 Aug 2024 17:43:06 +0100 Message-ID: <20240805164342.211857-14-biju.das.jz@bp.renesas.com> In-Reply-To: <20240805164342.211857-1-biju.das.jz@bp.renesas.com> References: <20240805164342.211857-1-biju.das.jz@bp.renesas.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
Series	Add support for RZ/{G2L,G2LC,G2UL,V2L} Camera Data Receiving Unit \| expand [6.1.y-cip,00/30] Add support for RZ/{G2L,G2LC,G2UL,V2L} Camera Data Receiving Unit [6.1.y-cip,01/30] media: i2c: ov5645: Drop fetching the clk reference by name [6.1.y-cip,02/30] media: i2c: ov5645: Use runtime PM [6.1.y-cip,03/30] media: i2c: ov5645: Drop empty comment [6.1.y-cip,04/30] media: i2c: ov5645: Make sure to call PM functions [6.1.y-cip,05/30] media: i2c: ov5645: Call ov5645_entity_init_cfg() before registering the subdev [6.1.y-cip,06/30] media: i2c: ov5645: Remove software reset entry from ov5645_global_init_setting [6.1.y-cip,07/30] media: dt-bindings: Document Renesas RZ/G2L CSI-2 block [6.1.y-cip,08/30] media: dt-bindings: Document Renesas RZ/G2L CRU block [6.1.y-cip,09/30] clk: renesas: r9a07g044: Add clock and reset entries for CRU [6.1.y-cip,10/30] clk: renesas: r9a07g043: Add clock and reset entries for CRU [6.1.y-cip,11/30] media: platform: Add Renesas RZ/G2L MIPI CSI-2 receiver driver [6.1.y-cip,12/30] media: platform: Add Renesas RZ/G2L CRU driver [6.1.y-cip,13/30] media: rzg2l-cru: Remove unnecessary shadowing of ret in rzg2l_csi2_s_stream() [6.1.y-cip,14/30] media: platform: renesas: rzg2l-cru: Add missing documentation for image_conv_irq [6.1.y-cip,15/30] media: rzg2l-cru: Fix missing error code in rzg2l_cru_start_streaming_vq() [6.1.y-cip,16/30] media: rzg2l-cru: fix a test for timeout [6.1.y-cip,17/30] media: platform: rzg2l-cru: rzg2l-csi2: Switch to RUNTIME_PM_OPS() [6.1.y-cip,18/30] media: platform: rzg2l-cru: rzg2l-ip: Add delay after D-PHY reset [6.1.y-cip,19/30] media: platform: rzg2l-cru: rzg2l-video: Fix image processing initialization [6.1.y-cip,20/30] media: platform: rzg2l-cru: rzg2l-csi2: Restructure vclk handling [6.1.y-cip,21/30] media: platform: rzg2l-cru: rzg2l-video: Fix start reception procedure [6.1.y-cip,22/30] media: dt-bindings: renesas,rzg2l-csi2: Document Renesas RZ/G2UL CSI-2 block [6.1.y-cip,23/30] media: dt-bindings: renesas,rzg2l-cru: Document Renesas RZ/G2UL CRU block [6.1.y-cip,24/30] arm64: dts: renesas: r9a07g044: Add CSI and CRU nodes [6.1.y-cip,25/30] arm64: dts: renesas: r9a07g054: Add CSI and CRU nodes [6.1.y-cip,26/30] arm64: dts: renesas: r9a07g043u: Add CSI and CRU nodes [6.1.y-cip,27/30] arm64: dts: renesas: rzg2l-smarc: Enable CRU, CSI support [6.1.y-cip,28/30] arm64: dts: renesas: rzg2lc-smarc: Enable CRU, CSI support [6.1.y-cip,29/30] arm64: dts: renesas: rzg2ul-smarc: Enable CRU, CSI support [6.1.y-cip,30/30] arm64: defconfig: Enable RZ/G2L MIPI CSI-2 and CRU support

[6.1.y-cip,13/30] media: rzg2l-cru: Remove unnecessary shadowing of ret in rzg2l_csi2_s_stream()

Commit Message

Patch