[5.10.y-cip,12/27] media: rzg2l-cru: Remove unnecessary shadowing of ret in rzg2l_csi2_s_stream()

From: Nathan Chancellor <nathan@kernel.org>

From: Nathan Chancellor <nathan@kernel.org>

commit 1aba7930c63ea57b4918dc61dcc315f451cec21e upstream.

Clang warns:

  drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c:445:7: error: variable 'ret' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
                  if (ret)
                      ^~~
  drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c:475:9: note: uninitialized use occurs here
          return ret;
                ^~~
  drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c:445:3: note: remove the 'if' if its condition is always false
                  if (ret)
                  ^~~~~~~~
  drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c:441:7: error: variable 'ret' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
                  if (ret)
                      ^~~
  drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c:475:9: note: uninitialized use occurs here
          return ret;
                ^~~
  drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c:441:3: note: remove the 'if' if its condition is always false
                  if (ret)
                  ^~~~~~~~
  drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c:431:9: note: initialize the variable 'ret' to silence this warning
          int ret;
                ^
                  = 0
  2 errors generated.

ret is unnecessarily shadowed, meaning the assignments to ret within the
first 'if (enable)' block are only applied to the inner scope, not the
outer one as intended. Remove the shadowing to fix the warnings and make
everything work correctly.

Link: https://github.com/ClangBuiltLinux/linux/issues/1764

Fixes: 51e8415e39a9 ("media: platform: Add Renesas RZ/G2L MIPI CSI-2 receiver driver")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
 drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c | 2 --
 1 file changed, 2 deletions(-)

Message ID	20241028200349.9620-13-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive)
State	New
Headers	show Return-Path: <prabhakar.mahadev-lad.rj@bp.renesas.com> ip: 210.160.252.172, mailfrom: prabhakar.mahadev-lad.rj@bp.renesas.com) From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> To: cip-dev@lists.cip-project.org, Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>, Pavel Machek <pavel@denx.de> Cc: Biju Das <biju.das.jz@bp.renesas.com> Subject: [PATCH 5.10.y-cip 12/27] media: rzg2l-cru: Remove unnecessary shadowing of ret in rzg2l_csi2_s_stream() Date: Mon, 28 Oct 2024 20:03:34 +0000 Message-ID: <20241028200349.9620-13-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: <20241028200349.9620-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20241028200349.9620-1-prabhakar.mahadev-lad.rj@bp.renesas.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
Series	Add CRU and CSI support for Renesas RZ/G2L \| expand [5.10.y-cip,00/27] Add CRU and CSI support for Renesas RZ/G2L [5.10.y-cip,01/27] media: i2c: ov5645: Drop fetching the clk reference by name [5.10.y-cip,02/27] media: i2c: ov5645: Use runtime PM [5.10.y-cip,03/27] media: i2c: ov5645: Drop empty comment [5.10.y-cip,04/27] media: i2c: ov5645: Make sure to call PM functions [5.10.y-cip,05/27] media: i2c: ov5645: Call ov5645_entity_init_cfg() before registering the subdev [5.10.y-cip,06/27] media: i2c: ov5645: Remove software reset entry from ov5645_global_init_setting [5.10.y-cip,07/27] media: v4l: subdev: Add pre_streamon and post_streamoff callbacks [5.10.y-cip,08/27] media: dt-bindings: Document Renesas RZ/G2L CSI-2 block [5.10.y-cip,09/27] media: dt-bindings: Document Renesas RZ/G2L CRU block [5.10.y-cip,10/27] media: platform: Add Renesas RZ/G2L MIPI CSI-2 receiver driver [5.10.y-cip,11/27] media: platform: Add Renesas RZ/G2L CRU driver [5.10.y-cip,12/27] media: rzg2l-cru: Remove unnecessary shadowing of ret in rzg2l_csi2_s_stream() [5.10.y-cip,13/27] media: platform: renesas: rzg2l-cru: Add missing documentation for image_conv_irq [5.10.y-cip,14/27] media: rzg2l-cru: Fix missing error code in rzg2l_cru_start_streaming_vq() [5.10.y-cip,15/27] media: rzg2l-cru: fix a test for timeout [5.10.y-cip,16/27] media: rzg2l-cru: Remove unneeded semicolon [5.10.y-cip,17/27] media: platform: rzg2l-cru: rzg2l-csi2: Enclose the macro in parentheses [5.10.y-cip,18/27] media: platform: rzg2l-cru: rzg2l-csi2: Switch to RUNTIME_PM_OPS() [5.10.y-cip,19/27] media: platform: rzg2l-cru: rzg2l-ip: Add delay after D-PHY reset [5.10.y-cip,20/27] media: platform: rzg2l-cru: rzg2l-video: Fix image processing initialization [5.10.y-cip,21/27] media: platform: rzg2l-cru: rzg2l-csi2: Restructure vclk handling [5.10.y-cip,22/27] media: platform: rzg2l-cru: rzg2l-video: Fix start reception procedure [5.10.y-cip,23/27] media: platform: rzg2l-cru: rzg2l-csi2: Add missing MODULE_DEVICE_TABLE [5.10.y-cip,24/27] clk: renesas: r9a07g044: Add clock and reset entries for CRU [5.10.y-cip,25/27] arm64: dts: renesas: r9a07g044: Add CSI and CRU nodes [5.10.y-cip,26/27] arm64: dts: renesas: rzg2l-smarc: Enable CRU, CSI support [5.10.y-cip,27/27] arm64: defconfig: Enable RZ/G2L MIPI CSI-2 and CRU support

[5.10.y-cip,12/27] media: rzg2l-cru: Remove unnecessary shadowing of ret in rzg2l_csi2_s_stream()

Commit Message

Patch