From patchwork Wed Mar 19 10:16:25 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tommaso Merciai X-Patchwork-Id: 14022406 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63552C35FFA for ; Wed, 19 Mar 2025 10:17:20 +0000 (UTC) Received: from TY3P286CU002.outbound.protection.outlook.com (TY3P286CU002.outbound.protection.outlook.com [52.101.229.54]) by mx.groups.io with SMTP id smtpd.web10.4374.1742379431466284348 for ; Wed, 19 Mar 2025 03:17:11 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="dkim: body hash did not verify" header.i=@bp.renesas.com header.s=selector1 header.b=pD98obB7; spf=pass (domain: bp.renesas.com, ip: 52.101.229.54, mailfrom: tommaso.merciai.xr@bp.renesas.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=un/MDc4NiLkGH9flIZwC6amqOpfwE00eif/i3bNbDCgVxCuVkztOk0rbntpTDYSAJqKaNjd9ix5/elIG8EjXkm+a1PQB4+btYzZoYV7KuWdbYEAX7iYHExNhBjvVdRw0gua9I8oyQtMpFjg3kJs3ZcCGYyfqlcq1gxMIke9KFOF5K/PAAmy9WpPqpdQdimUkwT6Is49k72J2uiAGqCm7PDO7HJUc/xYPyUi2PUiBp9ZsEL7STXnN36FhieiIj2AXQHGJiFF+lyMwCwvw7DJLKPmEPnbfWEHkg5mnYbOu31YNjSnCsNT3feWZG6b32+dx6rbgDo/fOhKyR7MBly3Q9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EYwLB/9twWf1mS70Uh5RgkCW/kYuxcrXvN/pUYJe9rw=; b=tE+eiRGFkFDXfP1KxzyA8RIS6XHCYRJwi9kD0eUDUKAIF0PCAncerpafuExkmVrqe18tp9JistERyiZLQahonlDcjuTLu6aLa4OsleLzwQHxJIimC7SrYjzxQYTV4H8qUFFil/Lu+GX2Tfy7emCZfuTRPBZ1fizn03O3ZQ1Xni9VlPYuwH7M4Gd0Itt8uBWUOQot5ru7Zww7pfGdoYQu66R8VA0Ur0qOLqzF7sOnBTa+pFzNqSc21i3oVRzSQXCzhZikl9He2zmiNLGltCo/mBUyUHFNQRyXPsTyPY0JsNhDZk6W6/UKJiY8cYxtBoXxAosGVPMQ+2uWitlwg372vQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bp.renesas.com; dmarc=pass action=none header.from=bp.renesas.com; dkim=pass header.d=bp.renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bp.renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EYwLB/9twWf1mS70Uh5RgkCW/kYuxcrXvN/pUYJe9rw=; b=pD98obB7WUCegzXTJ3E2Qvr/9aG8PHVxn1yVWlYG4oHDan7PB1sCRhcA0BQG8QWdVyxrfJ2B2R3Iz48RgnW0vAnLUo59pUrhQDOnsozpyNB4vVG2brIPyXQwhsRLvEv0qulp1sA8oD87cCgnBIfWXC55CrccCbdHaxXEGNlGKWI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=bp.renesas.com; Received: from OS9PR01MB13950.jpnprd01.prod.outlook.com (2603:1096:604:35e::5) by TYRPR01MB12680.jpnprd01.prod.outlook.com (2603:1096:405:1b7::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.34; Wed, 19 Mar 2025 10:17:09 +0000 Received: from OS9PR01MB13950.jpnprd01.prod.outlook.com ([fe80::244d:8815:7064:a9f3]) by OS9PR01MB13950.jpnprd01.prod.outlook.com ([fe80::244d:8815:7064:a9f3%5]) with mapi id 15.20.8534.034; Wed, 19 Mar 2025 10:17:08 +0000 From: Tommaso Merciai To: cip-dev@lists.cip-project.org, Nobuhiro Iwamatsu , Pavel Machek CC: Biju Das , Lad Prabhakar , tomm.merciai@gmail.com Subject: [PATCH 6.1.y-cip v2 08/12] serial: sh-sci: Use plain struct copy in early_console_setup() Date: Wed, 19 Mar 2025 11:16:25 +0100 Message-ID: <20250319101629.2407727-9-tommaso.merciai.xr@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250319101629.2407727-1-tommaso.merciai.xr@bp.renesas.com> References: <20250319101629.2407727-1-tommaso.merciai.xr@bp.renesas.com> X-ClientProxiedBy: FR2P281CA0162.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:99::12) To OS9PR01MB13950.jpnprd01.prod.outlook.com (2603:1096:604:35e::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS9PR01MB13950:EE_|TYRPR01MB12680:EE_ X-MS-Office365-Filtering-Correlation-Id: f081f539-b47b-4789-8cd2-08dd66cf34df X-LD-Processed: 53d82571-da19-47e4-9cb4-625a166a4a2a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|52116014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: 1VyE+th5fUGx7nQzTkjLGORe2s8asE++i8/Vamnr9n7OK6jRDUOj8A5WRX4ST/wmZV5InpZ66NNuqEIOk3klWe0IKVeBQul3J27Y8ysjFNF9WM3xFsitKpsEhbaXNMRdgqKctI9CT6qZuHYLZdbxbva1XhQ1oCy7CTHSbY9nD+qHsERivINnwDhZqnK3FrN6nRgUjd9fwqTZ4rZp3q1v38AveFk8yaq+iNZJmwOre90yixyAMWXp1SkHYJBJsKP4wY4iEnxS5YUKd+J7FaFVv5HKAEuVTarQpgOdlcvyQtI5JGelQqUHaakt+wdKPo8K4KzUdvhj90Y1trGIoqFMsD3I+0MHS2hIVXYBPrayIXc/ZBkKKIjLJLj0K9A8njc0XyKIs3IsRG+grLgXFoFYqji6aW1ZmXoYKD4bMK0IqyVnWHAwLZQO4hs/QL6FlkNdcv+0CGvM07dmJDGzbIiC+lJIVLK3P4lOYUoZtIXs5xelpVNaMgP/Oqn99gfVZBve5/3gwuPAQi43QEQFPbyFhg1w1Y/SOdujNkFbu8t4J0DhBtdmQb4CGgY6JiN3I7/WJDOnV4c50PbwNjWCuy6+Eip69GjKxUZAvfraixU8xbWHhOlab9QLu8whjoqLgFJsEwLR/4u2LYv8615rQa/SwOCb9nl25y6P3u+/5Rrij/W1Zna9XSYGseqI2XpQ/2ROdAHT76IVjtP2Vy//7D7WJEuLoJGVGinHWvmcf1a2p29usHz+YWXPOKVW17Vzr+0nHG10mnevyELt+sHOecpUIMQtqHAJpCQv+2uAROD+0Ah5S7szILP+XXGoD2Jjf9x61gDKcBvrNbuasteJW8lEYOyQ+edyzLXBrDdz5QImsj0TJmT7yIE24dQJjenZckU/Qw/i9/PwO2tD8SlCttE3Jckwq5zXACP/KrRLl4Oy/05TXn4Z9ZAFihy2mEtSF53vE4bVZMRRj2jTVG8wNr5iw1d99v7BnvL3+PQSb0mJrLrBJnde7V010W7ZKk6n37T505ehuMbPsydZngipcQtT5RfcfpE/rKjStfK0Rhq9nKnTi1QzQ619k5azAibfVnqwR8jZDoMXdj5YMIyaE+mdRH6sk/Ge4yzTTwHQ4mWYOOhn6bCeEDdPNkMDIxn8lUEuKT8xM0jlbZN5A4Q1uVYRVdls/0+EX7+pxFzN+FoXYV+Qs4l0ZCfuphcmdDIZCqkmOxmrbgDKMRDDDJJuBomjgDo7vwfyHr92eiAuSvwTv/fb3EqsQXI8WMdrwHbOqykSeEDWZmn/bIi2fbLenVUgAdPI2MPLZSBQ3GNdgHekJZ3jF3h4TcEyL5qQhZAN6nqjJDdEocjWzJrTsHYgd2cYS+vh4OZZqj43OBYvlBgSTGFbGMKlhJ9UrwHfSDrPay530GZAtaABNN4I0mLSPBx8wFwznWYfY8xob7qVtSuXgzxegnRaBaoU/T3CrXjGQ3/g X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:OS9PR01MB13950.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(52116014)(366016)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: GcEvEbsfa9709mbDlMqOuulpImC9bLLSOjNGa8IhK5VKCWvTEr5/QZ9XKZ3aKlQeNWXWDauV5c7rddNHBolngjezGC3EpbnvnV4EelAK0gGx61RhAFCldhgg90gcANMDlW0aYEbyy0nPVK+MQMEtXbo276n+ljG4dhbNRuFKW8YBDP0556Ftby6+PLw7QwZQ2KW44TfdihJY5n4rdKR1uZywy/US+Cia7SIzrmRbQ8uKm/R2TtPwU57GXJmgT1SzLdEWyv3+VzhDbzrSOr8936fr25dY2XX8LchXFyT+RtpConq6Xzw5U/hKvgBDZgJKWTmWAvaK/99N6vDCpo81icf4d3ibLbbVPn2hvu5G9lwvW31AE1hiIkhAnNuH85uwBWX8yWqXY7rG6jT3QBpMfqW+lk60ET+Y8oIuwAaclwRHvbOKAgfmCmHBA7vxkooiAV17IOV4RNySmhIRNqHyLmrvcaH9Je8MVS+zLhFKjad9EOBT7GG9eye0pwBBfxgwmWKK+5ggIdWjD53gTZo26l8/8yAYhtdnOs1Zokt9EZYRFP3wCKrmouuQ/xqFhBX5M32oNkNVQPfZSsSrFtdiM/KZsR874j+QMVUdnCDYVCXBsBnKjcAZ2a9xqDcm+Br6HnkBX+9U5I7ExCOG5wyHbNg9ntTBcOxcNNc9Psv5UW8l1AebPwdNSp4TzjOUf74xVDo8mr4M4NQgJI4vv6YVsnmZgr66Od/UZUArZmBRYE80XNZoDqivizPl67nQ9nC4jlsRWoPSBVwKxiBTQxLjp1x/pA7hpTloz5UbcRg1mdG7Jl1Yk16mhegt95lrVws8jBqrzQYeelELdWO9Z9w78qmJCpxvg+Or2xrcI3U5hnBwnFSm8TJGF/z6KP4V4uBosWQnYD9Gp4lUDD3eD8OWjjPo25O9HYMClTfI2eEu0REvRthPhvvLC2ARxPPIpdzeEFANxt8OEPz8pzIamX1lW4SpnCVTk0z73oFUo4K7I6MWALFiklx3JLZ/j8gdBYwlibxkNtQgf2mQe++9LeUIXQp8lUPe3NkJOmmn8UH+xmQCCb7U9JXyxulnYgo0/8KvPXyQEhbin8SLbX8AFviwRV7yaDWCV6ECQeVCy4ZU7EG5nkJ8jA5DPnMOl8johBTw4cVz/zlcj+gsZLzFohkrHcFrQf8gmf8DwtgZ28uzJVXFwcwyaKLWF4dDscYEqY1hgDjsVDQEkN1CZ/P3Rkw45DrA263PazxvOJi8OMa5OfA7Z+1DzVpZ7If2932yFaI0HAdvvx6fQvPQ3r/wcAnFhUTd4h8XgfukSZCjrKP+j7ye2OxxlsCVpU+0268W4DQUESyy1wIR1rIp7CdtIWByCMNE5GCnSSjYEOTbhmd1ugvGPcBpFYUejOriGyEE6wyPQueMXIe2LxOPdAdBqFsqRYYAMPRGGEXFnSE2EIDgETnlZfq/9SRPPd3gUO6LgWRYskaxrGAEWhSvybsh2h29TVRyjN9ejAjOJjOLuz19AXm53H2l9rxKwH1oe74gcJScS0j8qoIKi0E82MVXkboWClRW30d99PFgdcr3dcbgUXvQn6gIDgks8LT+WdOTRPumI2qR615E9jaFamdJ7ocdKSshOyQFC9yzbYMXQ3tqgcM= X-OriginatorOrg: bp.renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: f081f539-b47b-4789-8cd2-08dd66cf34df X-MS-Exchange-CrossTenant-AuthSource: OS9PR01MB13950.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2025 10:17:08.9151 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6OmkadUQgndktg60rOomX5ZtB1wmKjmdmUiT/hnx67gReJqWeZMGl+sBVfE/g3TG4B8LF+UiWdhwkIYuvvhj9UqBGP9G3C6K0IOm1EhL7VLMa96xaStQadDklxmtzS0Z X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYRPR01MB12680 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Wed, 19 Mar 2025 10:17:20 -0000 X-Groupsio-URL: https://lists.cip-project.org/g/cip-dev/message/18269 From: Geert Uytterhoeven commit c1117a2fefbcce30cced3a180585e0adebc0fa89 upstream. Using memcpy() prevents the compiler from doing any checking on the types of the passed pointer parameters. Copy the structure using struct assignment instead, to increase type-safety. No change in generated code on all relevant architectures (arm/arm64/riscv/sh). Signed-off-by: Geert Uytterhoeven Reviewed-by: Lad Prabhakar Link: https://lore.kernel.org/r/e097e5c11afe5bd4c01135779c9a40e707ef6374.1733243287.git.geert+renesas@glider.be Signed-off-by: Greg Kroah-Hartman Signed-off-by: Tommaso Merciai --- Changes Since v1: - Added missing Signed-off-by drivers/tty/serial/sh-sci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c index ff69124e5336..d1140fec861b 100644 --- a/drivers/tty/serial/sh-sci.c +++ b/drivers/tty/serial/sh-sci.c @@ -3566,7 +3566,7 @@ static int __init early_console_setup(struct earlycon_device *device, device->port.serial_in = sci_serial_in; device->port.serial_out = sci_serial_out; device->port.type = type; - memcpy(&sci_ports[0].port, &device->port, sizeof(struct uart_port)); + sci_ports[0].port = device->port; port_cfg.type = type; sci_ports[0].cfg = &port_cfg; sci_ports[0].params = sci_probe_regmap(&port_cfg);