diff mbox series

[isar-cip-core] IEC_template.yml: Update IEC tests to latest revision

Message ID 20250327093358.3419546-1-Sai.Sathujoda@toshiba-tsip.com (mailing list archive)
State New
Headers show
Series [isar-cip-core] IEC_template.yml: Update IEC tests to latest revision | expand

Commit Message

Sai.Sathujoda@toshiba-tsip.com March 27, 2025, 9:33 a.m. UTC
From: sai ashrith sathujoda <sai.sathujoda@toshiba-tsip.com>

Major changes in this revision update:

1. Skip TC_CR2.7_1 until it is redesigned to remove dependencies on static time delays.
2. Improve tests to include testing of new IEC-62443-4-2 sub-requirements.
3. Fail the job if any failed test cases are found in final summary.

Signed-off-by: sai ashrith sathujoda <sai.sathujoda@toshiba-tsip.com>
---
 tests/templates/IEC_template.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jan Kiszka March 27, 2025, 11:32 a.m. UTC | #1
On 27.03.25 10:33, Sai.Sathujoda@toshiba-tsip.com wrote:
> From: sai ashrith sathujoda <sai.sathujoda@toshiba-tsip.com>
> 
> Major changes in this revision update:
> 
> 1. Skip TC_CR2.7_1 until it is redesigned to remove dependencies on static time delays.
> 2. Improve tests to include testing of new IEC-62443-4-2 sub-requirements.
> 3. Fail the job if any failed test cases are found in final summary.
> 
> Signed-off-by: sai ashrith sathujoda <sai.sathujoda@toshiba-tsip.com>
> ---
>  tests/templates/IEC_template.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/templates/IEC_template.yml b/tests/templates/IEC_template.yml
> index 3c33773..92944da 100644
> --- a/tests/templates/IEC_template.yml
> +++ b/tests/templates/IEC_template.yml
> @@ -64,7 +64,7 @@ actions:
>       definitions:
>       - repository: https://gitlab.com/cip-project/cip-testing/cip-security-tests.git
>         from: git
> -       revision: 064a92b98127b0001ca527a83b175521bea4b626
> +       revision: 5dbc47f55d4a43449dcbde4363e5d23d6e96344f
>         path: iec-security-tests/Singlenode-TestDefinition.yaml
>         name: Security-Testcases
>  

Thanks, applied. Let's watch the pipeline:
https://gitlab.com/cip-project/cip-core/isar-cip-core/-/pipelines/1738025966
:)

Jan
Jan Kiszka March 27, 2025, 4:27 p.m. UTC | #2
On 27.03.25 12:32, Jan Kiszka wrote:
> On 27.03.25 10:33, Sai.Sathujoda@toshiba-tsip.com wrote:
>> From: sai ashrith sathujoda <sai.sathujoda@toshiba-tsip.com>
>>
>> Major changes in this revision update:
>>
>> 1. Skip TC_CR2.7_1 until it is redesigned to remove dependencies on static time delays.
>> 2. Improve tests to include testing of new IEC-62443-4-2 sub-requirements.
>> 3. Fail the job if any failed test cases are found in final summary.
>>
>> Signed-off-by: sai ashrith sathujoda <sai.sathujoda@toshiba-tsip.com>
>> ---
>>  tests/templates/IEC_template.yml | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/templates/IEC_template.yml b/tests/templates/IEC_template.yml
>> index 3c33773..92944da 100644
>> --- a/tests/templates/IEC_template.yml
>> +++ b/tests/templates/IEC_template.yml
>> @@ -64,7 +64,7 @@ actions:
>>       definitions:
>>       - repository: https://gitlab.com/cip-project/cip-testing/cip-security-tests.git
>>         from: git
>> -       revision: 064a92b98127b0001ca527a83b175521bea4b626
>> +       revision: 5dbc47f55d4a43449dcbde4363e5d23d6e96344f
>>         path: iec-security-tests/Singlenode-TestDefinition.yaml
>>         name: Security-Testcases
>>  
> 
> Thanks, applied. Let's watch the pipeline:
> https://gitlab.com/cip-project/cip-core/isar-cip-core/-/pipelines/1738025966
> :)

2025-03-27T15:03:09 INFO: user: 'user3' created successfully
2025-03-27T15:03:09 
2025-03-27T15:03:09 runTest: TC_CR1.9_5: Strength of public key-based authentication - map authenticated identity to a user
2025-03-27T15:04:46 Marking unfinished test run as failed

Please have a look.

Jan
Sai.Sathujoda@toshiba-tsip.com March 27, 2025, 5:44 p.m. UTC | #3
Hi Jan,

This was neither an issue with the tests nor a problem with the image. The tests ran very slow that the overall time allotted (40 minutes) to run all the tests was crossed while it was still at 1.9_5.

That is the why the error is lave-test-shell timeout after 2400 seconds.

Thanks and regards,
Sai Ashrith
Jan Kiszka March 27, 2025, 7:24 p.m. UTC | #4
On 27.03.25 18:44, Sai.Sathujoda@toshiba-tsip.com wrote:
> Hi Jan,
> 
> This was neither an issue with the tests nor a problem with the image.
> The tests ran very slow that the overall time allotted (40 minutes) to
> run all the tests was crossed while it was still at 1.9_5.
> 
> That is the why the error is lave-test-shell timeout after 2400 seconds.

Ah, missed that. Your retry made it pass now, that's great. Let's see if
I can finalize the release soon.

Jan

> 
> Thanks and regards,
> Sai Ashrith
> 
> 
> ------------------------------------------------------------------------
> *From:* cip-dev@lists.cip-project.org <cip-dev@lists.cip-project.org> on
> behalf of Jan Kiszka via lists.cip-project.org
> <jan.kiszka=siemens.com@lists.cip-project.org>
> *Sent:* Thursday, March 27, 2025 9:57 PM
> *To:* ashrith sai(TSIP DITC_DIT-OST) <Sai.Sathujoda@toshiba-
> tsip.com>; cip-dev@lists.cip-project.org <cip-dev@lists.cip-project.org>
> *Cc:* dinesh kumar(TSIP DITC_DIT-OST) <dinesh.kumar@toshiba-
> tsip.com>; hayashi kazuhiro(林 和宏 DME ○DIG□MPS○MP4)
> <kazuhiro3.hayashi@toshiba.co.jp>
> *Subject:* Re: [cip-dev] [isar-cip-core] IEC_template.yml: Update IEC
> tests to latest revision
>  
> On 27.03.25 12:32, Jan Kiszka wrote:
>> On 27.03.25 10:33, Sai.Sathujoda@toshiba-tsip.com wrote:
>>> From: sai ashrith sathujoda <sai.sathujoda@toshiba-tsip.com>
>>>
>>> Major changes in this revision update:
>>>
>>> 1. Skip TC_CR2.7_1 until it is redesigned to remove dependencies on static time delays.
>>> 2. Improve tests to include testing of new IEC-62443-4-2 sub-requirements.
>>> 3. Fail the job if any failed test cases are found in final summary.
>>>
>>> Signed-off-by: sai ashrith sathujoda <sai.sathujoda@toshiba-tsip.com>
>>> ---
>>>  tests/templates/IEC_template.yml | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/tests/templates/IEC_template.yml b/tests/templates/IEC_template.yml
>>> index 3c33773..92944da 100644
>>> --- a/tests/templates/IEC_template.yml
>>> +++ b/tests/templates/IEC_template.yml
>>> @@ -64,7 +64,7 @@ actions:
>>>       definitions:
>>>       - repository: https://gitlab.com/cip-project/cip-testing/cip-security-tests.git
> <https://gitlab.com/cip-project/cip-testing/cip-security-tests.git>
>>>         from: git
>>> -       revision: 064a92b98127b0001ca527a83b175521bea4b626
>>> +       revision: 5dbc47f55d4a43449dcbde4363e5d23d6e96344f
>>>         path: iec-security-tests/Singlenode-TestDefinition.yaml
>>>         name: Security-Testcases
>>>  
>> 
>> Thanks, applied. Let's watch the pipeline:
>> https://gitlab.com/cip-project/cip-core/isar-cip-core/-/
> pipelines/1738025966 <https://gitlab.com/cip-project/cip-core/isar-cip-
> core/-/pipelines/1738025966>
>> :)
> 
> 2025-03-27T15:03:09 INFO: user: 'user3' created successfully
> 2025-03-27T15:03:09
> 2025-03-27T15:03:09 runTest: TC_CR1.9_5: Strength of public key-based
> authentication - map authenticated identity to a user
> 2025-03-27T15:04:46 Marking unfinished test run as failed
> 
> Please have a look.
> 
> Jan
> 
> -- 
> Siemens AG, Foundational Technologies
> Linux Expert Center
diff mbox series

Patch

diff --git a/tests/templates/IEC_template.yml b/tests/templates/IEC_template.yml
index 3c33773..92944da 100644
--- a/tests/templates/IEC_template.yml
+++ b/tests/templates/IEC_template.yml
@@ -64,7 +64,7 @@  actions:
      definitions:
      - repository: https://gitlab.com/cip-project/cip-testing/cip-security-tests.git
        from: git
-       revision: 064a92b98127b0001ca527a83b175521bea4b626
+       revision: 5dbc47f55d4a43449dcbde4363e5d23d6e96344f
        path: iec-security-tests/Singlenode-TestDefinition.yaml
        name: Security-Testcases