[0/2] service: Bifurcate 'complete_online_check' handling.

Message

Grant Erickson Nov. 18, 2023, 12:22 a.m. UTC

This bifurcates 'complete_online_check' closure handling into a
success and failure handler: 'handle_online_check_success' and
'handle_online_check_failure'.
    
Both at present and as the continuous online check mode (also known
as, 'EnableOnlineToReadyTransition') evolves, the closure handling of
online checks is both more tractable and easier to reason about when
partitioned into success and failures rather than co-mingling both
into the same function. Moreover, this simplifies
'complete_online_check' itself.

Grant Erickson (2):
  service: Bifurcate 'complete_online_check' handling.
  service: Document 'handle_online_check_{failure,success}'.

 src/service.c | 199 ++++++++++++++++++++++++++++++++++++++++++--------
 1 file changed, 168 insertions(+), 31 deletions(-)

Comments

Marcel Holtmann Nov. 23, 2023, 11:25 a.m. UTC | #1

Hi Grant,

> This bifurcates 'complete_online_check' closure handling into a
> success and failure handler: 'handle_online_check_success' and
> 'handle_online_check_failure'.
> 
> Both at present and as the continuous online check mode (also known
> as, 'EnableOnlineToReadyTransition') evolves, the closure handling of
> online checks is both more tractable and easier to reason about when
> partitioned into success and failures rather than co-mingling both
> into the same function. Moreover, this simplifies
> 'complete_online_check' itself.
> 
> Grant Erickson (2):
>  service: Bifurcate 'complete_online_check' handling.
>  service: Document 'handle_online_check_{failure,success}'.
> 
> src/service.c | 199 ++++++++++++++++++++++++++++++++++++++++++--------
> 1 file changed, 168 insertions(+), 31 deletions(-)

both patches have been applied.

Regards

Marcel