mbox series

[v2,0/3] connection: Introduce and Leverage IP Any / Unspecified Address String Constants and Functions

Message ID 20231129204156.1298225-1-gerickson@nuovations.com (mailing list archive)
Headers show
Series connection: Introduce and Leverage IP Any / Unspecified Address String Constants and Functions | expand

Message

Grant Erickson Nov. 29, 2023, 8:41 p.m. UTC
The IPv4 and IPv6 any / unspecified address string literals, "0.0.0.0"
and "::" respectively, and comparisons against them appear often
enough throughout the code where they warrant referencing through
file-scoped constants and introducing and leveraging introspection
functions to encapsulate the comparison patterns.

This introduces and uses such constants and 'is_ipv[46]_addr_any_str'
introspection functions to encapsulate these comparison patterns.

Grant Erickson (3):
  connection: Introduce and leverage 'ipv[46]_addr_any_str' constants.
  connection: Introduce and leverage 'is_ipv[46]_addr_any_str'
    functions.
  connection: Document 'is_ipv[46]_addr_any_str'.

 src/connection.c | 92 ++++++++++++++++++++++++++++++++++++++----------
 1 file changed, 73 insertions(+), 19 deletions(-)

Comments

Marcel Holtmann Dec. 7, 2023, 11:46 p.m. UTC | #1
Hi Grant,

> The IPv4 and IPv6 any / unspecified address string literals, "0.0.0.0"
> and "::" respectively, and comparisons against them appear often
> enough throughout the code where they warrant referencing through
> file-scoped constants and introducing and leveraging introspection
> functions to encapsulate the comparison patterns.
> 
> This introduces and uses such constants and 'is_ipv[46]_addr_any_str'
> introspection functions to encapsulate these comparison patterns.
> 
> Grant Erickson (3):
>  connection: Introduce and leverage 'ipv[46]_addr_any_str' constants.
>  connection: Introduce and leverage 'is_ipv[46]_addr_any_str'
>    functions.
>  connection: Document 'is_ipv[46]_addr_any_str'.
> 
> src/connection.c | 92 ++++++++++++++++++++++++++++++++++++++----------
> 1 file changed, 73 insertions(+), 19 deletions(-)

all 3 patches have been applied.

Regards

Marcel