diff mbox series

[v2] service: Make DBG in '__connman_service_ipconfig_indicate_state' consistent.

Message ID 20231117210514.699193-1-gerickson@nuovations.com (mailing list archive)
State Not Applicable, archived
Headers show
Series [v2] service: Make DBG in '__connman_service_ipconfig_indicate_state' consistent. | expand

Commit Message

Grant Erickson Nov. 17, 2023, 9:05 p.m. UTC 
This makes the DBG statement in '__connman_service_ipconfig_indicate_state'
consistent in format of 'service <service_pointer> (<service_name>) type
<ipconfig_type> (<ipconfig_type_name>)' with that of other DBG statements
in the module.

This makes at-a-glance, columnar correlation and comparison of service
activities easier.
---
 src/service.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Grant Erickson Nov. 24, 2023, 5:46 p.m. UTC | #1 
Any thoughts on this patch?

> On Nov 17, 2023, at 1:05 PM, Grant Erickson <gerickson@nuovations.com> wrote:
> 
> This makes the DBG statement in '__connman_service_ipconfig_indicate_state'
> consistent in format of 'service <service_pointer> (<service_name>) type
> <ipconfig_type> (<ipconfig_type_name>)' with that of other DBG statements
> in the module.
> 
> This makes at-a-glance, columnar correlation and comparison of service
> activities easier.
> ---
> src/service.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/service.c b/src/service.c
> index 81a1bebdc14b..a5aef1402933 100644
> --- a/src/service.c
> +++ b/src/service.c
> @@ -7126,11 +7126,11 @@ int __connman_service_ipconfig_indicate_state(struct connman_service *service,
> 	if (old_state == new_state)
> 		return -EALREADY;
> 
> -	DBG("service %p (%s) old state %d (%s) new state %d (%s) type %d (%s)",
> +	DBG("service %p (%s) type %d (%s) old state %d (%s) new state %d (%s)",
> 		service, connman_service_get_identifier(service),
> +		type, __connman_ipconfig_type2string(type),
> 		old_state, state2string(old_state),
> -		new_state, state2string(new_state),
> -		type, __connman_ipconfig_type2string(type));
> +		new_state, state2string(new_state));
> 
> 	switch (new_state) {
> 	case CONNMAN_SERVICE_STATE_UNKNOWN:
> -- 
> 2.42.0
> 
>
Marcel Holtmann Nov. 25, 2023, 4:22 p.m. UTC | #2 
Hi Grant,

> This makes the DBG statement in '__connman_service_ipconfig_indicate_state'
> consistent in format of 'service <service_pointer> (<service_name>) type
> <ipconfig_type> (<ipconfig_type_name>)' with that of other DBG statements
> in the module.
> 
> This makes at-a-glance, columnar correlation and comparison of service
> activities easier.
> ---
> src/service.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)

patch has been applied.

Regards

Marcel
Marcel Holtmann Nov. 25, 2023, 4:31 p.m. UTC | #3 
Hi Grant,

> Any thoughts on this patch?

it just got lost in my inbox :(

Patchwork is tracking patches now, but the commit-bot is not fully functional yet. Hopefully soon we have this all automated.

Regards

Marcel
diff mbox series

Patch

diff --git a/src/service.c b/src/service.c
index 81a1bebdc14b..a5aef1402933 100644
--- a/src/service.c
+++ b/src/service.c
@@ -7126,11 +7126,11 @@  int __connman_service_ipconfig_indicate_state(struct connman_service *service,
 	if (old_state == new_state)
 		return -EALREADY;
 
-	DBG("service %p (%s) old state %d (%s) new state %d (%s) type %d (%s)",
+	DBG("service %p (%s) type %d (%s) old state %d (%s) new state %d (%s)",
 		service, connman_service_get_identifier(service),
+		type, __connman_ipconfig_type2string(type),
 		old_state, state2string(old_state),
-		new_state, state2string(new_state),
-		type, __connman_ipconfig_type2string(type));
+		new_state, state2string(new_state));
 
 	switch (new_state) {
 	case CONNMAN_SERVICE_STATE_UNKNOWN: