| Message ID | 20240125215533.640304-2-denkenz@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/2] ofono: Remove support for CDMA | expand |
diff --git a/plugins/ofono.c b/plugins/ofono.c index 9d0d44547a2c..6b711b979046 100644 --- a/plugins/ofono.c +++ b/plugins/ofono.c @@ -1969,12 +1969,11 @@ static gboolean modem_changed(DBusConnection *conn, DBusMessage *message, dbus_bool_t powered; dbus_message_iter_get_basic(&value, &powered); - modem->powered = powered; DBG("%s Powered %d", modem->path, modem->powered); - /* Set the powered according to the value */ - modem_set_powered(modem, powered); + modem->powered = powered; + modem->set_powered = powered; } else if (g_str_equal(key, "Online")) { dbus_bool_t online;
When org.ofono.Modem.Powered property changes, connman invokes the SetProperty method again with the new value. This is pointless and only creates unnecessary DBus traffic. connmand[30]: plugins/ofono.c:modem_set_powered() /phonesim powered 1 connmand[30]: plugins/ofono.c:set_property() /phonesim path /phonesim org.ofono.Modem.Powered connmand[30]: plugins/ofono.c:set_property_reply() /phonesim path /phonesim org.ofono.Modem.Powered connmand[30]: plugins/ofono.c:modem_changed() /phonesim Powered 1 connmand[30]: plugins/ofono.c:modem_set_powered() /phonesim powered 1 connmand[30]: plugins/ofono.c:set_property() /phonesim path /phonesim org.ofono.Modem.Powered connmand[30]: plugins/ofono.c:set_property_reply() /phonesim path /phonesim org.ofono.Modem.Powered Fixes: 054dacc71c6a ("ofono: Set "powered" property according to value") --- plugins/ofono.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)