[STYLE,v1,0/3] Fixing check patch styling issues

Message

Raghu Halharvi April 19, 2023, 11:14 a.m. UTC

The following patches are cleanup or fixing the styling issues found
using checkpatch

In cxl/core/mbox.c, in case of null check failure, returning errno or
-ENOMEM in this case is good enough, removing the redundant dev_err
message.

In cxl/core/port.c, there is line of spaces in the definition which
violates checkpatch coding sytle, restructured the definition to use
tabs

In cxl/core/region.c, the else is not required after the return
statement, cleaned it up.

Verified the build and sanity by booting the guest VM using the freshly
built components.

Raghu H (3):
  cxl/mbox: remove redundant debug msg
  cxl/core/port: Use tabs to fix styling errors
  cxl/core/region:Remove else after return statement

 drivers/cxl/core/mbox.c   |  4 +---
 drivers/cxl/core/port.c   | 18 +++++++++---------
 drivers/cxl/core/region.c |  7 +++----
 3 files changed, 13 insertions(+), 16 deletions(-)

Comments

Alison Schofield April 27, 2023, 7:46 p.m. UTC | #1

On Wed, Apr 19, 2023 at 11:14:40AM +0000, Raghu H wrote:

Hi Raghu,

Thanks for the cleanup patches.
Sometime maintainers don't want cleanup, but these look good, and
hopefully they can get queued, after you send a v2.

I see Ira already commented to drop the tab reformatting, so drop
that in a v2 of this set.

I notice only 'me' in the 'To;' list here. The cover letter needs
to get the same maintainer list as your patches.

Each patches commit log (now 2 patches) should say 'Issue found with
checkpatch', or something similar. We like to know what tool to credit,
and like that to be in the git history/changelog, not just the cover
letter.

> The following patches are cleanup or fixing the styling issues found
> using checkpatch
> 
> In cxl/core/mbox.c, in case of null check failure, returning errno or
> -ENOMEM in this case is good enough, removing the redundant dev_err
> message.
> 
> In cxl/core/port.c, there is line of spaces in the definition which
> violates checkpatch coding sytle, restructured the definition to use
> tabs
> 
> In cxl/core/region.c, the else is not required after the return
> statement, cleaned it up.
> 
> Verified the build and sanity by booting the guest VM using the freshly
> built components.
> 
> Raghu H (3):
>   cxl/mbox: remove redundant debug msg
>   cxl/core/port: Use tabs to fix styling errors
>   cxl/core/region:Remove else after return statement

Assumes you are dropping the port changes.

Do this:

$git log --oneline mbox.c
$git log --oneline region.c

Your commit messages 'look' different than the existing message.
Please fix their formatting, in addition to the reword I mention
in patch 1 reply.

Thanks,
Alison

> 
>  drivers/cxl/core/mbox.c   |  4 +---
>  drivers/cxl/core/port.c   | 18 +++++++++---------
>  drivers/cxl/core/region.c |  7 +++----
>  3 files changed, 13 insertions(+), 16 deletions(-)
> 
> -- 
> 2.39.2
>