From patchwork Tue Jul 11 11:53:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Zhijian Li (Fujitsu)" X-Patchwork-Id: 13308466 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EF3BEB64DC for ; Tue, 11 Jul 2023 11:54:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229548AbjGKLyJ (ORCPT ); Tue, 11 Jul 2023 07:54:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229518AbjGKLyI (ORCPT ); Tue, 11 Jul 2023 07:54:08 -0400 Received: from esa6.hc1455-7.c3s2.iphmx.com (esa6.hc1455-7.c3s2.iphmx.com [68.232.139.139]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CB831704 for ; Tue, 11 Jul 2023 04:53:59 -0700 (PDT) X-IronPort-AV: E=McAfee;i="6600,9927,10767"; a="125409878" X-IronPort-AV: E=Sophos;i="6.01,196,1684767600"; d="scan'208";a="125409878" Received: from unknown (HELO oym-r3.gw.nic.fujitsu.com) ([210.162.30.91]) by esa6.hc1455-7.c3s2.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jul 2023 20:53:57 +0900 Received: from oym-m3.gw.nic.fujitsu.com (oym-nat-oym-m3.gw.nic.fujitsu.com [192.168.87.60]) by oym-r3.gw.nic.fujitsu.com (Postfix) with ESMTP id DD6AACA1E4 for ; Tue, 11 Jul 2023 20:53:54 +0900 (JST) Received: from kws-ab3.gw.nic.fujitsu.com (kws-ab3.gw.nic.fujitsu.com [192.51.206.21]) by oym-m3.gw.nic.fujitsu.com (Postfix) with ESMTP id E0426D9467 for ; Tue, 11 Jul 2023 20:53:53 +0900 (JST) Received: from localhost.localdomain (unknown [10.167.234.230]) by kws-ab3.gw.nic.fujitsu.com (Postfix) with ESMTP id 3C19D20077BB3; Tue, 11 Jul 2023 20:53:53 +0900 (JST) From: Li Zhijian To: nvdimm@lists.linux.dev, alison.schofield@intel.com Cc: linux-cxl@vger.kernel.org, Li Zhijian Subject: [ndctl PATCH v4 0/4] cxl/monitor and ndctl/monitor fixes Date: Tue, 11 Jul 2023 19:53:40 +0800 Message-Id: <20230711115344.562823-1-lizhijian@fujitsu.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-TM-AS-Product-Ver: IMSS-9.1.0.1417-9.0.0.1002-27744.006 X-TM-AS-User-Approved-Sender: Yes X-TMASE-Version: IMSS-9.1.0.1417-9.0.1002-27744.006 X-TMASE-Result: 10--12.270100-10.000000 X-TMASE-MatchedRID: abh1Ba7f5/Ck+AYa0R5ReDBgCmbnj9JmeQYwLifQh6TQarzCEH4/6k7O 1kmXN49bdZ+iOIKZPqKY2UnY8YSSrbyftOl1RBuHX9knSHW8uXVc8r3LfPzYa6CjQPEjtbB0KZQ /22HSWdWcrQThtVmcVoZ8hVKNlDAflrdKJAp7UJnkKCFOKwAEzEsY9G/RZ3FC33Nl3elSfsp9/A 4bJF/PM2y5fJhI8kWvsSi51GiVI1KUhduZoKKMKPSG/+sPtZVkZFW4zmF+QEJ2pfRE/ZIxx6m7P pyf7RSRu+U+TVUiqnWAMuqetGVetsgO3bswsOnS3QfwsVk0UbtuRXh7bFKB7nieVFIFjPpQZWJr lTtYkBpzCkjdA54NZSENpV1Zlh4KlExlQIQeRG0= X-TMASE-SNAP-Result: 1.821001.0001-0-1-22:0,33:0,34:0-0 Precedence: bulk List-ID: X-Mailing-List: linux-cxl@vger.kernel.org V4: - Add reviewed tags and minor fixes including comment style and changelog update - combine "cxl/monitor: use strcmp to compare the reserved word" and "ndctl/monitor: use strcmp to compare the reserved word" to one patch - Drop "cxl/monitor: always log started message" which would break a json output. V3: - update comit log of patch3 and patch6 per Dave's comments. V2: - exchange order of previous patch1 and patch2 - add reviewed tag in patch5 - commit log improvements It mainly fix monitor not working when log file is specified. For example $ cxl monitor -l ./cxl-monitor.log It seems that someone missed something at the begining. Furture, it compares the filename with reserved word more accurately patch1-2: It re-enables logfile(including default_log) functionality and simplify the sanity check in the combination relative path file and daemon mode. patch3 and patch6 change strncmp to strcmp to compare the acurrate reserved words. *** BLURB HERE *** Li Zhijian (4): cxl/monitor: Enable default_log and refactor sanity check cxl/monitor: replace monitor.log_file with monitor.ctx.log_file ndctl: use strcmp for reserved word in monitor commands Documentation/cxl/cxl-monitor.txt: Fix inaccurate description Documentation/cxl/cxl-monitor.txt | 3 +-- cxl/monitor.c | 43 ++++++++++++++++--------------- ndctl/monitor.c | 4 +-- 3 files changed, 25 insertions(+), 25 deletions(-)