[ndctl,v3,0/2] add support for Set Alert Configuration mailbox command

Message

Jehoon Park Sept. 18, 2023, 4:55 a.m. UTC

CXL 3.0 Spec 8.2.9.8.3.3 defines Set Alert Configuration mailbox command,
which configures device's warning alerts.
This patchset adds support for the command.

The implementation is based on the 'ndctl-inject-smart'. Variable and function
names are aligned with the implementation of 'Get Alert Configuration'.

Changes in v3
- Reorganize cover letter and commit message (Davidlohr)
- Update details of the example in man page
- Move 'verbose' option to the end in man page (Davidlohr)
- Link to v2: https://lore.kernel.org/r/[e-mail]

Changes in v2
- Rebase on the latest pending branch
- Remove full usage text in the commit message (Vishal)
- Correct texts in document and log_info() (Vishal)
- Change strncmp() to strcmp() for parsing params (Vishal)
- Link to v1: https://lore.kernel.org/r/[e-mail]

*** BLURB HERE ***

Jehoon Park (2):
  libcxl: add support for Set Alert Configuration mailbox command
  cxl: add 'set-alert-config' command to cxl tool

 Documentation/cxl/cxl-set-alert-config.txt | 152 ++++++++++++++
 Documentation/cxl/lib/libcxl.txt           |   1 +
 Documentation/cxl/meson.build              |   1 +
 cxl/builtin.h                              |   1 +
 cxl/cxl.c                                  |   1 +
 cxl/lib/libcxl.c                           |  21 ++
 cxl/lib/libcxl.sym                         |  12 ++
 cxl/lib/private.h                          |  12 ++
 cxl/libcxl.h                               |  16 ++
 cxl/memdev.c                               | 220 ++++++++++++++++++++-
 10 files changed, 436 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/cxl/cxl-set-alert-config.txt


base-commit: 1db7dfb0bd1b14baffc7c6ac44ace9046d98a00d

Comments

Davidlohr Bueso Oct. 10, 2023, 3:14 a.m. UTC | #1

On Mon, 18 Sep 2023, Jehoon Park wrote:

>CXL 3.0 Spec 8.2.9.8.3.3 defines Set Alert Configuration mailbox command,
>which configures device's warning alerts.
>This patchset adds support for the command.
>
>The implementation is based on the 'ndctl-inject-smart'. Variable and function
>names are aligned with the implementation of 'Get Alert Configuration'.
>
>Changes in v3
>- Reorganize cover letter and commit message (Davidlohr)
>- Update details of the example in man page
>- Move 'verbose' option to the end in man page (Davidlohr)
>- Link to v2: https://lore.kernel.org/r/[e-mail]
>
>Changes in v2
>- Rebase on the latest pending branch
>- Remove full usage text in the commit message (Vishal)
>- Correct texts in document and log_info() (Vishal)
>- Change strncmp() to strcmp() for parsing params (Vishal)
>- Link to v1: https://lore.kernel.org/r/[e-mail]
>
>*** BLURB HERE ***
>
>Jehoon Park (2):
>  libcxl: add support for Set Alert Configuration mailbox command
>  cxl: add 'set-alert-config' command to cxl tool

Looks good, for the series feel free to add:

Reviewed-by: Davidlohr Bueso <[e-mail]>