mbox series

[0/2,v3] Add cond_guard() to conditional guards

Message ID 20240206121301.7225-1-fabio.maria.de.francesco@linux.intel.com
Headers show
Series Add cond_guard() to conditional guards | expand

Message

Fabio M. De Francesco Feb. 6, 2024, 12:12 p.m. UTC 
Add cond_guard() macro to conditional guards and use it to replace an
open-coded up_read() in show_targetN() and remove a block marked by an
'out' label.

Cc: Dave Jiang <dave.jiang@intel.com>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Suggested-by: Dan Williams <dan.j.williams@intel.com>
Suggested-by: Ira Weiny <ira.weiny@intel.com>
Signed-off-by: Fabio M. De Francesco <fabio.maria.de.francesco@linux.intel.com>
---

Changes from RFC v4:
        Changed the interface of cond_guard() to take a variable to store
        a return code, the succes code and failure code, to enable a
        later check of the returned code in that variable.
Changes from RFC v5:
        Changed the interface of cond_guard() to take a statement or 
	statement-expression as its second argument to conform to Dan's 
	suggestion (thanks).
Changes from v1:
        Fixed a grammar error in the commit message of 1/2; replaced the
        name of the second argument of cond_guard() with '_fail'
        according to Jonathan's comments (thanks). 
Changes from v2:
	Changed macro's implementation to add an 'else' to protect
	against it being used incorrectly within another if() block.
	Suggested by Dan (thanks). The Reviewed-by tags on 1/2 are not
	forwarded because the implementation of cond_guard() has changed.
	Removed a redundant 'else' from show_targetN() in 2/2.

Fabio M. De Francesco (2):
  cleanup: Add cond_guard() to conditional guards
  cxl/region: Use cond_guard() in show_targetN()

 drivers/cxl/core/region.c | 16 ++++------------
 include/linux/cleanup.h   | 15 +++++++++++++++
 2 files changed, 19 insertions(+), 12 deletions(-)