[v5,00/13] Enabling DCD emulation support in Qemu

Message

Fan Ni March 4, 2024, 7:33 p.m. UTC

From: Fan Ni <[e-mail]>

The code is rebased on mainstream QEMU with the following patch series:
hw/cxl/mailbox: change CCI cmd set structure to be a member, not a reference
hw/cxl/mailbox: interface to add CCI commands to an existing CCI

v4->v5:
1. Did spell check for the patchset and fixed 2 typos;
2. Fixed a misuse of stq_le_p and replaced it with stl_le_p in
   cmd_dcd_get_dyn_cap_config;
3. Removed unnecessary switch case in patch 9;
4. Capitalized ""opcode" to "Opcode" in two code comments;
5. Updated one reference text to the spec;
6. Minor text change in qapi/cxl.json.
7. Removed the definition of CXL_SPEC_AFTER_R30
8. Removed the unnecessary input and output mailbox payload struct type
   definition;
9. set num_extents_supported and num_extents_avaible based on extents;
10. Renamed DCD_MAX_REGION_NUM to DCD_MAX_NUM_REGION;
11. Updated the commit log in Patch 4 to remove the unwanted text;
12. Fixed some indent issues;
13. Fail removal if it causes extents overflow after removal;
14. Capture cases when adding response causing the device to exceed its extent
    tracking ability;
15. Using memory_region_size instead of directly accessing the field in
    cxl_create_dc_regions;
16. Renamed DCDRegion as DCRegion;

Changes 1-5 are suggested by Wonjae Lee ([e-mail]), 
Changes 6-14 are suggested by Jonathan.
Changes 15-16 are suggested by Jorgen.

Thanks for the review of v4.

For this version, the main code changes (PATCH 11~12) extend DC extent
release processing, including mailbox command and QMP interface processing.

Based on Jonathan's suggestion, we updated the code, and now we can process
extent release request more flexible. We can now support superset release
(actually we can do even more, as long as the DPA range is covered by
accepted extents, we can release).

For superset extent release, the only requirement, if we find part of its DPA
range is still pending to add, while the other is accepted, we reject it
through QMP interface.

Last but not least, in the series, we introduced a new patch (PATCH 13),
which We introduce new QMP interfaces to print out accepted and
pending-to-add list in the device to a file.

The latest code branch is https://github.com/moking/qemu/tree/dcd-v5.

The code is tested with Ira's last kernel DCD patch set [2] with some minor
bug fixes[3]. Tested operations include:

Extra extent release test,
1. Add multiple extents, and removing them one by one, passed;
2. Superset release: add multiple extents with continuous DPA ranges, and
   Remove all of them with a single extent request with extent covering the
   whole DPA range, passed;
3. Partial extent release: add a large extent and release only part of it,
   passed;
4. Partial+superset release: add multiple extents,and release it with some
   leftover with one request with an extent. For example, add extents [0-128M]
   and [128-256], release [64M-256M], passed;
5. release extent not aligned to block size, failed as expected;
6. extents have overlaps, fail the request as expected;
7. extent has uncovered DPA range, skip the extent as expected; 
8. OS tries to release a non-exist extent, return invalid PA as expected;
 
[1] v4: https://lore.kernel.org/linux-cxl/[e-mail]/T/#m580c59be5deca2639dd7158e57f4bc1141d1c885
[2] https://github.com/weiny2/linux-kernel/tree/dcd-v3-2023-10-30
[3] https://github.com/moking/linux-dcd/commit/9d24fa6e5d39f934623220953caecc080f93e964

Fan Ni (13):
  hw/cxl/cxl-mailbox-utils: Add dc_event_log_size field to output
    payload of identify memory device command
  hw/cxl/cxl-mailbox-utils: Add dynamic capacity region representative
    and mailbox command support
  include/hw/cxl/cxl_device: Rename mem_size as static_mem_size for
    type3 memory devices
  hw/mem/cxl_type3: Add support to create DC regions to type3 memory
    devices
  hw/mem/cxl-type3: Refactor ct3_build_cdat_entries_for_mr to take mr
    size insead of mr as argument
  hw/mem/cxl_type3: Add host backend and address space handling for DC
    regions
  hw/mem/cxl_type3: Add DC extent list representative and get DC extent
    list mailbox support
  hw/cxl/cxl-mailbox-utils: Add mailbox commands to support add/release
    dynamic capacity response
  hw/cxl/events: Add qmp interfaces to add/release dynamic capacity
    extents
  hw/mem/cxl_type3: Add dpa range validation for accesses to DC regions
  hw/cxl/cxl-mailbox-utils: Add partial and superset extent release
    mailbox support
  hw/mem/cxl_type3: Allow to release partial extent and extent superset
    in QMP interface
  qapi/cxl.json: Add QMP interfaces to print out accepted and pending DC
    extents

 hw/cxl/cxl-mailbox-utils.c  | 682 ++++++++++++++++++++++++++++++++-
 hw/mem/cxl_type3.c          | 724 ++++++++++++++++++++++++++++++++++--
 hw/mem/cxl_type3_stubs.c    |  26 ++
 include/hw/cxl/cxl_device.h |  61 ++-
 include/hw/cxl/cxl_events.h |  18 +
 qapi/cxl.json               |  93 ++++-
 6 files changed, 1558 insertions(+), 46 deletions(-)