mbox series

[ndctl,v3,0/9] ndctl: Dynamic Capacity additions for cxl-cli

Message ID 20241115-dcd-region2-v3-0-326cd4e34dcd@intel.com
Headers show
Series ndctl: Dynamic Capacity additions for cxl-cli | expand

Message

Ira Weiny Nov. 15, 2024, 6:40 p.m. UTC
Feedback from v2 lead to the realization that cxl-cli required changes
to address the region mode vs decoder mode difference properly.

While v2 separated these modes they were not sufficiently separated in
the user interface of create-region.  This has been corrected in this
version.  Specifically a new option has been added to cxl create-region.
The option requires a decoder mode (DC partition) when the region type
is 'dc'.  The option is ignored, and can be omitted, for ram and pmem
regions.

Other libcxl API changes were made to simplify the interface a bit.

Documentation was added both at the libcxl and cxl-cli levels.

cxl-dcd.sh was cleaned up quite a bit an enhanced.

https://github.com/weiny2/ndctl/tree/dcd-region2-2024-11-15

CXL Dynamic Capacity Device (DCD) support is close to landing in the
upstream kernel.  cxl-cli requires modifications to interact with those
devices.  This includes creating and operating on DCD regions.
cxl-testing allows for quick regression testing as well as helping to
design the cxl-cli interfaces.

Add preliminary patches with some fixes.  Update libcxl, cxl-cli and
cxl-test with DCD support.

Signed-off-by: Ira Weiny <ira.weiny@intel.com>
---
Major changes in v3:
- [djiang: rework test script for clarity]
- [Alison: split patches between libcxl changes and cli changes]
- [Alison: fix lib symbol versioning]
- [iweiny: clarify region vs decoder mode with API to specify the
  decoder mode]
- Link to v2: https://patch.msgid.link/20241104-dcd-region2-v2-0-be057b479eeb@intel.com

---
Ira Weiny (7):
      ndctl/cxl-events: Don't fail test until event counts are reported
      ndctl/cxl/region: Report max size for region creation
      libcxl: Separate region mode from decoder mode
      cxl/region: Use new region mode in cxl-cli
      libcxl: Add extent functionality to DC regions
      cxl/region: Add extent output to region query
      cxl/test: Add Dynamic Capacity tests

Navneet Singh (2):
      libcxl: Add Dynamic Capacity region support
      cxl/region: Add cxl-cli support for DCD regions

 Documentation/cxl/cxl-create-region.txt |  11 +-
 Documentation/cxl/cxl-list.txt          |  29 ++
 Documentation/cxl/lib/libcxl.txt        |  62 ++-
 cxl/filter.h                            |   3 +
 cxl/json.c                              |  80 ++-
 cxl/json.h                              |   3 +
 cxl/lib/libcxl.c                        | 261 +++++++++-
 cxl/lib/libcxl.sym                      |  13 +
 cxl/lib/private.h                       |  17 +-
 cxl/libcxl.h                            |  96 +++-
 cxl/list.c                              |   3 +
 cxl/memdev.c                            |   4 +-
 cxl/region.c                            |  93 +++-
 test/cxl-dcd.sh                         | 879 ++++++++++++++++++++++++++++++++
 test/cxl-events.sh                      |   8 +-
 test/meson.build                        |   2 +
 util/json.h                             |   1 +
 17 files changed, 1519 insertions(+), 46 deletions(-)
---
base-commit: 04815e5f8b87e02a4fb5a61aeebaa5cad25a15c3
change-id: 20241030-dcd-region2-2d0149eb8efd

Best regards,

Comments

Ira Weiny Nov. 15, 2024, 6:49 p.m. UTC | #1
Please ignore.  smtp failed after only sending patch 5/9.  This series was
resent correctly it's entirety here:

https://lore.kernel.org/all/20241115-dcd-region2-v3-0-585d480ccdab@intel.com/

Apologies,
Ira



Ira Weiny wrote:
> Feedback from v2 lead to the realization that cxl-cli required changes
> to address the region mode vs decoder mode difference properly.
> 
> While v2 separated these modes they were not sufficiently separated in
> the user interface of create-region.  This has been corrected in this
> version.  Specifically a new option has been added to cxl create-region.
> The option requires a decoder mode (DC partition) when the region type
> is 'dc'.  The option is ignored, and can be omitted, for ram and pmem
> regions.
> 
> Other libcxl API changes were made to simplify the interface a bit.
> 
> Documentation was added both at the libcxl and cxl-cli levels.
> 
> cxl-dcd.sh was cleaned up quite a bit an enhanced.
> 
> https://github.com/weiny2/ndctl/tree/dcd-region2-2024-11-15
> 
> CXL Dynamic Capacity Device (DCD) support is close to landing in the
> upstream kernel.  cxl-cli requires modifications to interact with those
> devices.  This includes creating and operating on DCD regions.
> cxl-testing allows for quick regression testing as well as helping to
> design the cxl-cli interfaces.
> 
> Add preliminary patches with some fixes.  Update libcxl, cxl-cli and
> cxl-test with DCD support.
> 
> Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> ---
> Major changes in v3:
> - [djiang: rework test script for clarity]
> - [Alison: split patches between libcxl changes and cli changes]
> - [Alison: fix lib symbol versioning]
> - [iweiny: clarify region vs decoder mode with API to specify the
>   decoder mode]
> - Link to v2: https://patch.msgid.link/20241104-dcd-region2-v2-0-be057b479eeb@intel.com
> 
> ---
> Ira Weiny (7):
>       ndctl/cxl-events: Don't fail test until event counts are reported
>       ndctl/cxl/region: Report max size for region creation
>       libcxl: Separate region mode from decoder mode
>       cxl/region: Use new region mode in cxl-cli
>       libcxl: Add extent functionality to DC regions
>       cxl/region: Add extent output to region query
>       cxl/test: Add Dynamic Capacity tests
> 
> Navneet Singh (2):
>       libcxl: Add Dynamic Capacity region support
>       cxl/region: Add cxl-cli support for DCD regions
> 
>  Documentation/cxl/cxl-create-region.txt |  11 +-
>  Documentation/cxl/cxl-list.txt          |  29 ++
>  Documentation/cxl/lib/libcxl.txt        |  62 ++-
>  cxl/filter.h                            |   3 +
>  cxl/json.c                              |  80 ++-
>  cxl/json.h                              |   3 +
>  cxl/lib/libcxl.c                        | 261 +++++++++-
>  cxl/lib/libcxl.sym                      |  13 +
>  cxl/lib/private.h                       |  17 +-
>  cxl/libcxl.h                            |  96 +++-
>  cxl/list.c                              |   3 +
>  cxl/memdev.c                            |   4 +-
>  cxl/region.c                            |  93 +++-
>  test/cxl-dcd.sh                         | 879 ++++++++++++++++++++++++++++++++
>  test/cxl-events.sh                      |   8 +-
>  test/meson.build                        |   2 +
>  util/json.h                             |   1 +
>  17 files changed, 1519 insertions(+), 46 deletions(-)
> ---
> base-commit: 04815e5f8b87e02a4fb5a61aeebaa5cad25a15c3
> change-id: 20241030-dcd-region2-2d0149eb8efd
> 
> Best regards,
> -- 
> Ira Weiny <ira.weiny@intel.com>
>