| Message ID | 166077131892.1743055.1029132844466334751.stgit@djiang5-desk4.jf.intel.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add sanity check for interleave setup | expand |
On Wed, 17 Aug 2022 14:21:58 -0700 Dave Jiang <dave.jiang@intel.com> wrote: > Both cxl/port.c and cxl/core/port.c have cxl_port_attribute_groups. Change > cxl_port_attribute_groups in cxl/port.c to cxl_port_dynamic_attr_groups in > order to avoid confusion. > > Suggested-by: Dan Williams <dan.j.williams@intel.com> > Signed-off-by: Dave Jiang <dave.jiang@intel.com> Fair enough I guess. Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > --- > drivers/cxl/port.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/cxl/port.c b/drivers/cxl/port.c > index 5453771bf330..c4aa073b7e31 100644 > --- a/drivers/cxl/port.c > +++ b/drivers/cxl/port.c > @@ -123,7 +123,7 @@ static struct attribute_group cxl_cdat_attribute_group = { > .is_bin_visible = cxl_port_bin_attr_is_visible, > }; > > -static const struct attribute_group *cxl_port_attribute_groups[] = { > +static const struct attribute_group *cxl_port_dynamic_attr_groups[] = { > &cxl_cdat_attribute_group, > NULL, > }; > @@ -133,7 +133,7 @@ static struct cxl_driver cxl_port_driver = { > .probe = cxl_port_probe, > .id = CXL_DEVICE_PORT, > .drv = { > - .dev_groups = cxl_port_attribute_groups, > + .dev_groups = cxl_port_dynamic_attr_groups, > }, > }; > > >
diff --git a/drivers/cxl/port.c b/drivers/cxl/port.c index 5453771bf330..c4aa073b7e31 100644 --- a/drivers/cxl/port.c +++ b/drivers/cxl/port.c @@ -123,7 +123,7 @@ static struct attribute_group cxl_cdat_attribute_group = { .is_bin_visible = cxl_port_bin_attr_is_visible, }; -static const struct attribute_group *cxl_port_attribute_groups[] = { +static const struct attribute_group *cxl_port_dynamic_attr_groups[] = { &cxl_cdat_attribute_group, NULL, }; @@ -133,7 +133,7 @@ static struct cxl_driver cxl_port_driver = { .probe = cxl_port_probe, .id = CXL_DEVICE_PORT, .drv = { - .dev_groups = cxl_port_attribute_groups, + .dev_groups = cxl_port_dynamic_attr_groups, }, };
Both cxl/port.c and cxl/core/port.c have cxl_port_attribute_groups. Change cxl_port_attribute_groups in cxl/port.c to cxl_port_dynamic_attr_groups in order to avoid confusion. Suggested-by: Dan Williams <dan.j.williams@intel.com> Signed-off-by: Dave Jiang <dave.jiang@intel.com> --- drivers/cxl/port.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)