diff mbox series

[4/7] tools/testing/cxl: Fix some error exits

Message ID 166752184255.947915.16163477849330181425.stgit@dwillia2-xfh.jf.intel.com
State Accepted
Commit 49e857789f28931f987914fb69aa02a14bf1ea57
Headers show
Series CXL region creation fixes for 6.1 | expand

Commit Message

Dan Williams Nov. 4, 2022, 12:30 a.m. UTC 
Fix a few typos where 'goto err_port' was used rather than the object
specific cleanup.

Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
 tools/testing/cxl/test/cxl.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Verma, Vishal L Nov. 4, 2022, 5:57 a.m. UTC | #1 
On Thu, 2022-11-03 at 17:30 -0700, Dan Williams wrote:
> Fix a few typos where 'goto err_port' was used rather than the object
> specific cleanup.
> 
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
>  tools/testing/cxl/test/cxl.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Looks good,

Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>

> 
> diff --git a/tools/testing/cxl/test/cxl.c b/tools/testing/cxl/test/cxl.c
> index a072b2d3e726..133e4c73d370 100644
> --- a/tools/testing/cxl/test/cxl.c
> +++ b/tools/testing/cxl/test/cxl.c
> @@ -695,7 +695,7 @@ static __init int cxl_test_init(void)
>  
>                 pdev = platform_device_alloc("cxl_switch_uport", i);
>                 if (!pdev)
> -                       goto err_port;
> +                       goto err_uport;
>                 pdev->dev.parent = &root_port->dev;
>  
>                 rc = platform_device_add(pdev);
> @@ -713,7 +713,7 @@ static __init int cxl_test_init(void)
>  
>                 pdev = platform_device_alloc("cxl_switch_dport", i);
>                 if (!pdev)
> -                       goto err_port;
> +                       goto err_dport;
>                 pdev->dev.parent = &uport->dev;
>  
>                 rc = platform_device_add(pdev);
>
Dave Jiang Nov. 4, 2022, 9:43 p.m. UTC | #2 
On 11/3/2022 5:30 PM, Dan Williams wrote:
> Fix a few typos where 'goto err_port' was used rather than the object
> specific cleanup.
> 
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>

Reviewed-by: Dave Jiang <dave.jiang@intel.com>

> ---
>   tools/testing/cxl/test/cxl.c |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/cxl/test/cxl.c b/tools/testing/cxl/test/cxl.c
> index a072b2d3e726..133e4c73d370 100644
> --- a/tools/testing/cxl/test/cxl.c
> +++ b/tools/testing/cxl/test/cxl.c
> @@ -695,7 +695,7 @@ static __init int cxl_test_init(void)
>   
>   		pdev = platform_device_alloc("cxl_switch_uport", i);
>   		if (!pdev)
> -			goto err_port;
> +			goto err_uport;
>   		pdev->dev.parent = &root_port->dev;
>   
>   		rc = platform_device_add(pdev);
> @@ -713,7 +713,7 @@ static __init int cxl_test_init(void)
>   
>   		pdev = platform_device_alloc("cxl_switch_dport", i);
>   		if (!pdev)
> -			goto err_port;
> +			goto err_dport;
>   		pdev->dev.parent = &uport->dev;
>   
>   		rc = platform_device_add(pdev);
>
diff mbox series

Patch

diff --git a/tools/testing/cxl/test/cxl.c b/tools/testing/cxl/test/cxl.c
index a072b2d3e726..133e4c73d370 100644
--- a/tools/testing/cxl/test/cxl.c
+++ b/tools/testing/cxl/test/cxl.c
@@ -695,7 +695,7 @@  static __init int cxl_test_init(void)
 
 		pdev = platform_device_alloc("cxl_switch_uport", i);
 		if (!pdev)
-			goto err_port;
+			goto err_uport;
 		pdev->dev.parent = &root_port->dev;
 
 		rc = platform_device_add(pdev);
@@ -713,7 +713,7 @@  static __init int cxl_test_init(void)
 
 		pdev = platform_device_alloc("cxl_switch_dport", i);
 		if (!pdev)
-			goto err_port;
+			goto err_dport;
 		pdev->dev.parent = &uport->dev;
 
 		rc = platform_device_add(pdev);