| Message ID | 168149844596.792294.8273108394688012953.stgit@dwillia2-xfh.jf.intel.com |
|---|---|
| State | Accepted |
| Commit | 104087a8aaf0f46d89376917eca977fad972cc93 |
| Headers | show |
| Series | cxl/hdm: Decoder enumeration fixes | expand |
On Fri, Apr 14, 2023 at 11:54:06AM -0700, Dan Williams wrote: > After the discovery of a case where an implementation misbehaves with > register reads larger than the definition of the register the other > usages of readq() were audited and found to be correct, but some cases > where the io-64-nonatomic-lo-hi.h include is not needed were discovered, > delete them. > > Signed-off-by: Dan Williams <dan.j.williams@intel.com> Reviewed-by: Alison Schofield <alison.schofield@intel.com> > --- > drivers/cxl/core/mbox.c | 1 - > drivers/cxl/core/port.c | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c > index f2addb457172..6198637cb0bb 100644 > --- a/drivers/cxl/core/mbox.c > +++ b/drivers/cxl/core/mbox.c > @@ -1,6 +1,5 @@ > // SPDX-License-Identifier: GPL-2.0-only > /* Copyright(c) 2020 Intel Corporation. All rights reserved. */ > -#include <linux/io-64-nonatomic-lo-hi.h> > #include <linux/security.h> > #include <linux/debugfs.h> > #include <linux/ktime.h> > diff --git a/drivers/cxl/core/port.c b/drivers/cxl/core/port.c > index 4d1f9c5b5029..b060757c4000 100644 > --- a/drivers/cxl/core/port.c > +++ b/drivers/cxl/core/port.c > @@ -1,6 +1,5 @@ > // SPDX-License-Identifier: GPL-2.0-only > /* Copyright(c) 2020 Intel Corporation. All rights reserved. */ > -#include <linux/io-64-nonatomic-lo-hi.h> > #include <linux/memregion.h> > #include <linux/workqueue.h> > #include <linux/debugfs.h> >
On 4/14/23 11:54 AM, Dan Williams wrote: > After the discovery of a case where an implementation misbehaves with > register reads larger than the definition of the register the other > usages of readq() were audited and found to be correct, but some cases > where the io-64-nonatomic-lo-hi.h include is not needed were discovered, > delete them. > > Signed-off-by: Dan Williams <dan.j.williams@intel.com> Reviewed-by: Dave Jiang <dave.jiang@intel.com> > --- > drivers/cxl/core/mbox.c | 1 - > drivers/cxl/core/port.c | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c > index f2addb457172..6198637cb0bb 100644 > --- a/drivers/cxl/core/mbox.c > +++ b/drivers/cxl/core/mbox.c > @@ -1,6 +1,5 @@ > // SPDX-License-Identifier: GPL-2.0-only > /* Copyright(c) 2020 Intel Corporation. All rights reserved. */ > -#include <linux/io-64-nonatomic-lo-hi.h> > #include <linux/security.h> > #include <linux/debugfs.h> > #include <linux/ktime.h> > diff --git a/drivers/cxl/core/port.c b/drivers/cxl/core/port.c > index 4d1f9c5b5029..b060757c4000 100644 > --- a/drivers/cxl/core/port.c > +++ b/drivers/cxl/core/port.c > @@ -1,6 +1,5 @@ > // SPDX-License-Identifier: GPL-2.0-only > /* Copyright(c) 2020 Intel Corporation. All rights reserved. */ > -#include <linux/io-64-nonatomic-lo-hi.h> > #include <linux/memregion.h> > #include <linux/workqueue.h> > #include <linux/debugfs.h> >
On Fri, 14 Apr 2023 11:54:06 -0700 Dan Williams <dan.j.williams@intel.com> wrote: > After the discovery of a case where an implementation misbehaves with > register reads larger than the definition of the register the other > usages of readq() were audited and found to be correct, but some cases > where the io-64-nonatomic-lo-hi.h include is not needed were discovered, > delete them. > > Signed-off-by: Dan Williams <dan.j.williams@intel.com> Fair enough if this passes 0-day. Everytime I try to drop io-64-nonatomic-lo-hi.h or similar I find some weird arch choice that needs it (mostly 32 bit arches, so maybe we don't care here). Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > --- > drivers/cxl/core/mbox.c | 1 - > drivers/cxl/core/port.c | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c > index f2addb457172..6198637cb0bb 100644 > --- a/drivers/cxl/core/mbox.c > +++ b/drivers/cxl/core/mbox.c > @@ -1,6 +1,5 @@ > // SPDX-License-Identifier: GPL-2.0-only > /* Copyright(c) 2020 Intel Corporation. All rights reserved. */ > -#include <linux/io-64-nonatomic-lo-hi.h> > #include <linux/security.h> > #include <linux/debugfs.h> > #include <linux/ktime.h> > diff --git a/drivers/cxl/core/port.c b/drivers/cxl/core/port.c > index 4d1f9c5b5029..b060757c4000 100644 > --- a/drivers/cxl/core/port.c > +++ b/drivers/cxl/core/port.c > @@ -1,6 +1,5 @@ > // SPDX-License-Identifier: GPL-2.0-only > /* Copyright(c) 2020 Intel Corporation. All rights reserved. */ > -#include <linux/io-64-nonatomic-lo-hi.h> > #include <linux/memregion.h> > #include <linux/workqueue.h> > #include <linux/debugfs.h> >
diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c index f2addb457172..6198637cb0bb 100644 --- a/drivers/cxl/core/mbox.c +++ b/drivers/cxl/core/mbox.c @@ -1,6 +1,5 @@ // SPDX-License-Identifier: GPL-2.0-only /* Copyright(c) 2020 Intel Corporation. All rights reserved. */ -#include <linux/io-64-nonatomic-lo-hi.h> #include <linux/security.h> #include <linux/debugfs.h> #include <linux/ktime.h> diff --git a/drivers/cxl/core/port.c b/drivers/cxl/core/port.c index 4d1f9c5b5029..b060757c4000 100644 --- a/drivers/cxl/core/port.c +++ b/drivers/cxl/core/port.c @@ -1,6 +1,5 @@ // SPDX-License-Identifier: GPL-2.0-only /* Copyright(c) 2020 Intel Corporation. All rights reserved. */ -#include <linux/io-64-nonatomic-lo-hi.h> #include <linux/memregion.h> #include <linux/workqueue.h> #include <linux/debugfs.h>
After the discovery of a case where an implementation misbehaves with register reads larger than the definition of the register the other usages of readq() were audited and found to be correct, but some cases where the io-64-nonatomic-lo-hi.h include is not needed were discovered, delete them. Signed-off-by: Dan Williams <dan.j.williams@intel.com> --- drivers/cxl/core/mbox.c | 1 - drivers/cxl/core/port.c | 1 - 2 files changed, 2 deletions(-)