| Message ID | 20210415232610.603273-2-ben.widawsky@intel.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/3] cxl/mem: Fix register block offset calculation | expand |
On Thu, 2021-04-15 at 16:26 -0700, Ben Widawsky wrote: > Trivial. The spec lists these as hex, so do the same here to make > debugging easier. > > Fixes: 8adaf747c9f0b ("cxl/mem: Find device capabilities") > Signed-off-by: Ben Widawsky <ben.widawsky@intel.com> > --- > drivers/cxl/mem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cxl/mem.c b/drivers/cxl/mem.c > index 1b5078311f7d..c05617b0ba4b 100644 > --- a/drivers/cxl/mem.c > +++ b/drivers/cxl/mem.c > @@ -939,7 +939,7 @@ static int cxl_mem_setup_regs(struct cxl_mem *cxlm) > cxlm->memdev_regs = register_block; > break; > default: > - dev_dbg(dev, "Unknown cap ID: %d (0x%x)\n", cap_id, offset); > + dev_dbg(dev, "Unknown cap ID: %x (0x%x)\n", cap_id, offset); Would %#x be better just for making it unambiguous? Maybe also change the adjacent 0x%x to %#x while at it. > break; > } > }
diff --git a/drivers/cxl/mem.c b/drivers/cxl/mem.c index 1b5078311f7d..c05617b0ba4b 100644 --- a/drivers/cxl/mem.c +++ b/drivers/cxl/mem.c @@ -939,7 +939,7 @@ static int cxl_mem_setup_regs(struct cxl_mem *cxlm) cxlm->memdev_regs = register_block; break; default: - dev_dbg(dev, "Unknown cap ID: %d (0x%x)\n", cap_id, offset); + dev_dbg(dev, "Unknown cap ID: %x (0x%x)\n", cap_id, offset); break; } }
Trivial. The spec lists these as hex, so do the same here to make debugging easier. Fixes: 8adaf747c9f0b ("cxl/mem: Find device capabilities") Signed-off-by: Ben Widawsky <ben.widawsky@intel.com> --- drivers/cxl/mem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)