| Message ID | 20220715062550.789736-9-vishal.l.verma@intel.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | cxl: add region management | expand |
Vishal Verma wrote: > Instead of only listing regions by default (which can often be empty if > no regions have been configured), change the default listing mode to > both memdevs and regions. This will allow a plain 'cxl-list' to be a > quick health check of whether all the expected memdevs have enumerated > correctly, and see any regions that have been configured. Looks good. Reviewed-by: Dan Williams <dan.j.williams@intel.com>
diff --git a/cxl/list.c b/cxl/list.c index 88ca9d9..5f604ec 100644 --- a/cxl/list.c +++ b/cxl/list.c @@ -100,9 +100,10 @@ int cmd_list(int argc, const char **argv, struct cxl_ctx *ctx) param.regions = true; } - /* List regions by default */ + /* List regions and memdevs by default */ if (num_list_flags() == 0) { param.regions = true; + param.memdevs = true; } log_init(¶m.ctx, "cxl list", "CXL_LIST_LOG");
Instead of only listing regions by default (which can often be empty if no regions have been configured), change the default listing mode to both memdevs and regions. This will allow a plain 'cxl-list' to be a quick health check of whether all the expected memdevs have enumerated correctly, and see any regions that have been configured. Cc: Dan Williams <dan.j.williams@intel.com> Signed-off-by: Vishal Verma <vishal.l.verma@intel.com> --- cxl/list.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)